fix: fix color fetching bug with some cards + minor code improvements

- minor code improvements
- fix a bug with some cards not having `div.color` directly inside
  `div.backCol`

Author: coko7

README.md

@@ -4,6 +4,8 @@
 
 A CLI utility to retrieve data for the One Piece Trading Cards Game (TCG).
 
+The CLI directly goes against the [onepiece-cardgame.com](onepiece-cardgame.com) website and attempts to scrap information such as packs, cards and images.
+
 ## Where is the data?
 
 For practical reasons, data is kept in a separate repository: https://github.com/Coko7/vegapull-records

src/card/scraper.rs

@@ -122,7 +122,7 @@ impl CardScraper {
     }
 
     pub fn fetch_colors(localizer: &Localizer, element: ElementRef) -> Result<Vec<CardColor>> {
-        let sel = "dd>div.backCol>div.color";
+        let sel = "dd>div.backCol div.color";
         trace!("fetching card.colors ({})...", sel);
 
         let raw_colors = Self::get_child_node(element, sel.to_string())?.inner_html();

src/pack.rs

@@ -33,22 +33,19 @@ impl Pack {
     fn process_title_parts(raw_title: &str) -> Result<TitleParts> {
         let mut processed_title: String = raw_title.to_string();
 
-        let label = Self::get_label_from_title(&raw_title)?;
+        let label = Self::get_label_from_title(raw_title)?;
         if let Some(ref label) = label {
-            processed_title = Self::remove_label_from_title(&processed_title, &label)?
+            processed_title = Self::remove_label_from_title(&processed_title, label)?
                 .trim()
                 .to_string();
         }
 
-        let prefix = Self::get_prefix_from_title(&raw_title)?;
+        let prefix = Self::get_prefix_from_title(raw_title)?;
         if let Some(ref prefix) = prefix {
             processed_title = processed_title.replace(prefix, "");
         }
 
-        let prefix = match prefix {
-            Some(val) => Some(val.trim().to_string()),
-            None => None,
-        };
+        let prefix = prefix.map(|val| val.trim().to_string());
 
         if processed_title.starts_with("-") {
             processed_title = processed_title[1..].to_string();