Commit 5d4a1bc
authored
Fix the bootstrap test in GitHub Actions (#474)
Installing the test dependencies like this also enables importing from
the package itself, which is contrary to the bootstrapping scenario
we're trying to test. Simplest solution is to specifically uninstall it
again, which should leave all of the dependencies in place.
Additionally, the test results during the bootstrap build were not
causing the action to fail, and were therefore being ignored.
Furthermore, it appears that the COLCON_ALL_SHELLS variable is not
sufficient to generate usable bash hooks on Windows, so I'm disabling
the bash test until we can come up with a good way to support it.
Lastly, while in the package root, it's possible to perform imports from
colcon_core as if it were already installed. The bootstrap scenario
doesn't necessitate running from the repository root, so the test
shouldn't do so either.1 parent 76b0a24 commit 5d4a1bc
1 file changed
+5
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| 48 | + | |
48 | 49 | | |
49 | | - | |
50 | | - | |
51 | 50 | | |
52 | | - | |
53 | | - | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
54 | 54 | | |
| 55 | + | |
55 | 56 | | |
56 | 57 | | |
57 | 58 | | |
| |||
0 commit comments