Make subprocess calls faster by not using ProcessPoolExecutor #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Move dependency on setuptools closer to where it's needed 2. Scope multiprocessing Pool so a pool left open doesn't hang the process 3. Move run_setup_py to its own file so the subprocess doesn't need to import much
Closed
Member
|
Please spend the time to write a description what this PR contains, and if applicable what other PRs it replaces. Also please address the CI failure. |
Contributor
Author
|
Done. |
Member
Still failing CI. |
Contributor
Author
|
d'oh! |
Member
Member
I will go ahead and close the ticket for now. Please feel free to rebase / update the branch and it can be reopened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #22, #24
Adds and uses a new function wrapper
out_of_processwhich wraps a python function into a subprocess.Address some performance concerns by using multiprocessing.Process instead of multiprocessing.Pool when we’re not reusing the same pool.