fix AttributeError when reading metadata dict #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmichaels11
approved these changes
Mar 6, 2020
zmichaels11
left a comment
zmichaels11
left a comment
There was a problem hiding this comment.
This will change the exception to a log.
Does this allow a python module to still build?
Member
Author
Can you please clarify what kind of "log" you are referring to? Before the build fails with an
I don't know what you mean with this. Before the package build was not even attempted since the metadata couldn't be processed correctly. After the build is invoked and passes. |
|
Confirmed this does build the package. ubuntu@hostname:~/ws$ colcon build --event-handlers console_direct+
Starting >>> test-py-module
running egg_info
writing /home/ubuntu/ws/build/test-py-module/test_py_module.egg-info/PKG-INFO
writing dependency_links to /home/ubuntu/ws/build/test-py-module/test_py_module.egg-info/dependency_links.txt
writing requirements to /home/ubuntu/ws/build/test-py-module/test_py_module.egg-info/requires.txt
writing top-level names to /home/ubuntu/ws/build/test-py-module/test_py_module.egg-info/top_level.txt
reading manifest file '/home/ubuntu/ws/build/test-py-module/test_py_module.egg-info/SOURCES.txt'
writing manifest file '/home/ubuntu/ws/build/test-py-module/test_py_module.egg-info/SOURCES.txt'
running build
running build_py
running install
running install_lib
running install_egg_info
removing '/home/ubuntu/ws/install/test-py-module/lib/python3.6/site-packages/test_py_module-0.1-py3.6.egg-info' (and everything under it)
Copying /home/ubuntu/ws/build/test-py-module/test_py_module.egg-info to /home/ubuntu/ws/install/test-py-module/lib/python3.6/site-packages/test_py_module-0.1-py3.6.egg-info
running install_scripts
writing list of installed files to '/home/ubuntu/ws/build/test-py-module/install.log'
Finished <<< test-py-module [0.71s]
Summary: 1 package finished [1.32s]Expected output: ubuntu@hostname:~/ws$ colcon build --event-handlers console_direct+
Starting >>> test-py-module
running egg_info
creating /home/ubuntu/ws/build/test-py-module/test_py_module.egg-info
writing /home/ubuntu/ws/build/test-py-module/test_py_module.egg-info/PKG-INFO
writing dependency_links to /home/ubuntu/ws/build/test-py-module/test_py_module.egg-info/dependency_links.txt
writing requirements to /home/ubuntu/ws/build/test-py-module/test_py_module.egg-info/requires.txt
writing top-level names to /home/ubuntu/ws/build/test-py-module/test_py_module.egg-info/top_level.txt
writing manifest file '/home/ubuntu/ws/build/test-py-module/test_py_module.egg-info/SOURCES.txt'
reading manifest file '/home/ubuntu/ws/build/test-py-module/test_py_module.egg-info/SOURCES.txt'
writing manifest file '/home/ubuntu/ws/build/test-py-module/test_py_module.egg-info/SOURCES.txt'
running build
running build_py
creating /home/ubuntu/ws/build/test-py-module/build
creating /home/ubuntu/ws/build/test-py-module/build/lib
creating /home/ubuntu/ws/build/test-py-module/build/lib/test_py_module
copying test_py_module/__init__.py -> /home/ubuntu/ws/build/test-py-module/build/lib/test_py_module
copying test_py_module/run_annoy.py -> /home/ubuntu/ws/build/test-py-module/build/lib/test_py_module
running install
running install_lib
creating /home/ubuntu/ws/install/test-py-module/lib/python3.6/site-packages/test_py_module
copying /home/ubuntu/ws/build/test-py-module/build/lib/test_py_module/__init__.py -> /home/ubuntu/ws/install/test-py-module/lib/python3.6/site-packages/test_py_module
copying /home/ubuntu/ws/build/test-py-module/build/lib/test_py_module/run_annoy.py -> /home/ubuntu/ws/install/test-py-module/lib/python3.6/site-packages/test_py_module
byte-compiling /home/ubuntu/ws/install/test-py-module/lib/python3.6/site-packages/test_py_module/__init__.py to __init__.cpython-36.pyc
byte-compiling /home/ubuntu/ws/install/test-py-module/lib/python3.6/site-packages/test_py_module/run_annoy.py to run_annoy.cpython-36.pyc
running install_egg_info
Copying /home/ubuntu/ws/build/test-py-module/test_py_module.egg-info to /home/ubuntu/ws/install/test-py-module/lib/python3.6/site-packages/test_py_module-0.1-py3.6.egg-info
running install_scripts
writing list of installed files to '/home/ubuntu/ws/build/test-py-module/install.log'
Finished <<< test-py-module [0.64s]
Summary: 1 package finished [1.03s] |
|
@dirk-thomas I updated the previous comment with the output from version 0.23 (installed via apt) and it looks like it did more in the previous version. |
Member
Author
|
I do get the same output as before - the one you mentioned as expected output - with this patch. Are you sure you performed both builds from a clean - not previously built - workspace? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve regression introduced in #30. Fixes #31.