Merge pull request #50 from GunnarLieb/development

better information in dev env, if debugger is not accessible

Author: lmajano

ModuleConfig.cfc

@@ -47,6 +47,9 @@ component {
 			// The debugger will still track requests even in non debug mode.
 			debugMode        : controller.getSetting( name = "environment", defaultValue = "production" ) == "development",
 			// The URL password to use to activate it on demand
+			// if set to cb:null, will generate random password
+			// to enable debugger in dev environment set to empty or custom password
+			// in live environment leave cb:null or set your own password
 			debugPassword    : "cb:null",
 			// This flag enables/disables the end of request debugger panel docked to the bottem of the page.
 			// If you disable i, then the only way to visualize the debugger is via the `/cbdebugger` endpoint

handlers/Main.cfc

@@ -30,11 +30,21 @@ component extends="coldbox.system.RestHandler" {
 	 * Debugger disabled event
 	 */
 	function disabled( event, rc, prc ){
+		var data = "Page Not Found";
+
+		if ( getSetting("environment") == "DEVELOPMENT" ){
+			data = ' isDebugCookieValid defined: ' &  debuggerService.isDebugCookieValid() ;
+			data &= ', secretKey defined: ' &  debuggerService.isSecretKeyDefined() ;
+			data &= ', doesCookieMatchesSecretKey: ' &  debuggerService.doesCookieMatchesSecretKey() ;
+
+			data &= ', debugMode: ' & debuggerService.getDebugMode();
+		}
+
 		event.renderData(
 			statusCode = 404,
 			statusText = "Not Found",
 			type       = "text",
-			data       = "Page Not Found"
+			data       = data
 		);
 	}
 

models/DebuggerService.cfc

@@ -146,22 +146,33 @@ component
 	 */
 	boolean function getDebugMode(){
 		// If no secretKey has been set, don't allow debug mode
-		if ( not ( len( variables.secretKey ) ) ) {
+		if ( not ( isSecretKeyDefined() ) ) {
 			return false;
 		}
 		// If Cookie exists, it's value is used.
 		if ( isDebugCookieValid() ) {
 			// Must be equal to the current secret key
-			if ( cookie[ variables.cookieName ] == variables.secretKey ) {
-				return true;
-			} else {
-				return false;
-			}
+			return doesCookieMatchesSecretKey()
 		}
 
 		// If there is no cookie, then use default to app setting
 		return variables.debugMode;
 	}
+	
+	/**
+	 * returns boolean if secret key is defined 
+	 * init() will set secret key
+	 */
+	boolean function isSecretKeyDefined(){
+		return javacast('Boolean',len( variables.secretKey ));
+	}
+
+	/**
+	 * checks if cookie matches secret key
+	 */
+	boolean function doesCookieMatchesSecretKey(){
+		return cookie[ variables.cookieName ] == variables.secretKey;
+	}
 
 	/**
 	 * Checks if the debug cookie is a valid cookie. Boolean