new layout and fixes

Author: lmajano

.cflintrc

@@ -0,0 +1,61 @@
+{
+    "rule": [],
+    "includes": [
+        { "code": "AVOID_USING_CFINCLUDE_TAG" },
+		{ "code": "AVOID_USING_CFABORT_TAG" },
+		{ "code": "AVOID_USING_CFEXECUTE_TAG" },
+		{ "code": "AVOID_USING_DEBUG_ATTR" },
+		{ "code": "AVOID_USING_ABORT" },
+		{ "code": "AVOID_USING_ISDATE" },
+		{ "code": "AVOID_USING_ISDEBUGMODE" },
+		{ "code": "AVOID_USING_CFINSERT_TAG" },
+		{ "code": "AVOID_USING_CFUPDATE_TAG" },
+		{ "code": "ARG_VAR_CONFLICT" },
+		{ "code": "ARG_HINT_MISSING" },
+		{ "code": "ARG_HINT_MISSING_SCRIPT" },
+		{ "code" : "ARGUMENT_INVALID_NAME" },
+		{ "code" : "ARGUMENT_ALLCAPS_NAME" },
+		{ "code" : "ARGUMENT_TOO_WORDY" },
+		{ "code" : "ARGUMENT_IS_TEMPORARY" },
+        { "code": "CFQUERYPARAM_REQ" },
+        { "code": "COMPARE_INSTEAD_OF_ASSIGN" },
+		{ "code": "COMPONENT_HINT_MISSING" },
+		{ "code" : "COMPONENT_INVALID_NAME" },
+		{ "code" : "COMPONENT_ALLCAPS_NAME" },
+		{ "code" : "COMPONENT_TOO_SHORT" },
+		{ "code" : "COMPONENT_TOO_LONG" },
+		{ "code" : "COMPONENT_TOO_WORDY" },
+		{ "code" : "COMPONENT_IS_TEMPORARY" },
+		{ "code" : "COMPONENT_HAS_PREFIX_OR_POSTFIX" },
+		{ "code": "COMPLEX_BOOLEAN_CHECK" },
+        { "code": "EXCESSIVE_FUNCTION_LENGTH" },
+        { "code": "EXCESSIVE_COMPONENT_LENGTH" },
+        { "code": "EXCESSIVE_ARGUMENTS" },
+		{ "code": "EXCESSIVE_FUNCTIONS" },
+		{ "code": "EXPLICIT_BOOLEAN_CHECK" },
+        { "code": "FUNCTION_TOO_COMPLEX" },
+		{ "code": "FUNCTION_HINT_MISSING" },
+		{ "code": "FILE_SHOULD_START_WITH_LOWERCASE" },
+        { "code": "LOCAL_LITERAL_VALUE_USED_TOO_OFTEN" },
+        { "code": "GLOBAL_LITERAL_VALUE_USED_TOO_OFTEN" },
+		{ "code": "MISSING_VAR" },
+		{ "code" : "METHOD_INVALID_NAME" },
+		{ "code" : "METHOD_ALLCAPS_NAME" },
+		{ "code" : "METHOD_IS_TEMPORARY" },
+		{ "code": "NESTED_CFOUTPUT" },
+		{ "code": "NEVER_USE_QUERY_IN_CFM" },
+		{ "code": "OUTPUT_ATTR" },
+		{ "code" : "QUERYPARAM_REQ" },
+        { "code": "UNUSED_LOCAL_VARIABLE" },
+        { "code": "UNUSED_METHOD_ARGUMENT" },
+		{ "code": "SQL_SELECT_STAR" },
+		{ "code": "SCOPE_ALLCAPS_NAME" },
+		{ "code": "VAR_ALLCAPS_NAME" },
+		{ "code": "VAR_INVALID_NAME" },
+		{ "code": "VAR_TOO_WORDY" }
+    ],
+    "inheritParent": false,
+    "parameters": {
+		"TooManyFunctionsChecker.maximum" : 20
+	}
+}

.editorconfig

@@ -0,0 +1,20 @@
+# http://editorconfig.org
+
+root = true
+
+[*]
+end_of_line = lf
+charset = utf-8
+trim_trailing_whitespace = true
+insert_final_newline = false
+indent_style = tab
+indent_size = 4
+tab_width = 4
+
+[*.yml]
+indent_style = space
+indent_size = 2
+
+[*.{md,markdown}]
+trim_trailing_whitespace = false
+insert_final_newline = false

.gitignore

@@ -1,14 +1,14 @@
-# IDE Stuff
-.settings
-settings.xml
-# Logs
-logs/*.log
-# Test Results
-tests/results/*
-# Dependenncies
-coldbox/*
-testbox/*
-artifacts/*
-apidocs/docbox/*
-workbench/*
-build/*
+.vscode
+
+.artifacts/**
+.tmp/**
+
+test-harness/.engine/**
+test-harness/coldbox/**
+test-harness/docbox/**
+test-harness/testbox/**
+test-harness/logs/**
+test-harness/modules/**
+
+# log files
+logs/**

.module.properties

@@ -5,14 +5,14 @@ notifications:
     secure: FIHlTn/YO7Wgumm1uIqmoEsqjQA7fV0AE94Rjc5yKzM3AquQa8HicgDVVk0d2GrKRnl0xt3j4ZJV//VJyIjlCd/QVKuj48R2ChjEY2im3+99HFPafCUI5/S2uyowKU6mJTFonH9v6p41eqxdbiAxJdDGOT0V2Gpt3UBSNuHz8ED9/aIHqv+P7M+VD6Xd2XYwctPniWlaSWx57sWcnG/VkFG45qFQAyha64uxOOe4M3ZmG/n5FfauZ8cBVLiRKEIr+CyNhh1ujfzi7+4uzMlSNL5t/BbZamAQuZzqGzGQ9RVvIlyPgUGNJtDEE/hWS09aagXF5T6EMj00szizErh4J1/x4qZwml5+TcBN31E0QmAhCtZe85sr3tYgic+hEz9XX1yymQzf/C7n4to2yNvq0r4g51xDk8IuP95WEh7zaqLlvFZvBFgxpHZBMYlRvhytjOYDeIFRMcGwHZcXosaG2ejqDwcGq/LC4oeG4sSwmg9sdRrtcmcanrNqrBka86WYO6LntI3JdZ86/1ACEUHzhCCwvrKELc9Ji1xxGAgS7QKH+s2/hnJuiMyv73gOVLKYC+wPMLt+fvOmPLSEl+PJiAIlToBq1KUBg03RSQLfPOLD7OrJ8VvDZsEPwejqlGDyc4wRglS9OTi7SnN5LYHSDNDdGdREegWqq9qDHEYEVLI=
 
 env:
+  # Fill out these global variables for build process
   global:
     - MODULE_ID=cbdebugger
   matrix:
-    - [email protected]
     - ENGINE=lucee@5
-    - ENGINE=adobe@10
     - ENGINE=adobe@11
     - ENGINE=adobe@2016
+    - ENGINE=adobe@2018
 
 branches:
   only:
@@ -25,75 +25,85 @@ sudo: required
 
 before_install:
   # CommandBox Keys
-  - sudo apt-key adv --keyserver keys.gnupg.net --recv 6DA70622
+  - curl -fsSl https://downloads.ortussolutions.com/debs/gpg | sudo apt-key add -
   - sudo echo "deb http://downloads.ortussolutions.com/debs/noarch /" | sudo tee -a
     /etc/apt/sources.list.d/commandbox.list
 
 install:
   # Install Commandbox
-  - sudo apt-get update && sudo apt-get --assume-yes install git haveged rsync commandbox
-  # Test that the box binary is available and ready for our tests
-  - box version
+  - sudo apt-get update && sudo apt-get --assume-yes install rsync jq commandbox
+  # Install CommandBox Supporting Librarires
+  - box install commandbox-cfconfig,commandbox-dotenv,commandbox-docbox
   # If using auto-publish, you will need to provide your API token with this line:
   - box config set endpoints.forgebox.APIToken=$FORGEBOX_API_TOKEN > /dev/null
-  # Setup for our tests
-  - mkdir tests/results
-  - sudo chmod -R 775 tests/results
 
-# Build script - note module versioning is passed to ANT
 script:
+  # Set Current Version
+  - TARGET_VERSION=`cat $TRAVIS_BUILD_DIR/box.json | jq '.version' -r`
+  - echo "Starting build for ${MODULE_ID} v${TARGET_VERSION}"
+  # Replace version so builder can issue it
+  - box package set [email protected]@[email protected]@
+  # Startup the harness
+  - cd test-harness
   # run our dependency install to ensure the workbench is in place
   - box install
-  # add our module-specific build properties
-  - printf "\nmodule.name=$MODULE_ID" >> workbench/build.properties
-  - printf "\ncfengine=$ENGINE" >> workbench/build.properties
-  # execute our build
-  - ant -DisTravis=true -Dbuild.number=$TRAVIS_BUILD_NUMBER -Dbuild.branch=$TRAVIS_BRANCH -f workbench/build.xml
+  # run our matrix server
+  - box server start serverConfigFile="server-${ENGINE}.json"
+  # Startup the app
+  - curl http://localhost:60299
+  # Debugging of tests
+  #- curl http://localhost:60299/tests/runner.cfm?reporter=json -o testresults.json && cat testresults.json
+  # move back to build dir to build it
+  - cd $TRAVIS_BUILD_DIR
+  # Build Project
+  - box task run taskfile=build/Build target=run :version=${TARGET_VERSION} :projectName=${MODULE_ID} :buildID=${TRAVIS_BUILD_NUMBER} :branch=${TRAVIS_BRANCH}
+  # Cat results for debugging
+  - cat build/results.json
 
 after_failure:
-  - cd $TRAVIS_BUILD_DIR
+  - cd $TRAVIS_BUILD_DIR/test-harness
   # Display the contents of our root directory
   # Spit out our Commandbox log in case we need to debug
-  - box server log name=$ENGINE
+  - box server log server-${ENGINE}.json
   - cat `box system-log`
-  
-before_deploy:
-  - cd $TRAVIS_BUILD_DIR
-  - mkdir -p s3deploy
-  - rsync -av ./artifacts/$MODULE_ID/ ./s3deploy/
-  - rm -f ./s3deploy/box-repo.json
 
 deploy:
-  #Module Deployment
+  # Module Deployment
   - provider: s3
     on:
-      branch: 
+      branch:
         - master
         - development
-      condition: "$ENGINE = lucee@4.5"
+      condition: "$ENGINE = lucee@5"
     skip_cleanup: true
     #AWS Credentials need to be set in Travis
     access_key_id: $AWS_ACCESS_KEY
     secret_access_key: $AWS_ACCESS_SECRET
+    # Destination
     bucket: "downloads.ortussolutions.com"
-    local-dir: s3deploy
+    local-dir: $TRAVIS_BUILD_DIR/.artifacts/$MODULE_ID
     upload-dir: ortussolutions/coldbox-modules/$MODULE_ID
     acl: public_read
-  #API Docs Deployment
+
+  # API Docs Deployment
   - provider: s3
     on:
-      branch: 
+      branch:
         - master
-      condition: "$ENGINE = [email protected]"
+        - development
+      condition: "$ENGINE = lucee@5"
     skip_cleanup: true
     #AWS Credentials need to be set in Travis
     access_key_id: $AWS_ACCESS_KEY
     secret_access_key: $AWS_ACCESS_SECRET
     bucket: "apidocs.ortussolutions.com"
-    local-dir: build/apidocs
-    upload-dir: coldbox-modules/$MODULE_ID
+    local-dir: $TRAVIS_BUILD_DIR/.tmp/apidocs
+    upload-dir: coldbox-modules/$MODULE_ID/$TARGET_VERSION
     acl: public_read
 
-
 after_deploy:
-  - cd $TRAVIS_BUILD_DIR/build && box forgebox publish
+  # Move to build out artifact
+  - cd ${TRAVIS_BUILD_DIR}/.tmp/${MODULE_ID}
+  - cat box.json
+  # Only publish once
+  - if [ ${ENGINE} = 'lucee@5' ]; then box forgebox publish; fi

.travis.yml

@@ -8,9 +8,8 @@ component {
 	// Module Properties
 	this.title 				= "ColdBox Debugger";
 	this.author 			= "Curt Gratz - Ortus Solutions";
-	this.webURL 			= "http://www.ortussolutions.com";
+	this.webURL 			= "https://www.ortussolutions.com";
 	this.description 		= "The ColdBox Debugger Module";
-	this.version			= "@build.version@[email protected]@";
 	// If true, looks for views in the parent first, if not found, then in the module. Else vice-versa
 	this.viewParentLookup 	= true;
 	// If true, looks for layouts in the parent first, if not found, then in module. Else vice-versa
@@ -23,13 +22,23 @@ component {
 	this.modelNamespace		= "cbdebugger";
 	// Auto Map Models Directory
 	this.autoMapModels		= true;
+	// App Helpers
+	this.applicationHelper = [
+		"models/Mixins.cfm"
+	]
 
 	/**
 	* Module Registration
 	*/
 	function configure(){
-		// Mixin our own methods on handlers, interceptors and views via the ColdBox UDF Library File setting
-		arrayAppend( controller.getSetting( "ApplicationHelper" ), "#moduleMapping#/models/Mixins.cfm" );
+
+		variables.interceptorSettings = {
+			customInterceptionPoints = [
+				"beforeDebuggerPanel",
+				"afterDebuggerPanel"
+			]
+		};
+
 	}
 
 	/**
@@ -53,11 +62,12 @@ component {
 			.setDebugMode( settings.debugger.debugMode );
 
 		// Register the interceptor, it has to be here due to loading of configuration files.
-		controller.getInterceptorService()
+		controller
+			.getInterceptorService()
 			.registerInterceptor( 
-			interceptorClass="#moduleMapping#.interceptors.Debugger",
-			interceptorName="debugger@cbdebugger"
-		);
+				interceptorClass	= "#moduleMapping#.interceptors.Debugger",
+				interceptorName		= "debugger@cbdebugger"
+			);
 	}
 
 	/**