* Ability to open CFCs that are profiled by the WireBox Collector in any Code Editor.

* Ability to open the Handler events that are profiled by the Request Collector in any Code Editor.

Author: lmajano

aspects/ObjectProfiler.cfc

@@ -24,7 +24,8 @@ component implements="coldbox.system.aop.MethodInterceptor" accessors="true" {
 	 */
 	any function invokeMethod( required invocation ) output=false{
 		// default tx name
-		var txName = "[Object Profiler] #arguments.invocation.getTargetName()#.#arguments.invocation.getMethod()#()";
+		var txName        = "[Object Profiler] #arguments.invocation.getTargetName()#.#arguments.invocation.getMethod()#()";
+		var targetMapping = arguments.invocation.getTargetMapping();
 
 		// check metadata for tx name if they desire to influence the label
 		var methodMD = arguments.invocation.getMethodMetadata();
@@ -33,7 +34,16 @@ component implements="coldbox.system.aop.MethodInterceptor" accessors="true" {
 		}
 
 		// create with method name
-		variables.timerService.start( txName );
+		variables.timerService.start(
+			label   : txName,
+			metadata: {
+				path : targetMapping.getObjectMetadata()?.path ?: targetMapping.getPath(),
+				name : targetMapping.getName(),
+				type : targetMapping.getType(),
+				line : methodMD.keyExists( "position" ) ? methodMD.position.start : 1
+			},
+			type: "object-profiler"
+		);
 
 		// proceed invocation
 		var results = arguments.invocation.proceed();

changelog.md

@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * Ability to open views and layouts from the execution timers in any Code Editor
 * New WireBoxCollector which is only used if enabled.  This greatly accelerates the performance of the request collector since before they where in the same collector.
 * Ability to open CFCs that are profiled by the WireBox Collector in any Code Editor.
+* Ability to open the Handler events that are profiled by the Request Collector in any Code Editor.
 
 ### Fixed
 

interceptors/RequestCollector.cfc

@@ -139,7 +139,26 @@ component extends="coldbox.system.Interceptor" {
 	 * Listen to end of ColdBox events
 	 */
 	function postEvent( event, interceptData, rc, prc ){
-		variables.timerService.stop( "[runEvent] #arguments.interceptData.processedEvent#" );
+		// new coldbox tracking of events
+		if ( arguments.interceptData.keyExists( "ehBean" ) ) {
+			var handlerMD = interceptData.ehBean.getHandlerMetadata();
+			var position  = handlerMD.functions
+				.filter( function( thisItem ){
+					return thisItem.name == interceptData.ehBean.getMethod();
+				} )
+				.reduce( function( result, thisItem ){
+					return thisItem.keyExists( "position" ) ? thisItem.position.start : result;
+				}, 1 );
+			variables.timerService.stop(
+				label   : "[runEvent] #arguments.interceptData.processedEvent#",
+				metadata: { path : handlerMD.path, line : position }
+			);
+		} else {
+			variables.timerService.stop(
+				label   : "[runEvent] #arguments.interceptData.processedEvent#",
+				metadata: { path : "", line : 1 }
+			);
+		}
 	}
 
 	/**
@@ -171,7 +190,8 @@ component extends="coldbox.system.Interceptor" {
 				"cacheLastAccessTimeout" : arguments.interceptData.cacheLastAccessTimeout,
 				"cacheSuffix"            : arguments.interceptData.cacheSuffix,
 				"cacheProvider"          : arguments.interceptData.cacheProvider,
-				"viewPath"               : ""
+				"path"                   : "",
+				"line"                   : 1
 			},
 			type: "view-render"
 		);
@@ -184,7 +204,7 @@ component extends="coldbox.system.Interceptor" {
 		variables.timerService.stop(
 			label: "[renderView] #arguments.interceptData.view#" &
 			( len( arguments.interceptData.module ) ? "@#arguments.interceptData.module#" : "" ),
-			metadata: { viewPath : arguments.interceptData.viewPath ?: "" }
+			metadata: { path : expandPath( arguments.interceptData.viewPath ) & ".cfm" }
 		);
 	}
 
@@ -200,7 +220,8 @@ component extends="coldbox.system.Interceptor" {
 				"module"     : arguments.interceptData.module,
 				"view"       : arguments.interceptData.view,
 				"viewModule" : arguments.interceptData.viewModule,
-				"viewPath"   : ""
+				"path"       : "",
+				"line"       : 1
 			},
 			type: "layout-render"
 		);
@@ -213,7 +234,7 @@ component extends="coldbox.system.Interceptor" {
 		variables.timerService.stop(
 			label: "[renderLayout] #arguments.interceptData.layout#" &
 			( len( arguments.interceptData.module ) ? "@#arguments.interceptData.module#" : "" ),
-			metadata: { viewPath : arguments.interceptData.viewPath ?: "" }
+			metadata: { path : expandPath( arguments.interceptData.viewPath ) & ".cfm" }
 		);
 	}
 

interceptors/WireBoxCollector.cfc

@@ -27,7 +27,8 @@ component extends="coldbox.system.Interceptor" {
 			metadata: {
 				path : "",
 				name : arguments.interceptData.mapping.getName(),
-				type : arguments.interceptData.mapping.getType()
+				type : arguments.interceptData.mapping.getType(),
+				line : 1
 			},
 			type: "wirebox-creation"
 		);

test-harness/Application.cfc

@@ -74,6 +74,8 @@ component {
 		skipcfcWithError      : false
 	};
 
+	//applicationStop();abort;
+
 	// application start
 	public boolean function onApplicationStart(){
 		application.cbBootstrap = new coldbox.system.Bootstrap(

test-harness/config/Coldbox.cfc

@@ -86,9 +86,9 @@
 					// How many tracking profilers to keep in stack: Default is to monitor the last 20 requests
 					maxProfilers                 : 25,
 					// If enabled, the debugger will monitor the creation time of CFC objects via WireBox
-					profileWireBoxObjectCreation : true,
+					profileWireBoxObjectCreation : false,
 					// Profile model objects annotated with the `profile` annotation
-					profileObjects               : false,
+					profileObjects               : true,
 					// If enabled, will trace the results of any methods that are being profiled
 					traceObjectResults           : false,
 					// Profile Custom or Core interception points

views/main/panels/requestTracker/debugTimersPanel.cfm

@@ -53,7 +53,7 @@
 
 			<!--- Show Timers if any are found --->
 			<cfif structCount( args.timers )>
-				<cfloop collection="#args.timers#" index="timerKey">
+				<cfloop collection="#args.timers#" item="timerKey">
 					<cfset thisTimer = args.timers[ timerKey ]>
 
 					<cfif findnocase( "[render", thisTimer.method )>
@@ -98,28 +98,11 @@
 						<!--- Open --->
 						<td align="center" >
 							<!--- View Render --->
-							<cfif listContains( "view-render,layout-render", thisTimer.type ) and len( thisTimer.metadata?.viewPath )>
+							<cfif len( thisTimer.metadata?.path )>
 								<a
 									href="#args.debuggerService.openInEditorURL( event, {
-										template : expandPath( thisTimer.metadata.viewPath ) & ".cfm",
-										line : 1
-									} )#"
-									title="Open in Editor"
-									class="cbd-button"
-									target="_self"
-									rel="noreferrer noopener"
-								>
-									<svg xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 24 24" stroke="currentColor">
-										<path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M10 20l4-16m4 4l4 4-4 4M6 16l-4-4 4-4" />
-									</svg>
-								</a>
-
-							<!--- Open Wirebox Creation Objects --->
-							<cfelseif thisTimer.type eq "wirebox-creation" && isSimpleValue( thisTimer.metadata.path ) && len( thisTimer.metadata.path ) >
-								<a
-									href="#args.debuggerService.openInEditorURL( event, {
-										template : expandPath( thisTimer.metadata.path ),
-										line : 1
+										template : thisTimer.metadata.path,
+										line : thisTimer.metadata.line
 									} )#"
 									title="Open in Editor"
 									class="cbd-button"