Skip to content

Commit f85e35b

Browse files
committed
Properly scope local view variables
1 parent 3c8c412 commit f85e35b

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

includes/panels/qbPanel.cfm

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -12,29 +12,29 @@ Description :
1212
Debugging template for the application
1313
----------------------------------------------------------------------->
1414
<cfscript>
15-
isQuickInstalled = event.getController().getModuleService().isModuleRegistered( "quick" );
16-
isQBInstalled = event.getController().getModuleService().isModuleRegistered( "qb" );
17-
totalQueries = request.cbdebugger.keyExists( "qbQueries" ) ? request.cbdebugger.qbQueries.all.len() : 0;
18-
totalExecutionTime = !request.cbdebugger.keyExists( "qbQueries" ) ? 0 : request.cbdebugger.qbQueries.all.reduce( function( total, q ) {
15+
local.isQuickInstalled = event.getController().getModuleService().isModuleRegistered( "quick" );
16+
local.isQBInstalled = event.getController().getModuleService().isModuleRegistered( "qb" );
17+
local.totalQueries = request.cbdebugger.keyExists( "qbQueries" ) ? request.cbdebugger.qbQueries.all.len() : 0;
18+
local.totalExecutionTime = !request.cbdebugger.keyExists( "qbQueries" ) ? 0 : request.cbdebugger.qbQueries.all.reduce( function( total, q ) {
1919
return total + q.executionTime;
2020
}, 0 );
21-
totalEntities = request.cbdebugger.keyExists( "quick" ) ? request.cbdebugger.quick.total : 0;
21+
local.totalEntities = request.cbdebugger.keyExists( "quick" ) ? request.cbdebugger.quick.total : 0;
2222
</cfscript>
2323
<cfoutput>
2424
<div class="fw_titles" onClick="fw_toggle('fw_qbPanel')" >
25-
&nbsp;<cfif isQuickInstalled>Quick &##47; </cfif>qb
25+
&nbsp;<cfif local.isQuickInstalled>Quick &##47; </cfif>qb
2626
</div>
2727
<div class="fw_debugContent<cfif instance.debuggerConfig.expandedQBPanel>View</cfif>" id="fw_qbPanel">
2828
<div id="qbQueries">
29-
<cfif NOT isQBInstalled>
29+
<cfif NOT local.isQBInstalled>
3030
qb is not installed or registered.
3131
<cfelse>
32-
<div class="fw_subtitles">&nbsp;Queries <span class="fw_badge_dark" style="margin-left: 1em;">#totalQueries#</span></div>
32+
<div class="fw_subtitles">&nbsp;Queries <span class="fw_badge_dark" style="margin-left: 1em;">#local.totalQueries#</span></div>
3333
<div style="padding: 1em;">
3434
<input type="button" style="font-size:10px" value="Grouped View" onClick="fw_showGroupedQueries()">
3535
<input type="button" style="font-size:10px" value="Timeline View" onClick="fw_showTimelineQueries()">
3636
</div>
37-
<cfif totalQueries EQ 0>
37+
<cfif local.totalQueries EQ 0>
3838
No queries executed
3939
<cfelse>
4040
<div id="groupedQueries">
@@ -109,17 +109,17 @@ Description :
109109
Total Execution Time:
110110
</div>
111111
<div class="fw_debugContentCell">
112-
#totalExecutionTime# ms
112+
#local.totalExecutionTime# ms
113113
</div>
114114
</div>
115115
</cfif>
116116
</cfif>
117117
</div>
118-
<cfif isQuickInstalled>
118+
<cfif local.isQuickInstalled>
119119
<hr />
120120
<div id="quickEntities" style="margin-top: 1em;">
121-
<div class="fw_subtitles">&nbsp;Entities <span class="fw_badge_dark" style="margin-left: 1em;">#totalEntities#</span></div>
122-
<cfif totalEntities EQ 0>
121+
<div class="fw_subtitles">&nbsp;Entities <span class="fw_badge_dark" style="margin-left: 1em;">#local.totalEntities#</span></div>
122+
<cfif local.totalEntities EQ 0>
123123
No Quick entities loaded.
124124
<cfelse>
125125
<table border="0" align="center" cellpadding="0" cellspacing="1" class="fw_debugTables" style="margin-top: 1em;">

0 commit comments

Comments
 (0)