Fix for cases where a non-empty value wasn't passing an empty: false validation check

Author: elpete

box.json

@@ -58,5 +58,7 @@
         "logs:2018":"server log [email protected] --follow",
         "logs:2021":"server log [email protected] --follow"
     },
-    "installPaths":{}
+    "installPaths":{
+        "cbi18n":"modules/cbi18n/"
+    }
 }

models/validators/EmptyValidator.cfc

@@ -46,10 +46,17 @@ component extends="BaseValidator" accessors="true" singleton {
 		}
 
 		var isFilled = hasValue( arguments.targetValue );
-		if ( arguments.validationData && !isFilled ) {
+
+		if (
+			// if it should be empty and it is empty
+			( arguments.validationData && !isFilled ) ||
+			// or it shouldn't be empty and is not empty
+			( !arguments.validationData && isFilled )
+		) {
 			return true;
 		}
 
+
 		// No data, fail it
 		var args = {
 			message        : "The '#arguments.field#' value should #arguments.validationData ? "" : "not "#be empty",

test-harness/tests/specs/validators/EmptyValidatorTest.cfc

@@ -82,6 +82,10 @@ component extends="coldbox.system.testing.BaseModelTest" model="cbvalidation.mod
 				it( "fails when given an empty struct", function(){
 					expect( model.validate( variables.result, this, "test", {}, false ) ).toBeFalse();
 				} );
+
+				it( "does not fail when given a non-empty string", () => {
+					expect( model.validate( variables.result, this, "test", 10, false ) ).toBeTrue();
+				} );
 			} );
 		} );
 	}