* All date comparison validators now validate as false when the comparison target dates values are NOT dates instead of throwing an exception.

Author: lmajano

changelog.md

@@ -14,6 +14,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * New ColdBox 7 delegate: `Validatable@cbValidation` which can be used to make objects validatable
 * New validators: `notSameAs, notSameAsNoCase`
 
+### Changed
+
+* All date comparison validators now validate as `false` when the comparison target dates values are NOT dates instead of throwing an exception.
+
 ----
 
 ## [4.0.0] => 2022-OCT-10

models/validators/AfterOrEqualValidator.cfc

@@ -38,12 +38,22 @@ component extends="BaseValidator" accessors="true" singleton {
 		if ( isNull( arguments.targetValue ) || isNullOrEmpty( arguments.targetValue ) ) {
 			return true;
 		}
-		// If not a date, throw it
+
+		// If not a date, invalide it
 		if ( !isDate( arguments.targetValue ) ) {
-			throw(
-				message = "The date you sent is an invalid date [#arguments.targetValue#]",
-				type    = "InvalidValidationData"
+			validationResult.addError(
+				validationResult.newError(
+					argumentCollection = {
+						message        : "The '#arguments.targetValue#' is not a valid date, so we cannot compare them.",
+						field          : arguments.field,
+						validationType : getName(),
+						rejectedValue  : ( arguments.targetValue ),
+						validationData : arguments.validationData,
+						errorMetadata  : { "afterOrEqual" : arguments.targetValue }
+					}
+				)
 			);
+			return false;
 		}
 
 		// The compare value is set or it can be another field

models/validators/AfterValidator.cfc

@@ -38,12 +38,22 @@ component extends="BaseValidator" accessors="true" singleton {
 		if ( isNull( arguments.targetValue ) || isNullOrEmpty( arguments.targetValue ) ) {
 			return true;
 		}
-		// If target is not a date, throw it
+
+		// If target is not a date, invalidate it
 		if ( !isDate( arguments.targetValue ) ) {
-			throw(
-				message = "The date you sent is an invalid date [#arguments.targetValue#]",
-				type    = "InvalidValidationData"
+			validationResult.addError(
+				validationResult.newError(
+					argumentCollection = {
+						message        : "The '#arguments.targetValue#' is not a valid date, so we cannot compare them.",
+						field          : arguments.field,
+						validationType : getName(),
+						rejectedValue  : ( arguments.targetValue ),
+						validationData : arguments.validationData,
+						errorMetadata  : { "afterOrEqual" : arguments.targetValue }
+					}
+				)
 			);
+			return false;
 		}
 
 		// The compare value is set or it can be another field

models/validators/BeforeOrEqualValidator.cfc

@@ -40,10 +40,19 @@ component extends="BaseValidator" accessors="true" singleton {
 		}
 		// If not a date, throw it
 		if ( !isDate( arguments.targetValue ) ) {
-			throw(
-				message = "The date you sent is an invalid date [#arguments.targetValue#]",
-				type    = "InvalidValidationData"
+			validationResult.addError(
+				validationResult.newError(
+					argumentCollection = {
+						message        : "The '#arguments.targetValue#' is not a valid date, so we cannot compare them.",
+						field          : arguments.field,
+						validationType : getName(),
+						rejectedValue  : ( arguments.targetValue ),
+						validationData : arguments.validationData,
+						errorMetadata  : { "afterOrEqual" : arguments.targetValue }
+					}
+				)
 			);
+			return false;
 		}
 
 		// The compare value is set or it can be another field

models/validators/BeforeValidator.cfc

@@ -40,10 +40,19 @@ component extends="BaseValidator" accessors="true" singleton {
 		}
 		// If not a date, throw it
 		if ( !isDate( arguments.targetValue ) ) {
-			throw(
-				message = "The date you sent is an invalid date [#arguments.targetValue#]",
-				type    = "InvalidValidationData"
+			validationResult.addError(
+				validationResult.newError(
+					argumentCollection = {
+						message        : "The '#arguments.targetValue#' is not a valid date, so we cannot compare them.",
+						field          : arguments.field,
+						validationType : getName(),
+						rejectedValue  : ( arguments.targetValue ),
+						validationData : arguments.validationData,
+						errorMetadata  : { "afterOrEqual" : arguments.targetValue }
+					}
+				)
 			);
+			return false;
 		}
 
 		// The compare value is set or it can be another field

models/validators/DateEqualsValidator.cfc

@@ -38,12 +38,22 @@ component extends="BaseValidator" accessors="true" singleton {
 		if ( isNull( arguments.targetValue ) || isNullOrEmpty( arguments.targetValue ) ) {
 			return true;
 		}
+
 		// If not a date, throw it
 		if ( !isDate( arguments.targetValue ) ) {
-			throw(
-				message = "The date you sent is an invalid date [#arguments.targetValue#]",
-				type    = "InvalidValidationData"
+			validationResult.addError(
+				validationResult.newError(
+					argumentCollection = {
+						message        : "The '#arguments.targetValue#' is not a valid date, so we cannot compare them.",
+						field          : arguments.field,
+						validationType : getName(),
+						rejectedValue  : ( arguments.targetValue ),
+						validationData : arguments.validationData,
+						errorMetadata  : { "afterOrEqual" : arguments.targetValue }
+					}
+				)
 			);
+			return false;
 		}
 
 		// The compare value is set or it can be another field