Skip to content

Commit 43a323e

Browse files
committed
feat: Apply the configured schema as the defaultSchema on the SchemaBuilder instance
1 parent b3fa741 commit 43a323e

File tree

2 files changed

+13
-9
lines changed

2 files changed

+13
-9
lines changed

box.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
}
3333
],
3434
"dependencies":{
35-
"qb":"^9.0.0",
35+
"qb":"^9.4.0",
3636
"mockdatacfc":"^3.4.0+35"
3737
},
3838
"installPaths":{

models/QBMigrationManager.cfc

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ component accessors="true" {
2929
return;
3030
}
3131

32-
var schema = wirebox.getInstance( "SchemaBuilder@qb" ).setGrammar( wirebox.getInstance( defaultGrammar ) );
32+
var schema = newSchemaBuilder();
3333

3434
schema.create(
3535
getMigrationsTable(),
@@ -56,7 +56,7 @@ component accessors="true" {
5656
* Resets the database to an empty state
5757
*/
5858
public void function reset() {
59-
var schema = wirebox.getInstance( "SchemaBuilder@qb" ).setGrammar( wirebox.getInstance( defaultGrammar ) );
59+
var schema = newSchemaBuilder();
6060
schema.dropAllObjects( options = { datasource: getDatasource() }, schema = getSchema() );
6161
}
6262

@@ -138,10 +138,7 @@ component accessors="true" {
138138

139139
var migration = wirebox.getInstance( migrationStruct.componentPath );
140140

141-
var schema = wirebox
142-
.getInstance( "SchemaBuilder@qb" )
143-
.setGrammar( wirebox.getInstance( defaultGrammar ) )
144-
.setDefaultOptions( { datasource: getDatasource() } )
141+
var schema = newSchemaBuilder();
145142

146143
var query = wirebox
147144
.getInstance( "QueryBuilder@qb" )
@@ -169,8 +166,7 @@ component accessors="true" {
169166
* Determines whether the migration table is installed
170167
*/
171168
public boolean function isMigrationTableInstalled() {
172-
var schema = wirebox.getInstance( "SchemaBuilder@qb" ).setGrammar( wirebox.getInstance( defaultGrammar ) );
173-
169+
var schema = newSchemaBuilder();
174170
return schema.hasTable( getMigrationsTable(), getSchema(), { datasource: getDatasource() } );
175171
}
176172

@@ -223,4 +219,12 @@ component accessors="true" {
223219
return; // intentionally does nothing
224220
}
225221

222+
private SchemaBuilder function newSchemaBuilder() {
223+
return variables.wirebox
224+
.getInstance( "SchemaBuilder@qb" )
225+
.setGrammar( variables.wirebox.getInstance( getDefaultGrammar() ) )
226+
.setDefaultSchema( getSchema() )
227+
.setDefaultOptions( { datasource: getDatasource() } );
228+
}
229+
226230
}

0 commit comments

Comments
 (0)