Skip to content

Commit 49a68ba

Browse files
committed
chore(CI): Don't fail fast on cron jobs
We want to see which engines are failing and which are passing.
1 parent f5d505c commit 49a68ba

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

.github/workflows/cron.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ jobs:
99
runs-on: ubuntu-latest
1010
name: Tests
1111
strategy:
12-
fail-fast: true
1312
matrix:
1413
cfengine: ["lucee@5", "lucee@be", "adobe@2018", "adobe@be"]
1514
coldbox: ["coldbox@5", "coldbox@6", "coldbox@be"]

models/MigrationService.cfc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ component accessors="true" {
3333
} )
3434
.each( function( key ) {
3535
if ( isSimpleValue( args[ key ] ) ) {
36-
invoke( this, "set" & key, { key: args[ key ] } );
36+
variables[ key ] = args[ key ];
3737
} else if ( key == "properties" ) {
3838
variables.managerProperties = args[ key ];
3939
}

tests/resources/app/config/Coldbox.cfc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
"properties": {
5858
"defaultGrammar": "MySQLGrammar@qb",
5959
"datasource": "db1",
60-
"useTransactions": "false",
60+
"useTransactions": "false"
6161
}
6262
}
6363
}

0 commit comments

Comments
 (0)