fix: Use %20 instead of + for encoded spaces

Author: elpete

box.json

@@ -18,7 +18,7 @@
         "CFzxing":"^1.1.0"
     },
     "devDependencies":{
-        "testbox":"stable"
+        "testbox":"^4.0.0"
     },
     "installPaths":{
         "testbox":"testbox/",

models/TOTP.cfc

@@ -77,13 +77,13 @@ component singleton accessors="true" {
         return arrayToList(
             [
                 "otpauth://totp/",
-                encodeForURL( arguments.issuer ),
+                urlEncodedFormat( arguments.issuer ),
                 ":",
                 arguments.email,
                 "?secret=",
                 arguments.secret,
                 "&issuer=",
-                encodeForURL( arguments.issuer )
+                urlEncodedFormat( arguments.issuer )
             ],
             ""
         );

tests/specs/unit/TOTPSpec.cfc

@@ -157,7 +157,7 @@ component extends="testbox.system.BaseSpec" {
                         secret = secret
                     );
                     expect( totpUrl ).toBe(
-                        "otpauth://totp/#encodeForURL( issuer )#:#email#?secret=#secret#&issuer=#encodeForURL( issuer )#"
+                        "otpauth://totp/Example%20Company:john@example.com?secret=#secret#&issuer=Example%20Company"
                     );
                 } );
             } );
@@ -223,7 +223,7 @@ component extends="testbox.system.BaseSpec" {
                 expect( config.secret ).toMatchWithCase( "^[A-Z2-7]+=*$", "Secret must be a valid Base32 string." );
                 expect( config ).toHaveKey( "url" );
                 expect( config.url ).toBe(
-                    "otpauth://totp/#encodeForURL( issuer )#:#email#?secret=#config.secret#&issuer=#encodeForURL( issuer )#"
+                    "otpauth://totp/Example%20Company:john@example.com?secret=#config.secret#&issuer=Example%20Company"
                 );
                 expect( config ).toHaveKey( "qrCode" );
                 expect( isImage( config.qrCode ) ).toBeTrue( "An image should have been returned" );