Add caching to getFeatures

Author: elpete

models/UnleashSDK.cfc

@@ -1,6 +1,16 @@
 component singleton accessors="true" {
 
     property name="client" inject="UnleashHyperClient@unleashsdk";
+    property name="cache" inject="cachebox:default";
+    property name="log" inject="logbox:logger:{this}";
+
+    variables.strategies = {
+        "default": "DefaultStrategy",
+        "userWithId": "UserWithIdStrategy",
+        "flexibleRollout": "FlexibleRolloutStrategy",
+        "remoteAddress": "RemoteAddressStrategy",
+        "applicationHostname": "ApplicationHostnameStrategy"
+    };
 
     public boolean function isEnabled( required string name, boolean defaultValue = false ) {
         var feature = findFeature( arguments.name );
@@ -12,9 +22,39 @@ component singleton accessors="true" {
             return false;
         }
 
+        for ( var strategyData in feature.strategies ) {
+            var strategy = getStrategy( strategyData.name );
+            if ( isNull( strategy ) ) {
+                return false;
+            }
+
+            param strategyData.constraints = [];
+            if ( !strategy.satisfiesConstraints( strategyData.constraints ) ) {
+                continue;    
+            }
+            
+            param strategyData.parameters = {};
+            if ( !strategy.isEnabled( strategyData.parameters ) ) {
+                return false;
+            }
+        }
+
         return true;
     }
 
+    private any function getStrategy( required string name ) {
+        if ( !variables.strategies.keyExists( arguments.name ) ) {
+            log.warn( "No Unleash strategy found for [#arguments.name#]" );
+            return javacast( "null", "" );
+        }
+
+        if ( isSimpleValue( variables.strategies[ arguments.name ] ) ) {
+            variables.strategies[ arguments.name ] = new "unleashsdk.models.strategies.#variables.strategies[ arguments.name ]#"();
+        }
+
+        return variables.strategies[ arguments.name ];
+    }
+
     public struct function createFeature(
         required string name,
         required string description,
@@ -54,6 +94,12 @@ component singleton accessors="true" {
         } );
     }
 
+    public array function getFeatures() {
+        return cache.getOrSet( "unleashsdk-features", function() {
+            return fetchFeatures();
+        }, createTimespan( 0, 0, 10, 0 ) );
+    }
+
     private array function fetchFeatures() {
         return variables.client.get( "/client/features" ).json().features;
     }

models/strategies/DefaultStrategy.cfc

@@ -0,0 +1,11 @@
+component implements="IStrategy" {
+
+    public boolean function satisfiesConstraints( array constraints ) {
+        return true; // spike
+    }
+
+    public boolean function isEnabled( struct parameters ) {
+        return true;
+    }
+
+}

models/strategies/IStrategy.cfc

@@ -0,0 +1,7 @@
+interface {
+
+    public boolean function satisfiesConstraints( array constraints );
+
+    public boolean function isEnabled( struct parameters );
+
+}

tests/resources/ModuleIntegrationSpec.cfc

@@ -5,6 +5,8 @@ component extends="coldbox.system.testing.BaseTestCase" appMapping="/app" {
 
         getController().getModuleService()
             .registerAndActivateModule( "app", "testingModuleRoot" );
+
+        getWireBox().autowire( this );
     }
 
     /**

tests/specs/integration/UnleashSpec.cfc

@@ -1,5 +1,7 @@
 component extends="tests.resources.ModuleIntegrationSpec" {
 
+    property name="cache" inject="cachebox:default"
+
     function beforeAll() {
         super.beforeAll();
         variables.unleash = getInstance( "UnleashSDK@unleashsdk" );
@@ -10,6 +12,7 @@ component extends="tests.resources.ModuleIntegrationSpec" {
             it( "returns the default value for an unknown feature", function() {
                 expect( unleash.isEnabled( "bar" ) ).toBeFalse();
             } );
+
             it( "can check if a feature is enabled", function() {
                 unleash.ensureFeatureExists(
                     name = "feature-1",
@@ -40,6 +43,33 @@ component extends="tests.resources.ModuleIntegrationSpec" {
                 expect( unleash.isEnabled( "feature-1" ) ).toBeTrue();
                 expect( unleash.isEnabled( "feature-2" ) ).toBeFalse();
             } );
+
+            it( "can return all features", function() {
+                unleash.ensureFeatureExists(
+                    name = "feature-1",
+                    description = "A test feature flag that is enabled",
+                    type = "release",
+                    enabled = true,
+                    strategies = [
+                        {
+                            "name": "default",
+                            "parameters": {}
+                        }
+                    ]
+                );
+                expect( unleash.getFeatures() ).toBeArray();
+                expect( unleash.getFeatures() ).notToBeEmpty();
+            } );
+
+            it( "caches the features", function() {
+                cache.clear( "unleashsdk-features" );
+                var hyper = prepareMock( getInstance( "UnleashHyperClient@unleashsdk" ) );
+                var newRequest = hyper.new();
+                hyper.$( "new", newRequest );
+                unleash.getFeatures();
+                unleash.getFeatures();
+                expect( hyper.$count( "new" ) ).toBe( 1, "The UnleashHyperClient should only be used once." );
+            } );
         } );
     }