Use ColdBox scheduler for feature flag updates

Author: elpete

ModuleConfig.cfc

@@ -11,11 +11,10 @@ component {
             "contextProvider": "DefaultContextProvider@unleashsdk",
             "apiURL": getSystemSetting( "UNLEASH_API_URL" ),
             "apiToken": getSystemSetting( "UNLEASH_API_TOKEN" ),
-            "cacheTimeout": createTimeSpan( 0, 0, 0, 10 )
+            "cacheTimeout": createTimeSpan( 0, 0, 0, 10 ),
+            "refreshInterval": 10
         };
-	}
 
-	function onLoad() {
         binder.map( "UnleashHyperClient@unleashsdk" )
             .to( "hyper.models.HyperBuilder" )
             .asSingleton()
@@ -35,4 +34,8 @@ component {
             .toDSL( "UnleashSDK@unleashsdk" );
 	}
 
+	function onLoad() {
+        
+	}
+
 }

config/Scheduler.cfc

@@ -0,0 +1,27 @@
+component {
+
+    property name="refreshInterval" inject="coldbox:setting:refreshInterval@unleashsdk";
+    property name="log" inject="logbox:logger:{this}";
+
+    function configure() {
+        task( "unleashsdk-refresh-features" )
+            .call( getInstance( "UnleashSDK@unleashsdk" ), "refreshFeatures" )
+            .every( variables.refreshInterval, "seconds" )
+            .before( function() {
+                if ( log.canDebug() ) {
+                    log.debug( "Starting to fetch new features from unleash" );
+                } 
+            } )
+            .onSuccess( function( task, results ) {
+                if ( log.canInfo() ) {
+                    log.info( "Successfully refreshed features", results );
+                }
+            } )
+            .onFailure( function( task, exception ) {
+                if ( log.canError() ) {
+                    log.error( "Exception when running task [unleashsdk-refresh-features]:", exception );
+                }
+            } );
+    }
+
+}

docker-compose.yml

@@ -9,12 +9,12 @@ services:
         expose:
             - "61442"
         environment:
-            APP_DIR: /unleashsdk
+            APP_DIR: /app/unleashsdk
             PORT: 61442
             BOX_SERVER_PROFILE: development
             UNLEASH_API_URL: http://unleash:4242/api
         volumes:
-            - .:/unleashsdk
+            - .:/app/unleashsdk
 
     unleash:
         image: unleashorg/unleash-server:4.0.10

models/UnleashSDK.cfc

@@ -15,10 +15,10 @@ component singleton accessors="true" {
 	};
 
 	public boolean function isEnabled(
-        required string name,
-        struct additionalContext = {},
-        boolean defaultValue = false
-    ) {
+		required string name,
+		struct additionalContext = {},
+		boolean defaultValue     = false
+	) {
 		var feature = getFeature( arguments.name );
 		if ( isNull( feature ) ) {
 			return arguments.defaultValue;
@@ -28,11 +28,11 @@ component singleton accessors="true" {
 			return false;
 		}
 
-        var context = getContext( arguments.additionalContext );
+		var context = getContext( arguments.additionalContext );
 
-        if ( feature.strategies.isEmpty() ) {
-            return true;
-        }
+		if ( feature.strategies.isEmpty() ) {
+			return true;
+		}
 
 		for ( var strategyData in feature.strategies ) {
 			var strategy = getStrategy( strategyData.name );
@@ -55,10 +55,10 @@ component singleton accessors="true" {
 	}
 
 	public boolean function isDisabled(
-        required string name,
-        struct additionalContext = {},
-        boolean defaultValue = false
-    ) {
+		required string name,
+		struct additionalContext = {},
+		boolean defaultValue     = false
+	) {
 		return !isEnabled( argumentCollection = arguments );
 	}
 
@@ -118,26 +118,17 @@ component singleton accessors="true" {
 	}
 
 	public array function getFeatures() {
-		try {
-			return cache.getOrSet(
-				"unleashsdk-features",
-				function() {
-					var features = fetchFeatures();
-					cache.set( "unleashsdk-failover", features, 0 );
-					return features;
-				},
-				variables.settings.cacheTimeout
-			);
-		} catch ( any e ) {
-			if ( log.canError() ) {
-				log.error( "Exception occurred while retrieving Unleash features.  Using failover", e );
-			}
-			var features = cache.get( "unleashsdk-failover" );
-			if ( isNull( features ) ) {
-				return [];
-			}
-			return features;
+		var features = cache.get( "unleashsdk-failover" );
+		if ( isNull( features ) ) {
+			return [];
 		}
+		return features;
+	}
+
+	public array function refreshFeatures() {
+		var features = fetchFeatures();
+		cache.set( "unleashsdk-failover", features, 0 );
+		return features;
 	}
 
 	private array function fetchFeatures() {
@@ -161,7 +152,11 @@ component singleton accessors="true" {
 
 	private struct function getContext( struct additionalContext = {} ) {
 		param request.unleashContext = generateContext();
-        structAppend( arguments.additionalContext, request.unleashContext, false );
+		structAppend(
+			arguments.additionalContext,
+			request.unleashContext,
+			false
+		);
 		return arguments.additionalContext;
 	}
 

server.json

@@ -6,7 +6,7 @@
         }
     },
     "app":{
-        "cfengine":"adobe@2018"
+        "cfengine":"lucee@5"
     },
     "directoryBrowsing":"true"
 }

tests/Application.cfc

@@ -11,7 +11,7 @@ component {
     rootPath = REReplaceNoCase( this.mappings[ "/tests" ], "tests(\\|/)", "" );
     this.mappings[ "/root" ] = rootPath;
     this.mappings[ "/unleashsdk" ] = rootPath;
-    this.mappings[ "/testingModuleRoot" ] = "/";
+    this.mappings[ "/testingModuleRoot" ] = "/app";
     this.mappings[ "/app" ] = testsPath & "resources/app";
     this.mappings[ "/coldbox" ] = testsPath & "resources/app/coldbox";
     this.mappings[ "/testbox" ] = rootPath & "/testbox";
@@ -25,6 +25,7 @@ component {
 	};
 
     function onRequestStart() {
+        systemOutput( "Starting request" );
         setting requestTimeout="180";
         structDelete( application, "cbController" );
         structDelete( application, "wirebox" );
@@ -48,7 +49,11 @@ component {
                 "password": "unleash4all"
             })#" );
         }
-        var authCookie = listFirst( local.res.Responseheader[ "Set-Cookie" ], ";" );
+        var authCookie = local.res.Responseheader[ "Set-Cookie" ];
+        if ( isArray( authCookie ) ) {
+            authCookie = authCookie[ 1 ];
+        }
+        authCookie = listFirst( authCookie, ";" );
         cookie[ "unleash-session" ] = listRest( urlDecode( authCookie ), "=" );
     }