test: [UIE-10347] - Fix Cypress test failures following 1.159.0 release (linode#13438)

* Fix Cypress test failures following 1.159.0 release

* Added changeset: Fix Cypress test failures following v1.159.0 release

---------

Co-authored-by: Alban Bailly <130582365+abailly-akamai@users.noreply.github.com>

Author: jdamore-linode

packages/manager/.changeset/pr-13438-tests-1772047855280.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Tests
+---
+
+Fix Cypress test failures following v1.159.0 release ([#13438](https://github.com/linode/manager/pull/13438))

packages/manager/cypress/e2e/core/cloudpulse/alerting-notification-channel-permission-tests.spec.ts

@@ -37,10 +37,8 @@ describe('Notification Channel Listing Page — Access Control', () => {
     mockAppendFeatureFlags(flags);
     cy.visitWithLogin('/linodes');
 
-    ui.nav.findItemByTitle('Alerts').as('alertsNav');
-    cy.get('@alertsNav').scrollIntoView();
-    cy.get('@alertsNav').should('be.visible').click();
-
+    ui.nav.findItemByTitle('Alerts').scrollIntoView();
+    ui.nav.findItemByTitle('Alerts').should('be.visible').click();
     ui.tabList
       .findTabByTitle('Notification Channels')
       .should('be.visible')
@@ -65,9 +63,8 @@ describe('Notification Channel Listing Page — Access Control', () => {
     mockAppendFeatureFlags(flags);
     cy.visitWithLogin('/linodes');
 
-    ui.nav.findItemByTitle('Alerts').as('alertsNav');
-    cy.get('@alertsNav').scrollIntoView();
-    cy.get('@alertsNav').should('be.visible').click();
+    ui.nav.findItemByTitle('Alerts').scrollIntoView();
+    ui.nav.findItemByTitle('Alerts').should('be.visible').click();
 
     // Tab should not render at all
     ui.tabList.findTabByTitle('Notification Channels').should('not.exist');

packages/manager/cypress/e2e/core/linodes/smoke-linode-landing-table.spec.ts

@@ -93,21 +93,29 @@ describe('linode landing checks', () => {
 
   it('checks the landing page side menu items', () => {
     cy.findByTitle('Akamai - Cloud Manager').should('be.visible');
-    cy.findByTestId('menu-item-Linodes').should('be.visible');
-    cy.findByTestId('menu-item-Volumes').should('be.visible');
-    cy.findByTestId('menu-item-NodeBalancers').should('be.visible');
-    cy.findByTestId('menu-item-Firewalls').should('be.visible');
-    cy.findByTestId('menu-item-StackScripts').should('be.visible');
-    cy.findByTestId('menu-item-Images').should('be.visible');
-    cy.findByTestId('menu-item-Domains').should('be.visible');
-    cy.findByTestId('menu-item-Kubernetes').should('be.visible');
-    cy.findByTestId('menu-item-Object Storage').should('be.visible');
-    cy.findByTestId('menu-item-Longview').should('be.visible');
-    cy.findByTestId('menu-item-Marketplace').should('be.visible');
-    cy.findByTestId('menu-item-Billing').scrollIntoView();
-    cy.findByTestId('menu-item-Billing').should('be.visible');
-    cy.findByTestId('menu-item-Account Settings').should('be.visible');
-    cy.findByTestId('menu-item-Help & Support').should('be.visible');
+
+    const expectedNavItems = [
+      'Linodes',
+      'Volumes',
+      'NodeBalancers',
+      'Firewalls',
+      'StackScripts',
+      'Images',
+      'Domains',
+      'Kubernetes',
+      'Object Storage',
+      'Longview',
+      'Quick Deploy Apps',
+      'Partner Referrals',
+      'Billing',
+      'Account Settings',
+      'Help & Support',
+    ];
+
+    expectedNavItems.forEach((navItem) => {
+      ui.nav.findItemByTitle(navItem).scrollIntoView();
+      ui.nav.findItemByTitle(navItem).should('be.visible');
+    });
   });
 
   it('checks the landing top menu items', () => {
@@ -271,7 +279,7 @@ describe('linode landing checks', () => {
         cy.get(commonLocators.topMenuCreateItemsLocator.marketplaceOneClickLink)
           .should('be.visible')
           .within(() => {
-            cy.findByText('Marketplace').should('be.visible');
+            cy.findByText('Quick Deploy Apps').should('be.visible');
             cy.findByText('Deploy applications with ease').should('be.visible');
           });
       });

packages/manager/cypress/e2e/core/objectStorage/enable-object-storage.spec.ts

@@ -25,11 +25,7 @@ import { mockGetRegions } from 'support/intercepts/regions';
 import { ui } from 'support/ui';
 import { randomLabel } from 'support/util/random';
 
-import type {
-  AccountSettings,
-  PriceType,
-  Region,
-} from '@linode/api-v4';
+import type { AccountSettings, PriceType, Region } from '@linode/api-v4';
 
 // Various messages, notes, and warnings that may be shown when enabling Object Storage
 // under different circumstances.
@@ -187,11 +183,7 @@ describe('Object Storage enrollment', () => {
     mockGetAccessKeys([]);
 
     cy.visitWithLogin('/object-storage/buckets');
-    cy.wait([
-      '@getAccountSettings',
-      '@getBuckets',
-      '@getRegions',
-    ]);
+    cy.wait(['@getAccountSettings', '@getBuckets', '@getRegions']);
 
     // Confirm that empty-state message is shown before proceeding.
     cy.findByText('S3-compatible storage solution').should('be.visible');