Skip to content

Commit 8df1fd9

Browse files
KBandipoIfycode
authored andcommitted
Refactor: Move dropdown default text to a variable
1 parent 16971e1 commit 8df1fd9

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

src/components/@hooks_state/useSubmitIssue.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { submitIssue } from '../../@core/submitIssue';
44
import { GitHubIssueTemplateContainer } from './useTemplate';
55

66
function useSubmitIssueState (){
7-
const { issueBody, setIssueBody, issueTitle, setIssueTitle, setButtonTitle} = GitHubIssueTemplateContainer.useContainer();
7+
const { issueBody, setIssueBody, issueTitle, setIssueTitle, setButtonTitle, dropdownButtonText} = GitHubIssueTemplateContainer.useContainer();
88
const [toastrMessage, setToastrMessage] = useState<{message: string; issueURL?: string;
99
issueNumber?: number;} | null>(null);
1010

@@ -28,7 +28,7 @@ function useSubmitIssueState (){
2828
issueURL: response.issue.url,
2929
issueNumber: response.issue.number,
3030
});
31-
setButtonTitle('-- Select issue template --');
31+
setButtonTitle(dropdownButtonText);
3232
};
3333

3434
return {

src/components/@hooks_state/useTemplate.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,12 @@ import { createContainer } from 'unstated-next';
33
import { IssueTemplate } from '../../@core/types/issueTemplate';
44
import { getApiIssueTemplates } from '../../@core/templates';
55

6+
const dropdownButtonText = '-- Select issue template --';
67
function useTemplateState() {
78
const [issueBody, setIssueBody] = useState<string>('');
89
const [issueTitle, setIssueTitle] = useState<string>('');
910
const [templates, setTemplates] = useState<IssueTemplate[]>([]);
10-
const [buttonTitle, setButtonTitle] = useState<string>('-- Select issue template --');
11+
const [buttonTitle, setButtonTitle] = useState<string>(dropdownButtonText);
1112

1213
useEffect(() => {
1314
getApiIssueTemplates().then(setTemplates);
@@ -27,7 +28,8 @@ const fetchTemplateContent = (content: string, title:string) => {
2728
buttonTitle,
2829
setButtonTitle,
2930
templates,
30-
fetchTemplateContent
31+
fetchTemplateContent,
32+
dropdownButtonText
3133
};
3234
}
3335
export const GitHubIssueTemplateContainer = createContainer(useTemplateState);

0 commit comments

Comments
 (0)