Bump zip from 5.1.1 to 7.0.0 #467
ci.yml
on: push
cargo check
1m 9s
cargo fmt
24s
cargo test
2m 18s
cargo clippy
1m 11s
minimal direct dependencies
58s
cargo clippy latest
1m 9s
allgreen
5s
Annotations
9 warnings
|
this `if` statement can be collapsed:
src/prune.rs#L48
warning: this `if` statement can be collapsed
--> src/prune.rs:48:5
|
48 | / if let Some(expected_rev) = expected_rev {
49 | | if dir.rev.as_deref() != Some(expected_rev) {
50 | | outputln!(
51 | | "Latest revision is {}, skipping prune",
... |
56 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#collapsible_if
help: collapse nested if block
|
48 ~ if let Some(expected_rev) = expected_rev
49 ~ && dir.rev.as_deref() != Some(expected_rev) {
50 | outputln!(
...
54 | return Ok(());
55 ~ }
|
|
|
this `if` statement can be collapsed:
src/prune.rs#L48
warning: this `if` statement can be collapsed
--> src/prune.rs:48:5
|
48 | / if let Some(expected_rev) = expected_rev {
49 | | if dir.rev.as_deref() != Some(expected_rev) {
50 | | outputln!(
51 | | "Latest revision is {}, skipping prune",
... |
56 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#collapsible_if
help: collapse nested if block
|
48 ~ if let Some(expected_rev) = expected_rev
49 ~ && dir.rev.as_deref() != Some(expected_rev) {
50 | outputln!(
...
54 | return Ok(());
55 ~ }
|
|
|
this `if` statement can be collapsed:
src/handler.rs#L414
warning: this `if` statement can be collapsed
--> src/handler.rs:414:5
|
414 | / if let Some(mut artifact) = dep.download().await? {
415 | | if let Some(file) = tokio::task::spawn_blocking(move || {
416 | | artifact
417 | | .file(path.as_str())
... |
432 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#collapsible_if
help: collapse nested if block
|
414 ~ if let Some(mut artifact) = dep.download().await?
415 ~ && let Some(file) = tokio::task::spawn_blocking(move || {
416 | artifact
...
430 | ));
431 ~ }
|
|
|
this `if` statement can be collapsed:
src/handler.rs#L414
warning: this `if` statement can be collapsed
--> src/handler.rs:414:5
|
414 | / if let Some(mut artifact) = dep.download().await? {
415 | | if let Some(file) = tokio::task::spawn_blocking(move || {
416 | | artifact
417 | | .file(path.as_str())
... |
432 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#collapsible_if
help: collapse nested if block
|
414 ~ if let Some(mut artifact) = dep.download().await?
415 ~ && let Some(file) = tokio::task::spawn_blocking(move || {
416 | artifact
...
430 | ));
431 ~ }
|
|
|
called `filter(..).next_back()` on an `DoubleEndedIterator`. This is more succinctly expressed by calling `.rfind(..)` instead:
src/build_meta.rs#L244
warning: called `filter(..).next_back()` on an `DoubleEndedIterator`. This is more succinctly expressed by calling `.rfind(..)` instead
--> src/build_meta.rs:244:43
|
244 | let prev_endtime_for_commit = jobhist
| ___________________________________________^
245 | | .jobhist
246 | | .iter()
247 | | .filter(|e| e.srcmd5 == srcmd5)
248 | | .next_back()
| |____________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#filter_next
= note: `#[warn(clippy::filter_next)]` on by default
help: try
|
244 ~ let prev_endtime_for_commit = jobhist
245 + .jobhist
246 + .iter().rfind(|e| e.srcmd5 == srcmd5)
|
|
|
called `filter(..).next_back()` on an `DoubleEndedIterator`. This is more succinctly expressed by calling `.rfind(..)` instead:
src/build_meta.rs#L244
warning: called `filter(..).next_back()` on an `DoubleEndedIterator`. This is more succinctly expressed by calling `.rfind(..)` instead
--> src/build_meta.rs:244:43
|
244 | let prev_endtime_for_commit = jobhist
| ___________________________________________^
245 | | .jobhist
246 | | .iter()
247 | | .filter(|e| e.srcmd5 == srcmd5)
248 | | .next_back()
| |____________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#filter_next
= note: `#[warn(clippy::filter_next)]` on by default
help: try
|
244 ~ let prev_endtime_for_commit = jobhist
245 + .jobhist
246 + .iter().rfind(|e| e.srcmd5 == srcmd5)
|
|
|
this `if` statement can be collapsed:
src/build_meta.rs#L124
warning: this `if` statement can be collapsed
--> src/build_meta.rs:124:21
|
124 | / if let Some(obs::Error::ApiError(obs::ApiError { code, .. })) =
125 | | cause.downcast_ref::<obs::Error>()
126 | | {
127 | | if code == "unknown_package" {
... |
130 | | }
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#collapsible_if
= note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
|
125 ~ cause.downcast_ref::<obs::Error>()
126 ~ && code == "unknown_package" {
127 | return Ok(None);
128 ~ }
|
|
|
this `if` statement can be collapsed:
src/build_meta.rs#L124
warning: this `if` statement can be collapsed
--> src/build_meta.rs:124:21
|
124 | / if let Some(obs::Error::ApiError(obs::ApiError { code, .. })) =
125 | | cause.downcast_ref::<obs::Error>()
126 | | {
127 | | if code == "unknown_package" {
... |
130 | | }
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#collapsible_if
= note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
|
125 ~ cause.downcast_ref::<obs::Error>()
126 ~ && code == "unknown_package" {
127 | return Ok(None);
128 ~ }
|
|
|
JSON arguments recommended for ENTRYPOINT/CMD to prevent unintended behavior related to OS signals:
Dockerfile#L26
JSONArgsRecommended: JSON arguments recommended for ENTRYPOINT to prevent unintended behavior related to OS signals
More info: https://docs.docker.com/go/dockerfile/rule/json-args-recommended/
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
collabora~obs-gitlab-runner~ZJZHRF.dockerbuild
|
33.9 KB |
sha256:87071b86fd3b78930e9a906cda5c0e1f4683a01d752c8a9bab4a245da16c9689
|
|