Skip to content

Commit da500c7

Browse files
committed
Support for Plone 6.0.10 til 6.0.15
6.1.x not available
1 parent b598532 commit da500c7

File tree

11 files changed

+388
-18
lines changed

11 files changed

+388
-18
lines changed

.github/workflows/tests.yml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ jobs:
77
matrix:
88
config:
99
- ["plone52-py27", "plone/test-with-tox:5.2-2.7"]
10-
runs-on: ubuntu-20.04
10+
- ["plone52-py38", "plone/test-with-tox:5.2-3.8"]
11+
runs-on: ubuntu-22.04
1112
container:
1213
image: ${{ matrix.config[1] }}
1314
name: ${{ matrix.config[0] }}
@@ -21,15 +22,16 @@ jobs:
2122
matrix:
2223
config:
2324
# [Python version, tox env]
24-
- ["3.6", "plone52-py36"]
25-
- ["3.7", "plone52-py37"]
26-
- ["3.8", "plone52-py38"]
27-
- ["3.8", "plone60-py38"]
25+
# - ["3.6", "plone52-py36"]
26+
# - ["3.7", "plone52-py37"]
27+
# - ["3.8", "plone60-py38"]
2828
- ["3.9", "plone60-py39"]
2929
- ["3.10", "plone60-py310"]
3030
- ["3.11", "plone60-py311"]
31+
- ["3.12", "plone60-py312"]
32+
- ["3.13", "plone60-py313"]
3133
name: ${{ matrix.config[1] }}
32-
runs-on: ubuntu-20.04
34+
runs-on: ubuntu-22.04
3335
steps:
3436
- uses: actions/checkout@v3
3537
- name: Set up Python

buildout-constraints.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
setuptools<80.8.0

docs/HISTORY.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@ Changelog
44
5.0.0b5 (unreleased)
55
--------------------
66

7-
- Nothing changed yet.
7+
- Support for CMFPlone >= 6.0.10 < 6.1 where CSS viewlet implementation has changed.
8+
[gotcha]
89

910

1011
5.0.0b4 (2023-12-21)

requirements-tox.txt

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
# For Buildout related packages, it is easiest to keep them at the same version for all environments.
2-
# Keep these in sync with base.cfg please:
3-
zc.buildout==3.0.1
4-
# setuptools 67 is too strict with versions
5-
setuptools<67
1+
horse-with-no-namespace
2+
zc.buildout
3+
-c buildout-constraints.txt

setup.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@
3535
"Programming Language :: Python :: 3.9",
3636
"Programming Language :: Python :: 3.10",
3737
"Programming Language :: Python :: 3.11",
38+
"Programming Language :: Python :: 3.12",
39+
"Programming Language :: Python :: 3.13",
3840
],
3941
keywords='Plone CKeditor WYSIWYG',
4042
author='Plone Collective (started by Alterway Solutions)',
@@ -46,6 +48,7 @@
4648
zip_safe=False,
4749
install_requires=[
4850
'setuptools',
51+
'Products.CMFPlone<6.1',
4952
'zope.i18nmessageid',
5053
'collective.quickupload',
5154
'collective.plonefinder',

sources.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@ zope_push = git@github.com:zopefoundation
1313

1414
[sources]
1515
collective.plonefinder = git ${remotes:collective}/collective.plonefinder.git pushurl=${remotes:collective_push}/collective.plonefinder.git branch=plone5
16-
collective.quickupload = git ${remotes:collective}/collective.quickupload.git pushurl=${remotes:collective_push}/collective.quickupload.git branch=plone5
16+
collective.quickupload = git ${remotes:collective}/collective.quickupload.git pushurl=${remotes:collective_push}/collective.quickupload.git branch=master

src/collective/ckeditor/browser/ckeditorview.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,8 @@
6767

6868

6969
if HAS_PLONE6_RESOURCES:
70+
from .cmf_plone_resource import ResourceView
71+
7072
def get_css_urls(view):
7173
class CKRenderer(webresource.ResourceRenderer):
7274
# returns list of CSS URLS instead of link tags in HTML
@@ -77,10 +79,8 @@ def render(self):
7779

7880
class CKEditorCSSViewlet(ResourceView):
7981
def index(self):
80-
root_group_css = webresource.ResourceGroup(name="root_css")
81-
resolver_css = webresource.ResourceResolver(root_group_css)
8282
renderer = CKRenderer(
83-
resolver_css, base_url=self.portal_state.portal_url()
83+
self.resolver_css, base_url=self.portal_state.portal_url()
8484
)
8585
rendered = renderer.render()
8686
return rendered
@@ -91,7 +91,9 @@ def index(self):
9191
view
9292
)
9393
viewlet.update()
94-
return viewlet.index()
94+
result = viewlet.index()
95+
return result
96+
9597

9698
if HAS_PLONE5_RESOURCES:
9799
def get_css_urls(view):

0 commit comments

Comments
 (0)