Skip to content

Commit f2a5429

Browse files
committed
formatting
1 parent 491f5f0 commit f2a5429

File tree

9 files changed

+62
-66
lines changed

9 files changed

+62
-66
lines changed

mrbob/cli.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,16 @@
11
"""Command line interface to mr.bob"""
22

3+
import argparse
34
import importlib.metadata
4-
import sys
55
import os
66
import shutil
7+
import sys
78

89
import six
9-
import argparse
1010

11-
from .configurator import Configurator
12-
from .configurator import maybe_bool
13-
from .bobexceptions import ConfigurationError
14-
from .bobexceptions import TemplateConfigurationError
15-
from .parsing import parse_config, update_config, pretty_format_config
11+
from .bobexceptions import ConfigurationError, TemplateConfigurationError
12+
from .configurator import Configurator, maybe_bool
13+
from .parsing import parse_config, pretty_format_config, update_config
1614

1715
# http://docs.python.org/library/argparse.html
1816
parser = argparse.ArgumentParser(description="Filesystem template renderer")

mrbob/configurator.py

Lines changed: 23 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -2,35 +2,37 @@
22

33
import os
44
import re
5-
import sys
65
import readline
7-
8-
try: # pragma: no cover
9-
from urllib import urlretrieve # NOQA
10-
except ImportError: # pragma: no cover
11-
# PY3K
12-
from urllib.request import urlretrieve # NOQA
13-
import tempfile
14-
from zipfile import ZipFile, is_zipfile
15-
16-
readline # NOQA: make pyflakes happy, readline makes interactive mode keep history
6+
import sys
7+
from importlib import import_module
178

189
import six
19-
from importlib import import_module
2010

21-
from .rendering import render_structure
22-
from .parsing import (
23-
parse_config,
24-
write_config,
25-
update_config,
26-
pretty_format_config,
27-
)
2811
from .bobexceptions import (
2912
ConfigurationError,
30-
TemplateConfigurationError,
3113
SkipQuestion,
14+
TemplateConfigurationError,
3215
ValidationError,
3316
)
17+
from .parsing import (
18+
parse_config,
19+
pretty_format_config,
20+
update_config,
21+
write_config,
22+
)
23+
from .rendering import render_structure
24+
25+
try: # pragma: no cover
26+
from urllib import urlretrieve # noqa
27+
except ImportError: # pragma: no cover
28+
# PY3K
29+
from urllib.request import urlretrieve # noqa
30+
import tempfile
31+
from zipfile import ZipFile, is_zipfile
32+
33+
# make pyflakes happy, readline makes interactive mode keep history
34+
readline # noqa
35+
3436

3537
DOTTED_REGEX = re.compile(r"^[a-zA-Z_.]+:[a-zA-Z_.]+$")
3638

@@ -286,7 +288,7 @@ def __init__(
286288
pre_ask_question="",
287289
post_ask_question="",
288290
help="",
289-
**extra
291+
**extra,
290292
):
291293
self.name = name
292294
self.question = question

mrbob/parsing.py

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,20 @@
1+
import collections
12
import os
23
import tempfile
3-
import collections
44

55
try: # pragma: no cover
6-
from collections import OrderedDict # NOQA
6+
from collections import OrderedDict # noqa
77
except ImportError: # pragma: no cover
8-
from ordereddict import OrderedDict # NOQA
9-
import six
8+
from ordereddict import OrderedDict # noqa
109
import configparser
1110

11+
import six
12+
1213
try: # pragma: no cover
13-
from urllib import urlretrieve # NOQA
14+
from urllib import urlretrieve # noqa
1415
except ImportError: # pragma: no cover
1516
# PY3K
16-
from urllib.request import urlretrieve # NOQA
17+
from urllib.request import urlretrieve # noqa
1718

1819
from .bobexceptions import ConfigurationError
1920

@@ -109,7 +110,7 @@ def update_config(first_config, second_config):
109110

110111

111112
def pretty_format_config(config):
112-
l = []
113+
item_list = []
113114

114115
def format_config(dict_, namespace=""):
115116
for key, value in dict_.items():
@@ -120,8 +121,8 @@ def format_config(dict_, namespace=""):
120121
if isinstance(value, dict):
121122
format_config(value, namespace=namespace_new)
122123
else:
123-
l.append("%s = %s" % (namespace_new, value))
124+
item_list.append("%s = %s" % (namespace_new, value))
124125

125126
format_config(config)
126127

127-
return sorted(l)
128+
return sorted(item_list)

mrbob/rendering.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
from os import path
2-
from shutil import copy2
31
import codecs
42
import fnmatch
53
import os
64
import re
7-
import six
85
import stat
6+
from os import path
7+
from shutil import copy2
98

9+
import six
1010
from jinja2 import Environment, StrictUndefined
1111

1212
jinja2_env = Environment(

mrbob/tests/test_cli.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
import unittest
2-
import tempfile
1+
import importlib.metadata
32
import os
43
import shutil
4+
import tempfile
5+
import unittest
56
from unittest import mock
6-
import importlib.metadata
77

88

99
class TestCLI(unittest.TestCase):

mrbob/tests/test_configurator.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
# -*- coding: utf-8 -*-
22

3-
import unittest
43
import os
4+
import shutil
55
import sys
66
import tempfile
7-
import shutil
8-
import six
7+
import unittest
98
from unittest import mock
109

10+
import six
11+
1112
mocked_pre_ask_question = mock.Mock()
1213
mocked_post_ask_question = mock.Mock()
1314
mocked_post_ask_question_validationerror = mock.Mock()

mrbob/tests/test_hooks.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
from unittest import TestCase
2-
from unittest import mock
31
import time
2+
from unittest import TestCase, mock
43

54
from ..configurator import Question
65
from .test_configurator import DummyConfigurator

mrbob/tests/test_parsing.py

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,18 @@
11
# -*- coding: utf-8 -*-
2+
import codecs
23
import os
3-
import unittest
44
import tempfile
5-
import codecs
6-
from collections import OrderedDict # NOQA
5+
import unittest
6+
from collections import OrderedDict # noqa
7+
from unittest import mock
78

89
import six
910

10-
from unittest import mock
11-
1211

1312
class parse_configTest(unittest.TestCase):
14-
1513
def call_FUT(self, configname="example.ini"):
1614
import mrbob
15+
1716
from ..parsing import parse_config
1817

1918
if not configname.startswith("http"):
@@ -104,7 +103,7 @@ def test_parse_remote_config(self, urlretrieve):
104103

105104
def write(url, filename):
106105
f = open(filename, "w")
107-
f.write("[variables]\n" "foo = bar\n")
106+
f.write("[variables]\nfoo = bar\n")
108107
f.close()
109108

110109
urlretrieve.side_effect = write
@@ -114,7 +113,6 @@ def write(url, filename):
114113

115114

116115
class update_configTest(unittest.TestCase):
117-
118116
def call_FUT(self, config, newconfig):
119117
from ..parsing import update_config
120118

@@ -160,7 +158,6 @@ def test_update_config_override_nested(self):
160158

161159

162160
class write_configTest(unittest.TestCase):
163-
164161
def setUp(self):
165162
self.tmpfile = tempfile.mkstemp()[1]
166163

@@ -218,7 +215,6 @@ def test_non_str(self):
218215

219216

220217
class pretty_format_configTest(unittest.TestCase):
221-
222218
def call_FUT(self, config):
223219
from ..parsing import pretty_format_config
224220

@@ -240,7 +236,6 @@ def test_complex(self):
240236

241237

242238
class nest_variablesTest(unittest.TestCase):
243-
244239
def call_FUT(self, d):
245240
from ..parsing import nest_variables
246241

mrbob/tests/test_rendering.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
# -*- coding: utf-8 -*-
22

3-
from shutil import rmtree
4-
from tempfile import mkdtemp
53
import codecs
64
import os
75
import stat
86
import unittest
9-
7+
from shutil import rmtree
8+
from tempfile import mkdtemp
109
from unittest import mock
10+
1111
import six
1212

1313

@@ -33,8 +33,7 @@ def call_FUT(
3333
ignored_files=[],
3434
ignored_directories=[],
3535
):
36-
from ..rendering import render_structure
37-
from ..rendering import jinja2_renderer
36+
from ..rendering import jinja2_renderer, render_structure
3837

3938
if output_dir is None:
4039
output_dir = self.fs_tempdir
@@ -218,8 +217,7 @@ def tearDown(self):
218217
def call_FUT(
219218
self, template, variables, output_dir=None, verbose=False, renderer=None
220219
):
221-
from ..rendering import render_template
222-
from ..rendering import python_formatting_renderer
220+
from ..rendering import python_formatting_renderer, render_template
223221

224222
if output_dir is None:
225223
output_dir = self.fs_tempdir
@@ -311,6 +309,7 @@ def test_render_namespace_missing_key(self):
311309

312310
def test_render_namespace_missing_key_jinja2(self):
313311
from jinja2 import UndefinedError
312+
314313
from ..rendering import jinja2_renderer
315314

316315
t = os.path.join(self.fs_templates, "missing_namespace_key/foo_jinja2.bob")
@@ -321,6 +320,7 @@ def test_render_namespace_missing_key_jinja2(self):
321320

322321
def test_jinja2_strict_undefined(self):
323322
from jinja2 import UndefinedError
323+
324324
from ..rendering import jinja2_renderer
325325

326326
t = os.path.join(self.fs_templates, "strict_undefined.bob")

0 commit comments

Comments
 (0)