browse labels duplication

[peterjanssens]

When using multiple locales the browse summary of for instance collections is duplicated on it's labels. (find > objects > browse)

2.x

1.7.x

it comes down to the new version building the values array on $va_facet[$label_values['label_sort_']][...] in the getFacetContent function, where the old version folds them on the keys $va_facet[$va_fetched_row[$vs_rel_pk]][...]. By having the labels as first key there is this duplication (unless similar labels collapsed).

providence/app/lib/Browse/BrowseEngine.php

Line 7343 in a71937c

$va_facet[$label_values['label_sort_']][$va_fetched_row[$vs_rel_pk]][$va_fetched_row['locale_id']] = $va_facet_item;

The helper function caExtractValuesByLocale extracting the labels no longer works because most labels are unique (hence that item returned early), only the collapsed items sort of work (doesn't matter that much which is returned because they are all the same).

I guess this change from key to label was intentional - there is a lot going on in that 4200 line facet gathering function - too much for me to judge if this can be reverted to the old (preferred?) behavior ? The actual sorting happens later.

Could you have a look at this please?

[collectiveaccess]

The change was made to deal with a separate issue. Multiple locales were clearly not taken into account. We'll get to fixing it when time allows.