Merge pull request #53 from DanOlson/master

Provide better failure messages for include_json matcher. Addresses issu...

Author: laserlemon

lib/json_spec/matchers/include_json.rb

@@ -12,6 +12,8 @@ def initialize(expected_json = nil)
       def matches?(actual_json)
         raise "Expected included JSON not provided" if @expected_json.nil?
 
+        @actual_json = actual_json
+
         actual = parse_json(actual_json, @path)
         expected = exclude_keys(parse_json(@expected_json))
         case actual
@@ -43,12 +45,12 @@ def including(*keys)
       end
 
       def failure_message
-        message_with_path("Expected included JSON")
+        message_with_path("Expected #{@actual_json} to include #{@expected_json}")
       end
       alias :failure_message_for_should :failure_message
 
       def failure_message_when_negated
-        message_with_path("Expected excluded JSON")
+        message_with_path("Expected #{@actual_json} to not include #{@expected_json}")
       end
       alias :failure_message_for_should_not :failure_message_when_negated
 

spec/json_spec/matchers/include_json_spec.rb

@@ -71,6 +71,18 @@
     matcher.description.should == %(include JSON at path "json/0")
   end
 
+  it "provides a useful failure message for should" do
+    matcher = include_json(%([4,5,6]))
+    matcher.matches?(%([1,2,3]))
+    matcher.failure_message_for_should.should == "Expected [1,2,3] to include [4,5,6]"
+  end
+
+  it "provides a useful failure message for should not" do
+    matcher = include_json(%(3))
+    matcher.matches?(%([1,2,3]))
+    matcher.failure_message_for_should_not.should == "Expected [1,2,3] to not include 3"
+  end
+
   it "raises an error when not given expected JSON" do
     expect{ %([{"id":1,"two":3}]).should include_json }.to raise_error
   end