make nonenumerable. fix replacing at .assign() calls.

Author: endel

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@colyseus/schema",
-  "version": "4.0.11",
+  "version": "4.0.12",
   "description": "Binary state serializer with delta encoding for games",
   "type": "module",
   "bin": {

src/decoder/ReferenceTracker.ts

@@ -40,7 +40,12 @@ export class ReferenceTracker {
     // for decoding
     addRef(refId: number, ref: IRef, incrementCount: boolean = true) {
         this.refs.set(refId, ref);
-        ref[$refId] = refId;
+
+        Object.defineProperty(ref, $refId, {
+            value: refId,
+            enumerable: false,
+            writable: true
+        });
 
         if (incrementCount) {
             this.refCount[refId] = (this.refCount[refId] || 0) + 1;

src/encoder/Root.ts

@@ -28,7 +28,11 @@ export class Root {
 
         // Assign unique `refId` to ref if it doesn't have one yet.
         if (ref[$refId] === undefined) {
-            ref[$refId] = this.getNextUniqueId();
+            Object.defineProperty(ref, $refId, {
+                value: this.getNextUniqueId(),
+                enumerable: false,
+                writable: true
+            });
         }
 
         const refId = ref[$refId];

test/Schema.test.ts

@@ -8,7 +8,7 @@
 
 import * as assert from "assert";
 import { State, Player, DeepState, DeepMap, DeepChild, Position, DeepEntity, assertDeepStrictEqualEncodeAll, createInstanceFromReflection, getEncoder } from "./Schema";
-import { Schema, ArraySchema, MapSchema, type, Metadata, $changes, Encoder, Decoder, SetSchema, schema, ToJSON } from "../src";
+import { Schema, ArraySchema, MapSchema, type, Metadata, $changes, Encoder, Decoder, SetSchema, schema, ToJSON, $refId } from "../src";
 import { getNormalizedType } from "../src/Metadata";
 
 describe("Type: Schema", () => {
@@ -649,6 +649,19 @@ describe("Type: Schema", () => {
     });
 
     describe("encoding/decoding", () => {
+        it(".assign() should not re-assign the $refId", () => {
+            const state = new State();
+            state.player = new Player();
+            state.mapOfPlayers = new MapSchema<Player>();
+
+            getEncoder(state);
+
+            const newPlayer = new Player().assign(state.player);
+            state.mapOfPlayers.set("one", newPlayer);
+
+            assert.ok(newPlayer[$refId] !== state.player[$refId]);
+        });
+
         it("should encode/decode STRING", () => {
             const state = new State();
             state.fieldString = "Hello world";