Skip to content

Commit 7321658

Browse files
authored
Update to Mill 1.0.0 (#195)
1 parent e815520 commit 7321658

File tree

5 files changed

+320
-58
lines changed

5 files changed

+320
-58
lines changed

.github/workflows/publish-artifacts.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
distribution: 'temurin'
2727
java-version: 11
2828
- name: Publish to Maven Central
29-
run: ./mill -i mill.scalalib.PublishModule/
29+
run: ./mill -i mill.scalalib.SonatypeCentralPublishModule/
3030

3131
- name: Create GitHub Release
3232
id: create_gh_release

.github/workflows/run-tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
strategy:
1414
fail-fast: false
1515
matrix:
16-
java: ['8', '17']
16+
java: ['11', '17']
1717
steps:
1818
- uses: actions/checkout@v4
1919
with:
@@ -33,6 +33,6 @@ jobs:
3333
- uses: actions/setup-java@v4
3434
with:
3535
distribution: 'temurin'
36-
java-version: 8
36+
java-version: 11
3737
- name: Check Binary Compatibility
3838
run: ./mill -i -k __.mimaReportBinaryIssues

.mill-version

Lines changed: 0 additions & 1 deletion
This file was deleted.

build.mill

Lines changed: 23 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
1+
//| mill-version: 1.0.0
2+
//| mvnDeps:
3+
//| - com.github.lolgab::mill-mima_mill1:0.2.0
4+
15
package build
26
import mill._, scalalib._, scalajslib._, scalanativelib._, publish._
3-
import mill.scalalib.api.ZincWorkerUtil.isScala3
4-
import $ivy.`de.tototec::de.tobiasroeser.mill.vcs.version::0.4.0`
5-
import $ivy.`com.github.lolgab::mill-mima::0.1.1`
6-
import de.tobiasroeser.mill.vcs.version.VcsVersion
7+
import mill.util.VcsVersion
78

89
import com.github.lolgab.mill.mima._
910

@@ -32,10 +33,10 @@ trait MainArgsPublishModule
3233
override def mimaPreviousVersions = Seq("0.6.0")
3334

3435
def mimaReportBinaryIssues() =
35-
if (this.isInstanceOf[ScalaNativeModule] || this.isInstanceOf[ScalaJSModule]) T.command()
36+
if (this.isInstanceOf[ScalaNativeModule] || this.isInstanceOf[ScalaJSModule]) Task.Command{}
3637
else super.mimaReportBinaryIssues()
3738

38-
override def versionScheme: T[Option[VersionScheme]] = T(Some(VersionScheme.EarlySemVer))
39+
override def versionScheme: T[Option[VersionScheme]] = Task{ Some(VersionScheme.EarlySemVer) }
3940

4041
def publishProperties = super.publishProperties() ++ Map(
4142
"info.releaseNotesURL" -> changelogUrl
@@ -54,35 +55,35 @@ trait MainArgsPublishModule
5455

5556
def scalacOptions =
5657
super.scalacOptions() ++
57-
Option.when(!isScala3(scalaVersion()))("-P:acyclic:force")
58+
Option.when(!scalaVersion().startsWith("3."))("-P:acyclic:force")
5859

59-
def scalacPluginIvyDeps =
60-
super.scalacPluginIvyDeps() ++
61-
Option.when(!isScala3(scalaVersion()))(ivy"com.lihaoyi:::acyclic:${acyclic}")
60+
def scalacPluginMvnDeps =
61+
super.scalacPluginMvnDeps() ++
62+
Option.when(!scalaVersion().startsWith("3."))(mvn"com.lihaoyi:::acyclic:${acyclic}")
6263

63-
def compileIvyDeps =
64-
super.compileIvyDeps() ++
65-
Agg.when(!isScala3(crossScalaVersion))(
66-
ivy"com.lihaoyi:::acyclic:${acyclic}",
67-
ivy"org.scala-lang:scala-reflect:$crossScalaVersion"
68-
)
64+
def compileMvnDeps =
65+
super.compileMvnDeps() ++
66+
Seq(
67+
mvn"com.lihaoyi:::acyclic:${acyclic}",
68+
mvn"org.scala-lang:scala-reflect:$crossScalaVersion"
69+
).filter(_ => !scalaVersion().startsWith("3."))
6970

70-
def ivyDeps = Agg(
71-
ivy"org.scala-lang.modules::scala-collection-compat::2.12.0"
71+
def mvnDeps = Seq(
72+
mvn"org.scala-lang.modules::scala-collection-compat::2.12.0"
7273
)
7374
}
7475

75-
def scalaMajor(scalaVersion: String) = if (isScala3(scalaVersion)) "3" else "2"
76+
def scalaMajor(scalaVersion: String) = if (scalaVersion.startsWith("3.")) "3" else "2"
7677

7778
trait CommonTestModule extends ScalaModule with TestModule.Utest {
78-
def ivyDeps = Agg(ivy"com.lihaoyi::utest::0.8.3")
79+
def mvnDeps = Seq(mvn"com.lihaoyi::utest::0.8.3")
7980
}
8081

8182
object mainargs extends Module {
8283
object jvm extends Cross[JvmMainArgsModule](scalaVersions)
8384
trait JvmMainArgsModule extends MainArgsPublishModule {
8485
object test extends ScalaTests with CommonTestModule {
85-
def ivyDeps = super.ivyDeps() ++ Agg(ivy"com.lihaoyi::os-lib:${osLib}")
86+
def mvnDeps = super.mvnDeps() ++ Seq(mvn"com.lihaoyi::os-lib:${osLib}")
8687
}
8788
}
8889

@@ -112,7 +113,7 @@ object example extends Module {
112113
object optseq extends ExampleModule
113114

114115
object custom extends ExampleModule {
115-
def ivyDeps = Agg(ivy"com.lihaoyi::os-lib:${osLib}")
116+
def mvnDeps = Seq(mvn"com.lihaoyi::os-lib:${osLib}")
116117
}
117118
object vararg extends ExampleModule
118119
object vararg2 extends ExampleModule

0 commit comments

Comments
 (0)