Merge branch 'main' into groovylib

lefou · lefou · commit 0d2918a54340 · 2025-09-26T10:41:03.000+02:00
diff --git a/.github/actions/post-build-selective/action.yml b/.github/actions/post-build-selective/action.yml
@@ -8,10 +8,6 @@ inputs:
     required: true
     type: string
 
-  coursierarchive:
-    default: ''
-    type: string
-
 runs:
   using: "composite"
   steps:
@@ -48,8 +44,6 @@ runs:
     #  shell: ${{ inputs.shell }}
 
     - run: ./mill -i -k selective.run ${{ inputs.millargs }}
-      env:
-        COURSIER_ARCHIVE_CACHE: ${{ inputs.coursierarchive }}
       shell: ${{ inputs.shell }}
 
     - name: Clean-up Test Reports
diff --git a/.github/workflows/post-build-selective.yml b/.github/workflows/post-build-selective.yml
@@ -10,10 +10,6 @@ on:
         required: true
         type: string
 
-      coursierarchive:
-        default: "/tmp"
-        required: false
-        type: string
       java-version:
         required: true
         type: string
@@ -67,5 +63,4 @@ jobs:
 
         with:
           millargs: ${{ inputs.millargs }}
-          coursierarchive: ${{ inputs.coursierarchive }}
           shell: ${{ inputs.shell }}
diff --git a/.github/workflows/publish-artifacts.yml b/.github/workflows/publish-artifacts.yml
@@ -27,27 +27,22 @@ jobs:
       matrix:
         include:
         - os: ubuntu-latest
-          coursierarchive: "/tmp"
           publishartifacts: __.publishArtifacts
           uploadgithub: true
 
         - os: ubuntu-24.04-arm
-          coursierarchive: "/tmp"
           publishartifacts: dist.native.publishArtifacts
           uploadgithub: false
 
         - os: macos-13
-          coursierarchive: "/tmp"
           publishartifacts: dist.native.publishArtifacts
           uploadgithub: false
 
         - os: macos-latest
-          coursierarchive: "/tmp"
           publishartifacts: dist.native.publishArtifacts
           uploadgithub: false
 
         - os: windows-latest
-          coursierarchive: C:/coursier-arc
           publishartifacts: dist.native.publishArtifacts
           uploadgithub: false
 
@@ -62,7 +57,6 @@ jobs:
       LANG: "en_US.UTF-8"
       LC_MESSAGES: "en_US.UTF-8"
       LC_ALL: "en_US.UTF-8"
-      COURSIER_ARCHIVE_CACHE: ${{ matrix.coursierarchive }}
       REPO_ACCESS_TOKEN: ${{ secrets.REPO_ACCESS_TOKEN }}
     steps:
       - uses: actions/setup-java@v5
diff --git a/.github/workflows/publish-bridges.yaml b/.github/workflows/publish-bridges.yaml
@@ -26,7 +26,6 @@ jobs:
       LANG: "en_US.UTF-8"
       LC_MESSAGES: "en_US.UTF-8"
       LC_ALL: "en_US.UTF-8"
-      COURSIER_ARCHIVE_CACHE: ${{ matrix.coursierarchive }}
       REPO_ACCESS_TOKEN: ${{ secrets.REPO_ACCESS_TOKEN }}
       MILL_COMPILER_BRIDGE_VERSIONS: ${{ inputs.bridge_versions }}
     steps:
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
@@ -118,7 +118,6 @@ jobs:
       - uses: ./.github/actions/post-build-selective
         with:
           millargs: ${{ matrix.millargs }}
-          coursierarchive: "/tmp"
           shell: bash
 
   linux:
@@ -224,9 +223,6 @@ jobs:
       os: windows-latest
       java-version: ${{ matrix.java-version }}
       millargs: ${{ matrix.millargs }}
-      # Provide a shorter coursier archive folder to avoid hitting path-length bugs when
-      # running the graal native image binary on windows
-      coursierarchive: "C:/coursier-arc"
       shell: powershell
 
   itest:
diff --git a/CONTRIBUTING.adoc b/CONTRIBUTING.adoc
@@ -8,10 +8,10 @@ We have essential contributor information in the xref:readme.adoc[Project README
 
 Here are some direct links:
 
-* xref:readme.adoc#intellij-setup[IntelliJ Setup] - IntelliJ IDEA works great for Mill development; other IDEs may work as well
-* xref:readme.adoc#project-layout[Project Layout] - The source code repository structure from a high level view
-* xref:readme.adoc#manual-automated-testing[Manual and Automated Testing] - How we test Mill
-* xref:readme.adoc#project-maintenance[Project Maintenance] - Details about authoring pull request and commit messages
+* xref:developer.adoc#intellij-setup[IntelliJ Setup] - IntelliJ IDEA works great for Mill development; other IDEs may work as well
+* xref:developer.adoc#project-layout[Project Layout] - The source code repository structure from a high level view
+* xref:developer.adoc#manual-automated-testing[Manual and Automated Testing] - How we test Mill
+* xref:developer.adoc#project-maintenance[Project Maintenance] - Details about authoring pull request and commit messages
 * https://mill-build.org/mill/Intro_to_Mill.html[Mill Documentation] - Documentation for users and developers
 * {link-github}/discussions[Discussion Forum on GitHub] - A place to ask question and discuss all kind of questions around Mill
 * {link-github}/issues[Issue Tracker on GitHub] - Our issue tracker for bugs and features
diff --git a/changelog.adoc b/changelog.adoc
@@ -576,6 +576,21 @@ def namedTupleTask = Task {
 ----
 
 
+
+[#0-12-16]
+=== 0.12.16 - 2025-09-23
+:version: 0.12.16
+:milestone-name: 0.12.16
+:milestone: 128
+:prev-version: 0.12.15
+
+_Changes since {prev-version}:_
+
+* Added support for Scala 3.8 ({link-pr}/5797[#5797])
+
+* Added support for Java 25 and updated asm-tree to 9.8  ({link-pr}/5891[#5891])
+
+
 [#0-12-15]
 === 0.12.15
 :version: 0.12.15
diff --git a/core/api/src/mill/api/BuildCtx.scala b/core/api/src/mill/api/BuildCtx.scala
@@ -14,7 +14,7 @@ object BuildCtx {
    * This is the `os.Path` pointing to the project root directory.
    *
    * This is the preferred access to the project directory, and should
-   * always be prefered over `os.pwd`* (which might also point to the
+   * always be preferred over `os.pwd`* (which might also point to the
    * project directory in classic cli scenarios, but might not in other
    * use cases like BSP or LSP server usage).
    */
diff --git a/libs/daemon/server/src/mill/server/Server.scala b/libs/daemon/server/src/mill/server/Server.scala
@@ -136,8 +136,7 @@ abstract class Server(args: Server.Args) {
           exit = msg => {
             serverLog(s"watchProcessIdFile: $msg")
             serverSocket.close()
-          },
-          log = serverLog
+          }
         )
 
         // Wrapper object to encapsulate `activeConnections` and `inactiveTimestampOpt`,
@@ -497,12 +496,10 @@ object Server {
       processIdFile: os.Path,
       processId: Long,
       running: () => Boolean,
-      exit: String => Unit,
-      log: String => Unit
+      exit: String => Unit
   ): Unit = {
     val processIdStr = processId.toString
 
-    log(s"watching processId file (expected content = $processIdStr): $processIdFile")
     os.write.over(processIdFile, processIdStr, createFolders = true)
 
     val processIdThread = new Thread(
diff --git a/mill-build/src/millbuild/Settings.scala b/mill-build/src/millbuild/Settings.scala
@@ -18,7 +18,7 @@ object Settings {
   )
   val docTags: Seq[String] = Seq(
     "0.11.13",
-    "0.12.14",
+    "0.12.16",
     "1.0.5"
   )
   val mimaBaseVersions: Seq[String] = Seq("1.0.0", "1.0.1", "1.0.2", "1.0.3", "1.0.4", "1.0.5")
diff --git a/runner/daemon/src/mill/daemon/MillNoDaemonMain.scala b/runner/daemon/src/mill/daemon/MillNoDaemonMain.scala
@@ -33,8 +33,7 @@ object MillNoDaemonMain {
       exit = msg => {
         System.err.println(msg)
         System.exit(0)
-      },
-      log = System.err.println
+      }
     )
 
     val outLock = MillMain0.doubleLock(out)
diff --git a/website/blog/modules/ROOT/nav.adoc b/website/blog/modules/ROOT/nav.adoc
@@ -1,4 +1,5 @@
 * xref:blog::index.adoc[_The Mill Build Engineering Blog_]
+* xref:16-zero-setup.adoc[]
 * xref:15-android-build-flow.adoc[]
 * xref:14-bash-zsh-completion.adoc[]
 * xref:13-mill-build-tool-v1-0-0.adoc[]
diff --git a/website/blog/modules/ROOT/pages/12-direct-style-build-tool.adoc b/website/blog/modules/ROOT/pages/12-direct-style-build-tool.adoc
@@ -1,5 +1,4 @@
 = Mill as a Direct Style Build Tool
-
 // tag::header[]
 :author: Li Haoyi
 :revdate: 10 May 2025
diff --git a/website/blog/modules/ROOT/pages/13-mill-build-tool-v1-0-0.adoc b/website/blog/modules/ROOT/pages/13-mill-build-tool-v1-0-0.adoc
@@ -1,8 +1,6 @@
 = Mill Build Tool v1.0.0 Release Highlights
-
 :link-github: https://github.com/com-lihaoyi/mill
 :link-pr: {link-github}/pull
-
 // tag::header[]
 :author: Li Haoyi
 :revdate: 10 July 2025
diff --git a/website/blog/modules/ROOT/pages/14-bash-zsh-completion.adoc b/website/blog/modules/ROOT/pages/14-bash-zsh-completion.adoc
@@ -230,15 +230,15 @@ $ foo app<TAB>
 $ foo apple
 ----
 
-However in this scenario the descriptions are entirely ignored by Bash. Because Bash
+However, in this scenario the descriptions are entirely ignored by Bash. Because Bash
 does not have a concept of tab-complete descriptions, in Bash we only pass the `trimmed`
 word-completions to `COMPREPLY` and discard the `raw` lines containing the descriptions.
 
 == Hacking Bash Completion Descriptions
 
 To make Bash show completion "descriptions", we can take advantage of the fact
 that the completions are generated dynamically every time we call
-`_generate_foo_completions`, and Bash and Zsh only inserts text
+`+_generate_foo_completions+`, and Bash and Zsh only inserts text
 that is a common prefix to all completion options
 
 [,console]
@@ -257,7 +257,7 @@ The code below implements this: if there is only one completion we trim off the
 following the `:` off as normal, but if there's more than one completion we leave the
 description intact for the user to see
 
-[source,bash]
+[,bash]
 ----
 _complete_foo_bash() {
   local IFS=$'\n'
@@ -335,7 +335,7 @@ is a complete word, and if so adding a second "dummy" completion: this makes
 the tab-completion ambiguous, which cases Bash and Zsh to print out the completions
 and descriptions for the user to see.
 
-Doing this in `_complete_foo_bash` looks like the following:
+Doing this in `+_complete_foo_bash+` looks like the following:
 
 [,bash]
 ----
diff --git a/website/blog/modules/ROOT/pages/15-android-build-flow.adoc b/website/blog/modules/ROOT/pages/15-android-build-flow.adoc
@@ -1,5 +1,4 @@
 = Mill as an Alternative Android Build Tool
-
 // tag::header[]
 :author: Vasilis Nicolaou
 :revdate: 17 September 2025
@@ -20,7 +19,7 @@ In less than a year, Mill went from minimal Android support to producing install
 image:AndroidPokedexMultimoduleExample.png[A multi-module Android app built with Mill, showing a list of Pokémon and details for each pokemon.]
 
 
-=== Why you might prefer this to Gradle
+== Why you might prefer this to Gradle
 
 Because Mill’s Android support is built out of simple, object-oriented modules (AndroidModule, AndroidAppModule, etc.), the entire pipeline is transparent and hackable. If something doesn’t work, you don’t need to wait for a plugin update, you can open the task in your IDE, see the source, and tweak it yourself. This is the same design that let us implement end-to-end Android support in under a year, and it’s what makes Mill attractive if you value control and debuggability in your build.
 
@@ -81,7 +80,7 @@ Android adds a dozen more steps, each involving different tools and formats:
 
 Each step is order-sensitive: resources must be compiled before classes, manifests merged before packaging, APKs signed before installation. With Gradle, these steps are usually hidden inside plugin logic. When we explored Gradle builds, we often had to reverse engineer its behavior to understand what was going on. Mill instead exposes each phase as a target you can call, inspect its sources, or override.
 
-=== The Mill Android Build Pipeline
+== The Mill Android Build Pipeline
 
 .Standard Android build pipeline (without Hilt)
 [graphviz]
@@ -239,7 +238,7 @@ Run the instrumented tests and watch the app being tested inside the emulator:
 
 image:androidtodo_test.gif[Android Test running inside an emulator, showing the Todo app being tested automatically.]
 
-Let's say you want to know how the apk is built. First, you can check the plan of `androidApk`, i.e which
+Let's say you want to know how the apk is built. First, you can check the plan of `androidApk`, i.e. which
 tasks it depends on:
 [,console]
 ----
@@ -282,7 +281,7 @@ In addition, due to xref:12-direct-style-build-tool.adoc#_direct_style_builds[Mi
 
 === Example: tweak the build in your `build.mill`
 
-[source,scala]
+[,scala]
 ----
 import mill._
 import mill.androidlib._
diff --git a/website/blog/modules/ROOT/pages/16-zero-setup.adoc b/website/blog/modules/ROOT/pages/16-zero-setup.adoc
diff --git a/website/blog/modules/ROOT/pages/index.adoc b/website/blog/modules/ROOT/pages/index.adoc

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ object BuildCtx {`
`14`	`14`	* This is the `os.Path` pointing to the project root directory.
`15`	`15`	`*`
`16`	`16`	`* This is the preferred access to the project directory, and should`
`17`		- * always be prefered over `os.pwd`* (which might also point to the
	`17`	+ * always be preferred over `os.pwd`* (which might also point to the
`18`	`18`	`* project directory in classic cli scenarios, but might not in other`
`19`	`19`	`* use cases like BSP or LSP server usage).`
`20`	`20`	`*/`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ object Settings {`
`18`	`18`	`)`
`19`	`19`	`val docTags: Seq[String] = Seq(`
`20`	`20`	`"0.11.13",`
`21`		`- "0.12.14",`
	`21`	`+ "0.12.16",`
`22`	`22`	`"1.0.5"`
`23`	`23`	`)`
`24`	`24`	`val mimaBaseVersions: Seq[String] = Seq("1.0.0", "1.0.1", "1.0.2", "1.0.3", "1.0.4", "1.0.5")`