Skip to content

Commit 12c336e

Browse files
authored
Clean up mill process in LauncherOldVersionTests to prevent test report failures (#4251)
Previously the leftover running mill processes caused `action-junit-report` to fail when it tried to walk the `out\mill-worker-uyUCkqx6lYTWawU0H+fOCWvQ\u8=-1\mill-093bdc52daae5837bacc1b1b565ee261-io` file in the sandbox directory Fixes errors such as ``` Run mikepenz/action-junit-report@v5 📘 Reading input values 📦 Process test results Preparing 1 report as configured. Error: EACCES: permission denied, lstat 'D:\a\mill\mill\out\integration\feature\launcher-old-versions\fork\test.dest\mill.integration.LauncherVersionTests_0_10\sandbox\run-1\out\mill-worker-uyUCkqx6lYTWawU0H+fOCWvQ\u8=-1\mill-093bdc52daae5837bacc1b1b565ee261-io' https://github.com/com-lihaoyi/mill/actions/runs/12565326528/job/35029611094
1 parent f0aa010 commit 12c336e

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

integration/feature/launcher-old-versions/src/LauncherOldVersionsTests.scala

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@ class LauncherOldVersionsTests(version: String) extends UtestIntegrationTestSuit
2626
val res = os.call(cmd = (launcherScript, "version"), cwd = workspacePath, stderr = os.Pipe)
2727
val outText = res.out.text().trim
2828
assert(outText == version)
29+
os.call(cmd = (launcherScript, "shutdown"), cwd = workspacePath, check = false)
30+
os.remove.all(workspacePath / "out")
2931
}
3032
}
3133
}

0 commit comments

Comments
 (0)