Use named tuples in Tasks (#5146)

Use named tuples where we use tuples in Task types. The following task
were changed:

* `TestModule.test*` tasks now return `(msg: String, results:
Seq[TestResult])`

* `AndroidAppKotlinModule.androidDiscoveredPreviews` now returns
`(previewsDiscoveredJsonFile: PathRef, screenshotConfigs:
Seq[ComposeRenderer.Screenshot])`
* `AndroidAppModule.android{D,R}8Dex` now returns `(outPath: PathRef,
dexCliArgs: Seq[String])`
* `AndroidModule.androidCompiledResources` now returns named tuple and
includes all relevant resources directly.

* Also use some named tuples in `GenIdeaImpl`, which hopefully improve
reading/editing it.

Pull request: #5146

Author: lefou

ci/mill-bootstrap.patch

@@ -20,6 +20,18 @@ index 4465e163a55..6b8da38aae7 100644
 
  val dummyDeps: Seq[Dep] = Seq(
    Deps.DocDeps.millScip,
+diff --git a/integration/package.mill b/integration/package.mill
+index a5183fc0a5a..4cb6f6689cd 100644
+--- a/integration/package.mill
++++ b/integration/package.mill
+@@ -14,6 +14,7 @@ import mill.T
+ import mill.define.Cross
+ import mill.testrunner.TestResult
+ import millbuild.*
++import upickle.implicits.namedTuples.default.given
+ 
+ object `package` extends mill.Module {
+   // We compile the test code once and then offer multiple modes to
 diff --git a/runner/codesig/package.mill b/runner/codesig/package.mill
 index 3950422474a..1ed233d24f7 100644
 --- a/runner/codesig/package.mill

contrib/testng/test/src/mill/testng/TestNGTests.scala

@@ -53,18 +53,18 @@ object TestNGTests extends TestSuite {
       eval =>
         val Right(result) = eval.apply(demo.test.testForked()): @unchecked
         val tres = result.value
-        assert(tres._2.size == 8)
+        assert(tres.results.size == 8)
     }
     test("noGrouping") - UnitTester(demo, resourcePath).scoped {
       eval =>
         val Right(result) = eval.apply(demo.testng.testForked()): @unchecked
-        val tres = result.value._2
+        val tres = result.value.results
         assert(tres.map(_.fullyQualifiedName).toSet == Set("foo.HelloTests", "foo.WorldTests"))
     }
     test("testForkGrouping") - UnitTester(demo, resourcePath).scoped {
       eval =>
         val Right(result) = eval.apply(demo.testngGrouping.testForked()): @unchecked
-        val tres = result.value._2
+        val tres = result.value.results
         assert(tres.map(_.fullyQualifiedName).toSet == Set("foo.HelloTests", "foo.WorldTests"))
     }
   }

core/api/src/mill/api/internal/api.scala

@@ -58,8 +58,9 @@ trait ScalaModuleApi extends JavaModuleApi
 trait ScalaJSModuleApi extends JavaModuleApi
 trait ScalaNativeModuleApi extends JavaModuleApi
 trait TestModuleApi extends ModuleApi {
-  def testLocal(args: String*): TaskApi[(String, Seq[Any])]
-  private[mill] def bspBuildTargetScalaTestClasses: TaskApi[(String, Seq[String])]
+  def testLocal(args: String*): TaskApi[(msg: String, results: Seq[Any])]
+  private[mill] def bspBuildTargetScalaTestClasses
+      : TaskApi[(frameworkName: String, classes: Seq[String])]
 }
 trait MainModuleApi extends ModuleApi {
   private[mill] def bspClean(

example/androidlib/java/1-hello-world/build.mill

@@ -120,17 +120,17 @@ object app extends AndroidAppModule {
 
 > ./mill show app.it
 ...
-[
-  "",
-  [
+{
+  "msg": "",
+  "results": [
     {
       "fullyQualifiedName": "com.helloworld.app.ExampleInstrumentedTest.useAppContext",
       "selector": "com.helloworld.app.ExampleInstrumentedTest.useAppContext",
       "duration": ...,
       "status": "Success"
     }
   ]
-]
+}
 ...
 
 > cat out/app/it/testForked.dest/test-report.xml

example/androidlib/java/4-sum-lib-java/build.mill

@@ -142,9 +142,9 @@ Publish ... to /home/.../.m2/repository/...
 
 > ./mill show app.test
 ...
-[
-  "",
-  [
+{
+  "msg": "",
+  "results": [
     {
       "fullyQualifiedName": "com.example.app.CalculatorUnitTest.textSize_isCorrect",
       "selector": "com.example.app.CalculatorUnitTest.textSize_isCorrect",
@@ -158,6 +158,6 @@ Publish ... to /home/.../.m2/repository/...
       "status": "Success"
     }
   ]
-]
+}
 ...
 */

example/androidlib/java/5-R8/build.mill

@@ -103,17 +103,17 @@ object app extends AndroidAppModule { // <2>
 
 > ./mill show app.it
 ...
-[
-  "",
-  [
+{
+  "msg": "",
+  "results": [
     {
       "fullyQualifiedName": "com.helloworld.app.ExampleInstrumentedTest.useAppContext",
       "selector": "com.helloworld.app.ExampleInstrumentedTest.useAppContext",
       "duration": ...,
       "status": "Success"
     }
   ]
-]
+}
 
 
 > ./mill show app.stopAndroidEmulator

example/androidlib/java/6-native-libs/build.mill

@@ -77,17 +77,17 @@ object app extends AndroidNativeAppModule { // <1>
 
 > ./mill show app.it
 ...
-[
-  "",
-  [
+{
+  "msg": "",
+  "results": [
     {
       "fullyQualifiedName": "com.helloworld.app.ExampleInstrumentedTest.textViewDisplaysHelloFromCpp",
       "selector": "com.helloworld.app.ExampleInstrumentedTest.textViewDisplaysHelloFromCpp",
       "duration": ...,
       "status": "Success"
     }
   ]
-]
+}
 ...
 
 > ./mill show app.stopAndroidEmulator

example/androidlib/kotlin/1-hello-kotlin/build.mill

@@ -148,17 +148,17 @@ object app extends AndroidAppKotlinModule {
 
 > ./mill show app.it
 ...
-[
-  "",
-  [
+{
+  "msg": "",
+  "results": [
     {
       "fullyQualifiedName": "com.helloworld.app.ExampleInstrumentedTest.useAppContext",
       "selector": "com.helloworld.app.ExampleInstrumentedTest.useAppContext",
       "duration": ...,
       "status": "Success"
     }
   ]
-]
+}
 ...
 
 > cat out/app/it/testForked.dest/test-report.xml

example/androidlib/kotlin/3-compose-screenshot-tests/build.mill

@@ -70,17 +70,17 @@ object app extends AndroidAppKotlinModule {
 
 > ./mill show app.screenshotTest.testForked
 ...
-[
-  "",
-  [
+{
+  "msg": "",
+  "results": [
     {
       "fullyQualifiedName": "com.example.screenshottest.ExampleMessageCardScreenshots",
       "selector": "oMessageCardScreenshot()",
       "duration": ...,
       "status": "Success"
     }
   ]
-]
+}
 ...
 
 > cat out/app/screenshotTest/testForked.dest/test-report.xml

example/androidlib/kotlin/4-sum-lib-kotlin/build.mill

@@ -144,9 +144,9 @@ Publish ... to /home/.../.m2/repository/...
 
 > ./mill show app.test
 ...
-[
-  " ",
-  [
+{
+  "msg": " ",
+  "results": [
     {
       "fullyQualifiedName": "com.example.ExampleUnitTest.text_size_is_correct",
       "selector": "com.example.ExampleUnitTest.text_size_is_correct",
@@ -166,6 +166,6 @@ Publish ... to /home/.../.m2/repository/...
       "status": "Success"
     }
   ]
-]
+}
 ...
 */