Skip to content

Commit 54d2012

Browse files
authored
Android: Jetchat example, update databinding apis (#6063)
This PR updates the Jetchat databinding api after the latest databinding changes. <img width="1920" height="1080" alt="Screenshot From 2025-10-30 18-06-22" src="https://github.com/user-attachments/assets/5c37f740-c92c-4b87-b61f-c9036e0d11cd" /> Still android tests are not passing for it, but I'll create an issue for that
1 parent 29f2477 commit 54d2012

File tree

1 file changed

+13
-5
lines changed
  • example/thirdparty/android-compose-samples

1 file changed

+13
-5
lines changed

example/thirdparty/android-compose-samples/build.mill

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -246,8 +246,7 @@ object Jetchat extends mill.api.Module {
246246

247247
override def androidDebugSettings: T[AndroidBuildTypeSettings] = Task {
248248
AndroidBuildTypeSettings(
249-
isMinifyEnabled = false,
250-
isShrinkEnabled = false
249+
isMinifyEnabled = false
251250
)
252251
}
253252
def androidProjectProguardFiles = Task.Sources(
@@ -259,9 +258,9 @@ object Jetchat extends mill.api.Module {
259258

260259
override def androidEnableCompose: T[Boolean] = true
261260

262-
override def enableViewBinding = true
261+
override def androidEnableViewBinding = true
263262

264-
override def dataBindingCompilerVersion = "8.13.0"
263+
override def androidDataBindingCompilerVersion = "8.13.0"
265264

266265
override def kotlinUseEmbeddableCompiler: Task[Boolean] = Task {
267266
true
@@ -299,6 +298,12 @@ object Jetchat extends mill.api.Module {
299298

300299
def androidMinSdk = Versions.androidMinSdk
301300

301+
/*
302+
* FIXME Currently broken with
303+
* Message 2) profileScreen_back_conversationScreen(com.example.compose.jetchat.NavigationTest)
304+
* android.content.res.Resources$NotFoundException: String resource ID #0x7f0c002b
305+
* Message android.content.res.Resources$NotFoundException: String resource ID #0x7f0c002b
306+
*/
302307
object androidTest extends AndroidAppKotlinInstrumentedTests, AndroidR8AppModule {
303308
override def bomMvnDeps = super.mvnDeps() ++ Seq(
304309
mvn"androidx.compose:compose-bom:2025.08.00"
@@ -325,7 +330,10 @@ object Jetchat extends mill.api.Module {
325330
mvn"org.jetbrains.kotlinx:kotlinx-coroutines-test:1.10.2",
326331
mvn"androidx.compose.ui:ui-test",
327332
mvn"androidx.compose.ui:ui-test-junit4",
328-
mvn"androidx.collection:collection-ktx:1.5.0"
333+
mvn"androidx.collection:collection-ktx:1.5.0",
334+
mvn"androidx.savedstate:savedstate-ktx:1.3.0",
335+
mvn"androidx.appcompat:appcompat:1.7.0",
336+
mvn"androidx.lifecycle:lifecycle-viewmodel-compose:2.9.0"
329337
)
330338

331339
}

0 commit comments

Comments
 (0)