Skip to content

Commit 726f92a

Browse files
authored
Fixes for mill init example zip version and urls (#5147)
We were using the `lastTag` rather than the current `millVersion`, which made the `./mill` launcher use the last stable version rather than the example version, and the download URLs have an extra `mill-dist-` prefix
1 parent a7402b2 commit 726f92a

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

dist/package.mill

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ object `package` extends MillJavaModule with DistModule {
237237
os.copy(examplePath.path, Task.dest / exampleStr, createFolders = true)
238238
val ignoreErrorsOnCI = Task.dest / exampleStr / "ignoreErrorsOnCI"
239239
if (os.exists(ignoreErrorsOnCI)) os.remove(ignoreErrorsOnCI)
240-
os.write(Task.dest / exampleStr / ".mill-version", build.millLastTag())
240+
os.write(Task.dest / exampleStr / ".mill-version", build.millVersion())
241241
os.copy(bootstrapLauncher().path, Task.dest / exampleStr / "mill")
242242
os.copy(bootstrapLauncherBat().path, Task.dest / exampleStr / "mill.bat")
243243
val zip = Task.dest / s"$exampleStr.zip"

libs/init/package.mill

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ object `package` extends MillPublishScalaModule {
1919
val data: Seq[(os.SubPath, String)] =
2020
build.dist.examplePathsWithArtifactName().map { case (pathRef, str) =>
2121
val downloadUrl =
22-
s"${build.millDownloadUrl()}/mill-dist-${build.dist.artifactFileNamePrefix()}-$str.zip"
22+
s"${build.millDownloadUrl()}/${build.dist.artifactFileNamePrefix()}-$str.zip"
2323
val subPath = pathRef.path.subRelativeTo(Task.workspace / "example")
2424
(subPath, downloadUrl)
2525
}

0 commit comments

Comments
 (0)