Deprecate PublishModule.publishSelfDependency (#5117)

Fix #5116

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

Author: lefou

bsp/package.mill

@@ -10,7 +10,7 @@ object `package` extends RootModule with build.MillPublishScalaModule with Build
   def buildInfoPackageName = "mill.bsp"
 
   def buildInfoMembers = Task {
-    val workerDep = worker.publishSelfDependency()
+    val workerDep = worker.artifactMetadata()
     Seq(
       BuildInfo.Value(
         "bsp4jVersion",

main/package.mill

@@ -51,7 +51,7 @@ object `package` extends RootModule with build.MillStableScalaModule with BuildI
     BuildInfo.Value("millBinPlatform", build.millBinPlatform(), "Mill binary platform version."),
     BuildInfo.Value(
       "millDistModule", {
-        val selfDep = dist.publishSelfDependency()
+        val selfDep = dist.artifactMetadata()
         s"${selfDep.group}:${selfDep.id}"
       },
       "Coordinates of the module pulling the whole of Mill"
@@ -64,7 +64,7 @@ object `package` extends RootModule with build.MillStableScalaModule with BuildI
           distAllDeps.collect { case m: PublishModule => m }
         ) { mod =>
           Task.Anon {
-            val selfDep = mod.publishSelfDependency()
+            val selfDep = mod.artifactMetadata()
             (
               s"${mod.coursierDependency.module.repr}:${mod.coursierDependency.version}",
               s"${selfDep.group}:${selfDep.id}:${selfDep.version}"

scalalib/src/mill/javalib/revapi/RevapiModule.scala

@@ -71,7 +71,7 @@ trait RevapiModule extends PublishModule {
 
   /** API archive and supplement files (dependencies) to compare against */
   def revapiOldFiles: T[Agg[PathRef]] = Task {
-    val Artifact(group, id, version) = publishSelfDependency()
+    val Artifact(group, id, version) = artifactMetadata()
     defaultResolver().classpath(
       Seq(ivy"$group:$id:$version"),
       artifactTypes = Some(revapiArtifactTypes())

scalalib/src/mill/scalalib/PublishModule.scala

@@ -78,8 +78,9 @@ trait PublishModule extends JavaModule { outer =>
    */
   def versionScheme: T[Option[VersionScheme]] = Task { None }
 
+  @deprecated("Use artifactMetadata instead", since = "0.12.12")
   def publishSelfDependency: T[Artifact] = Task {
-    Artifact(pomSettings().organization, artifactId(), publishVersion())
+    artifactMetadata()
   }
 
   def publishIvyDeps
@@ -118,13 +119,13 @@ trait PublishModule extends JavaModule { outer =>
           .filter(!ivyPomDeps.contains(_))
 
         val modulePomDeps = Task.sequence(moduleDepsChecked.collect {
-          case m: PublishModule => m.publishSelfDependency
+          case m: PublishModule => m.artifactMetadata
         })()
         val compileModulePomDeps = Task.sequence(compileModuleDepsChecked.collect {
-          case m: PublishModule => m.publishSelfDependency
+          case m: PublishModule => m.artifactMetadata
         })()
         val runModulePomDeps = Task.sequence(runModuleDepsChecked.collect {
-          case m: PublishModule => m.publishSelfDependency
+          case m: PublishModule => m.artifactMetadata
         })()
 
         ivyPomDeps ++
@@ -149,13 +150,13 @@ trait PublishModule extends JavaModule { outer =>
       .filter(!ivyPomDeps.contains(_))
 
     val modulePomDeps = Task.sequence(moduleDepsChecked.collect {
-      case m: PublishModule => m.publishSelfDependency
+      case m: PublishModule => m.artifactMetadata
     })()
     val compileModulePomDeps = Task.sequence(compileModuleDepsChecked.collect {
-      case m: PublishModule => m.publishSelfDependency
+      case m: PublishModule => m.artifactMetadata
     })()
     val runModulePomDeps = Task.sequence(runModuleDepsChecked.collect {
-      case m: PublishModule => m.publishSelfDependency
+      case m: PublishModule => m.artifactMetadata
     })()
 
     ivyPomDeps ++