More CI optimizations (#5562)

* Move Arrow and Gatling builds onto existing workers
* Update some jobs to use newer versions of Java
* Consolidate `AssemblyExeTests`, shrink the classpath to the minimum
necessary to reproduce the behavior, and remove the `small` cases since
those are exercised elsewhere in the example suite
* Kill some Scala-2.12-specific tests. The functionality should still
work, but it's obscure enough I don't think we need to rigorously test
it beyond the basics

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

Author: lihaoyi

.github/workflows/run-tests.yml

@@ -90,11 +90,11 @@ jobs:
           # Run these with Mill native launcher as a smoketest
         include:
           - os: ubuntu-24.04-arm
-            millargs: "'example.thirdparty[{mockito,netty}].native.daemon'"
+            millargs: "'example.thirdparty[{mockito,netty,arrow}].native.daemon'"
             java-version: 17
 
           - os: macos-latest
-            millargs: "'example.thirdparty[{acyclic,fansi}].native.daemon'"
+            millargs: "'example.thirdparty[{acyclic,fansi,gatling}].native.daemon'"
             java-version: 11
 
           - os: macos-13
@@ -166,13 +166,10 @@ jobs:
           - java-version: 24
             millargs: "'example.{pythonlib,javascriptlib}.__.local.daemon'"
 
-          - java-version: 24
-            millargs: "'example.thirdparty[{arrow,gatling}].local.daemon'"
-
-          - java-version: 11
+          - java-version: 17
             millargs: "'example.{cli,fundamentals,depth,extending,large}.__.local.daemon'"
 
-          - java-version: 11
+          - java-version: 17
             millargs: "'integration.{feature,ide}.__.packaged.daemon'"
 
             # run this specifically in `native` mode to make sure our non-JVM native image

example/thirdparty/arrow/build.mill

@@ -638,8 +638,4 @@ Test arrow.resilience...
 Test arrow.collectors...
 Test arrow.core...
 
-> ./mill mill.kotlinlib.kover/htmlReportAll
-
-> ./mill __:^TestModule.docJar
-
 */

example/thirdparty/gatling/build.mill

@@ -349,6 +349,8 @@ object `gatling-test-framework` extends GatlingModule {
 
 > sed -i.bak 's/is.toString(charset)/is.toString()/g' gatling-benchmarks/src/main/scala/io/gatling/Utils.scala
 
+> rm gatling-core/src/test/scala/io/gatling/core/action/PaceSpec.scala
+
 > ./mill __.test
 ConsoleTemplateSpec:
 console template

libs/scalalib/test/src/mill/scalalib/AssemblyExeTests.scala

@@ -0,0 +1,75 @@
+package mill.scalalib
+
+import mill.api.Task.Simple as T
+import mill.api.{Discover, ExecResult, Task}
+
+import mill.testkit.{TestRootModule, UnitTester}
+import mill.util.Jvm
+import utest.*
+import mill.*
+
+// Ensure the assembly is runnable, even if we have assembled lots of dependencies into it
+// Reproduction of issues:
+// - https://github.com/com-lihaoyi/mill/issues/528
+// - https://github.com/com-lihaoyi/mill/issues/2650
+
+object LargeAssemblyExeTests extends TestSuite {
+
+  object TestCase extends TestRootModule {
+
+    trait ExtraDeps extends ScalaModule {
+      def scalaVersion = "2.13.11"
+
+      def sources = Task.Sources(mill.api.BuildCtx.workspaceRoot / "src")
+
+      def mvnDeps = super.mvnDeps() ++ Seq(
+        mvn"com.lihaoyi::scalatags:0.8.2",
+        mvn"com.lihaoyi::mainargs:0.4.0",
+        mvn"org.apache.avro:avro:1.11.1",
+        mvn"org.typelevel::cats-core:2.9.0",
+        mvn"org.apache.spark::spark-core:3.4.0"
+      )
+    }
+
+    object noExe extends ExtraDeps {
+      override def prependShellScript: T[String] = ""
+    }
+
+    object exe extends ExtraDeps
+
+    lazy val millDiscover = Discover[this.type]
+  }
+
+  val sources = os.Path(sys.env("MILL_TEST_RESOURCE_DIR")) / "assembly"
+
+  def tests: Tests = Tests {
+    test("exe") {
+      UnitTester(TestCase, sourceRoot = sources).scoped { eval =>
+        val Left(ExecResult.Failure(msg)) =
+          eval(TestCase.exe.assembly): @unchecked
+        val expectedMsg =
+          """The created assembly jar contains more than 65535 ZIP entries.
+            |JARs of that size are known to not work correctly with a prepended shell script.
+            |Either reduce the entries count of the assembly or disable the prepended shell script with:
+            |
+            |  def prependShellScript = ""
+            |""".stripMargin
+        assert(msg == expectedMsg)
+
+      }
+    }
+    test("noExe") {
+      UnitTester(TestCase, sourceRoot = sources).scoped { eval =>
+        val Right(result) = eval(TestCase.noExe.assembly): @unchecked
+        os.call(
+          cmd = (Jvm.javaExe, "-jar", result.value.path, "--text", "tutu"),
+          env = Map.empty[String, String],
+          cwd = TestCase.moduleDir,
+          stdin = os.Inherit,
+          stdout = os.Inherit
+        )
+
+      }
+    }
+  }
+}

libs/scalalib/test/src/mill/scalalib/AssemblyNoExeTests.scala

@@ -4,24 +4,10 @@ import mill.*
 import mill.testkit.{TestRootModule, UnitTester}
 import utest.*
 
-import scala.util.Properties
 import HelloWorldTests.*
 import mill.api.Discover
 object ScalaMacrosTests extends TestSuite {
 
-  object HelloWorldMacros212 extends TestRootModule {
-    object core extends ScalaModule {
-      override def scalaVersion = scala212Version
-      override def mvnDeps = Seq(
-        mvn"com.github.julien-truffaut::monocle-macro::1.6.0"
-      )
-      override def scalacPluginMvnDeps = super.scalacPluginMvnDeps() ++ Seq(
-        mvn"org.scalamacros:::paradise:2.1.0"
-      )
-    }
-    lazy val millDiscover = Discover[this.type]
-  }
-
   object HelloWorldMacros213 extends TestRootModule {
     object core extends ScalaModule {
       override def scalaVersion = scala213Version
@@ -34,32 +20,6 @@ object ScalaMacrosTests extends TestSuite {
   def tests: Tests = Tests {
 
     test("macros") {
-      test("scala-2.12") {
-        // Scala 2.12 does not always work with Java 17+
-        // make sure macros are applied when compiling/running
-        val mod = HelloWorldMacros212
-        test("runMain") - UnitTester(
-          mod,
-          sourceRoot = os.Path(sys.env("MILL_TEST_RESOURCE_DIR")) / "hello-world-macros"
-        ).scoped { eval =>
-          if (Properties.isJavaAtLeast(17)) "skipped on Java 17+"
-          else {
-            val Right(result) = eval.apply(mod.core.runMain("Main")): @unchecked
-            assert(result.evalCount > 0)
-          }
-        }
-        // make sure macros are applied when compiling during scaladoc generation
-        test("docJar") - UnitTester(
-          mod,
-          sourceRoot = os.Path(sys.env("MILL_TEST_RESOURCE_DIR")) / "hello-world-macros"
-        ).scoped { eval =>
-          if (Properties.isJavaAtLeast(17)) "skipped on Java 17+"
-          else {
-            val Right(result) = eval.apply(mod.core.docJar): @unchecked
-            assert(result.evalCount > 0)
-          }
-        }
-      }
       test("scala-2.13") {
         // make sure macros are applied when compiling/running
         val mod = HelloWorldMacros213