Documentation Review (#5477)

Author: lihaoyi

contrib/playlib/src/mill/playlib/Layout.scala

@@ -5,8 +5,8 @@ import mill.scalalib._
 
 private[playlib] trait Layout extends JavaModule {
 
-  def conf = Task.Sources { "conf" }
-  def app = Task.Sources { "app" }
+  def conf = Task.Sources("conf")
+  def app = Task.Sources("app")
 
   override def sources = Task { app() }
   override def resources = Task { conf() }

contrib/playlib/src/mill/playlib/PlayModule.scala

@@ -18,7 +18,7 @@ trait PlayApiModule extends Dependencies with Router with Server {
       }
       Seq(mvn"org.scalatestplus.play::scalatestplus-play::${scalatestPlusPlayVersion}")
     }
-    override def sources: T[Seq[PathRef]] = Task.Sources { moduleDir }
+    override def sources: T[Seq[PathRef]] = Task.Sources(moduleDir)
   }
 
   def start(args: Task[Args] = Task.Anon(Args())) = Task.Command { run(args)() }

contrib/playlib/src/mill/playlib/RouterModule.scala

@@ -8,7 +8,7 @@ import mill.{T, Task}
 
 trait RouterModule extends ScalaModule with Version {
 
-  def routes: T[Seq[PathRef]] = Task.Sources { "routes" }
+  def routes: T[Seq[PathRef]] = Task.Sources("routes")
 
   def routeFiles = Task {
     val paths = routes().flatMap(file => os.walk(file.path))

contrib/playlib/src/mill/playlib/Static.scala

@@ -25,7 +25,7 @@ trait Static extends ScalaModule {
   /**
    *  Directories to include assets from
    */
-  def assetSources = Task.Sources { os.sub / "public" }
+  def assetSources = Task.Sources("public")
 
   /*
   Collected static assets for the project

contrib/scalapblib/src/mill/contrib/scalapblib/ScalaPBModule.scala

@@ -52,9 +52,7 @@ trait ScalaPBModule extends ScalaModule {
 
   def scalaPBProtocPath: T[Option[String]] = Task { None }
 
-  def scalaPBSources: T[Seq[PathRef]] = Task.Sources {
-    moduleDir / "protobuf"
-  }
+  def scalaPBSources: T[Seq[PathRef]] = Task.Sources("protobuf")
 
   def scalaPBOptions: T[String] = Task {
     (

contrib/scalapblib/test/src/mill/contrib/scalapblib/TutorialTests.scala

@@ -51,9 +51,9 @@ object TutorialTests extends TestSuite {
 
   object TutorialWithSpecificSources extends TutorialBase {
     object core extends TutorialModule {
-      override def scalaPBSources: T[Seq[PathRef]] = Task.Sources {
-        moduleDir / "protobuf/tutorial/Tutorial.proto"
-      }
+      override def scalaPBSources: T[Seq[PathRef]] = Task.Sources(
+        "protobuf/tutorial/Tutorial.proto"
+      )
 
       override def scalaPBSearchDeps = true
       override def scalaPBIncludePath = Task.Sources(

contrib/twirllib/src/mill/twirllib/TwirlModule.scala

@@ -28,9 +28,7 @@ trait TwirlModule extends mill.Module { twirlModule =>
     }
   }
 
-  def twirlSources: T[Seq[PathRef]] = Task.Sources {
-    moduleDir / "views"
-  }
+  def twirlSources: T[Seq[PathRef]] = Task.Sources("views")
 
   /**
    * Replicate the logic from twirl build,

core/exec/test/src/mill/exec/ExecutionTests.scala

@@ -34,7 +34,7 @@ object ExecutionTests extends TestSuite {
   }
 
   object sourceBuild extends TestRootModule {
-    def source = Task.Source { "hello/world.txt" }
+    def source = Task.Source("hello/world.txt")
     def task = Task { os.read(source().path) + " !" }
     lazy val millDiscover = Discover[this.type]
   }

core/exec/test/src/mill/exec/JavaCompileJarTests.scala

@@ -37,9 +37,9 @@ object JavaCompileJarTests extends TestSuite {
         //           resourceRoot ---->  jar
         //                                ^
         //           readmePath---------- |
-        def readme = Task.Source { readmePath }
-        def sourceRoot = Task.Sources { sourceRootPath }
-        def resourceRoot = Task.Sources { resourceRootPath }
+        def readme = Task.Source(readmePath)
+        def sourceRoot = Task.Sources(sourceRootPath)
+        def resourceRoot = Task.Sources(resourceRootPath)
         def allSources =
           Task { sourceRoot().flatMap(p => os.walk(p.path)).map(PathRef(_)) }
         def classFiles = Task { compileAll(allSources()) }

example/androidlib/java/3-linting/build.mill

@@ -26,11 +26,11 @@ object app extends AndroidAppModule {
   def androidApplicationNamespace = "com.helloworld.app"
 
   // Set path to the custom `lint.xml` config file. It is usually at the root of the project
-  def androidLintConfigPath0 = Task.Sources { "lint.xml" }
+  def androidLintConfigPath0 = Task.Sources("lint.xml")
   def androidLintConfigPath = Task { androidLintConfigPath0().headOption }
 
   // Set path to the custom `baseline.xml` file. It is usually at the root of the project
-  def androidLintBaselinePath0 = Task.Sources { "lint-baseline.xml" }
+  def androidLintBaselinePath0 = Task.Sources("lint-baseline.xml")
   def androidLintBaselinePath = Task { androidLintBaselinePath0().headOption }
 
   // Set the linting report to be generated as both text and html files