Ensure MappedRoots.withMillDefaults is used with named parameters

Author: lefou

core/api/src/mill/api/MappedRoots.scala

@@ -1,7 +1,9 @@
 package mill.api
 
+import mill.api.internal.NamedParameterOnlyDummy
 import mill.constants.PathVars
 
+import scala.annotation.unused
 import scala.util.DynamicVariable
 
 type MappedRoots = Seq[(key: String, path: os.Path)]
@@ -17,6 +19,7 @@ trait MappedRootsImpl {
   def toMap: Map[String, os.Path] = get.map(m => (m.key, m.path)).toMap
 
   def withMillDefaults[T](
+      @unused t: NamedParameterOnlyDummy = new NamedParameterOnlyDummy,
       outPath: os.Path,
       workspacePath: os.Path = BuildCtx.workspaceRoot,
       homePath: os.Path = os.home

core/exec/src/mill/exec/GroupExecution.scala

@@ -83,7 +83,7 @@ trait GroupExecution {
       executionContext: mill.api.TaskCtx.Fork.Api,
       exclusive: Boolean,
       upstreamPathRefs: Seq[PathRef]
-  ): GroupExecution.Results = MappedRoots.withMillDefaults(outPath) {
+  ): GroupExecution.Results = MappedRoots.withMillDefaults(outPath = outPath) {
 
     val inputsHash = {
       val externalInputsHash = MurmurHash3.orderedHash(

runner/daemon/src/mill/daemon/MillBuildBootstrap.scala

@@ -70,7 +70,7 @@ class MillBuildBootstrap(
     val runnerState = evaluateRec(0)
 
     for ((frame, depth) <- runnerState.frames.zipWithIndex) {
-      MappedRoots.withMillDefaults(output) {
+      MappedRoots.withMillDefaults(outPath = output) {
         os.write.over(
           recOut(output, depth) / millRunnerState,
           upickle.write(frame.loggedData, indent = 4),

runner/daemon/src/mill/daemon/MillDaemonMain.scala

@@ -39,7 +39,7 @@ object MillDaemonMain {
     val args =
       Args(getClass.getName, args0).fold(err => throw IllegalArgumentException(err), identity)
 
-    MappedRoots.withMillDefaults(args.outDir) {
+    MappedRoots.withMillDefaults(outPath = args.outDir) {
       if (Properties.isWin)
         // temporarily disabling FFM use by coursier, which has issues with the way
         // Mill manages class loaders, throwing things like

testkit/src/mill/testkit/UnitTester.scala

@@ -237,7 +237,7 @@ class UnitTester(
   def scoped[T](tester: UnitTester => T): T = {
     try {
       BuildCtx.workspaceRoot0.withValue(module.moduleDir) {
-        MappedRoots.withMillDefaults(outPath) {
+        MappedRoots.withMillDefaults(outPath = outPath) {
           tester(this)
         }
       }