Fix incorrect prepareOffline in AssemblyModule

unlsycn · unlsycn · commit f0fba2f42228 · 2025-09-06T19:12:28.000+08:00
`prepareOffline` method should be a member of the trait, otherwise it
will not be evaluated by downstream modules.

Signed-off-by: unlsycn &lt;unlsycn@unlsycn.com&gt;
diff --git a/libs/javalib/src/mill/javalib/AssemblyModule.scala b/libs/javalib/src/mill/javalib/AssemblyModule.scala
@@ -11,7 +11,7 @@ import mill.util.Jvm
 /**
  * Module that provides functionality around creating and configuring JVM assembly jars
  */
-trait AssemblyModule extends mill.api.Module {
+trait AssemblyModule extends mill.api.Module with OfflineSupportModule {
   outer =>
 
   def finalMainClassOpt: T[Either[String, String]]
@@ -148,6 +148,11 @@ trait AssemblyModule extends mill.api.Module {
       created.pathRef
     }
   }
+
+  override def prepareOffline(all: mainargs.Flag): Task.Command[Seq[PathRef]] = Task.Command {
+    AssemblyModule.prepareOffline(all)()
+  }
+
 }
 object AssemblyModule extends ExternalModule with CoursierModule with OfflineSupportModule {
 

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ import mill.util.Jvm`
`11`	`11`	`/**`
`12`	`12`	`* Module that provides functionality around creating and configuring JVM assembly jars`
`13`	`13`	`*/`
`14`		`-trait AssemblyModule extends mill.api.Module {`
	`14`	`+trait AssemblyModule extends mill.api.Module with OfflineSupportModule {`
`15`	`15`	`outer =>`
`16`	`16`
`17`	`17`	`def finalMainClassOpt: T[Either[String, String]]`
`@@ -148,6 +148,11 @@ trait AssemblyModule extends mill.api.Module {`
`148`	`148`	`created.pathRef`
`149`	`149`	`}`
`150`	`150`	`}`
	`151`	`+`
	`152`	`+ override def prepareOffline(all: mainargs.Flag): Task.Command[Seq[PathRef]] = Task.Command {`
	`153`	`+ AssemblyModule.prepareOffline(all)()`
	`154`	`+ }`
	`155`	`+`
`151`	`156`	`}`
`152`	`157`	`object AssemblyModule extends ExternalModule with CoursierModule with OfflineSupportModule {`
`153`	`158`