Fix build failures (#64)

Fixing 3 issues:

(1) SpawningSubProcessTests::"spawn callback" has a race condition that causes occasional failures.
It should use SubProcess#join instead of SubProcess#waitFor in order to guarantee that all stdout and stderr from the subprocess is handled.

(2) Scala3 compilation fails when passing the "-release" flag to the compiler

(3) There is no macOS-11.0 support in GitHub Actions

Commits:

* use SubProcess#join instead in SubProcess#waitFor in spwan callback test

* don't specify the scalac -release flag for Scala3

* [os.watch] Darwin doesn't generate callbacks for updates to hard links

* Removed macos-11.0 from github workflow

Why? because it fails to start.

Pull request: #64

Co-authored-by: Ahmed Gheith <[email protected]>

Author: utgheith

.github/workflows/build.yml

@@ -5,7 +5,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-latest, ubuntu-20.04, windows-latest, macos-latest, macos-11.0]
+        os: [ubuntu-latest, ubuntu-20.04, windows-latest, macos-latest]
         java-version: [1.8, 11]
 
     runs-on: ${{ matrix.os }}

build.sc

@@ -136,7 +136,8 @@ trait OsModule extends OsLibModule{
   def ivyDeps = Agg(
     ivy"com.lihaoyi::geny::0.6.5"
   )
-  def scalacOptions = Seq("-release", "8")
+  //def scalacOptions = Seq("-release", "8")
+  def scalacOptions = T{ if (scalaVersion().startsWith("3")) Seq() else Seq("-release", "8") }
 }
 
 trait WatchModule extends OsLibModule{

os/test/src-jvm/SpawningSubprocessesTests.scala

@@ -134,7 +134,7 @@ object SpawningSubprocessesTests extends TestSuite {
           val output: mutable.Buffer[String] = mutable.Buffer()
           val sub = os.proc("echo", "output")
             .spawn(stdout = ProcessOutput((bytes, count) => output += new String(bytes, 0, count)))
-          val finished = sub.waitFor(5000)
+          val finished = sub.join(5000)
           sub.wrapped.getOutputStream().flush()
           assert(finished)
           assert(sub.exitCode() == 0)

os/watch/test/src/WatchTests.scala

@@ -120,7 +120,7 @@ object WatchTests extends TestSuite{
           case "Linux" => Set(os.sub / "newlink3")
           case "Mac OS X" =>
             Set(
-              os.sub / "newlink3",
+              //os.sub / "newlink3",
               os.sub / "folder3" / "nestedA",
               os.sub / "folder3" / "nestedA" / "a.txt",
             )