Skip to content

Conversation

@counter2015
Copy link
Contributor

This pull request includes several changes to improve code quality, update dependencies, and enhance functionality. The most important changes include updating Scala versions and dependencies, adding new compiler options, and fixing various typos and formatting issues.

Dependency Updates:

  • Updated Scala versions to 3.3.3 and 2.12.19 in build.mill.
  • Added scala-collection-compat dependency in build.mill.

Code Enhancements:

  • Added new compiler options (-deprecation, -feature, -language:implicitConversions, -language:higherKinds) in build.mill.
  • Integrated ScalafmtModule into OsModule and added collectionCompact dependency in build.mill.

Typo and Formatting Fixes:

  • Corrected typos in documentation comments in os/src/ListOps.scala
  • Fixed various method signatures and added missing return types in os/src/SubProcess.scala

Migration to Modern Scala Collections:

  • Replaced collection.JavaConverters with scala.jdk.CollectionConverters across multiple files (os/src/Path.scala, os/src/ProcessOps.scala, os/src/ReadWriteOps.scala, os/src/ZipOps.scala, os/test/src-jvm/ZipOpJvmTests.scala, os/watch/src/WatchServiceWatcher.scala)

@counter2015 counter2015 marked this pull request as ready for review November 14, 2024 08:37
@counter2015
Copy link
Contributor Author

@sake92 is there anything else I can do to improve this PR ?

@lihaoyi
Copy link
Member

lihaoyi commented Nov 21, 2024

I'm going to call this a wontfix. I don't find these improvements worth the churn they introduce to the codebase

@lihaoyi lihaoyi closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants