Skip to content

Commit bd4f194

Browse files
committed
chore: Add scalaNextVersion and add it into GitHub CI Actions
1 parent a094614 commit bd4f194

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

.github/workflows/actions.yml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,12 @@ on:
99
pull_request:
1010
branches:
1111
- master
12+
workflow_dispatch: # be able to manually trigger a workflow run
13+
14+
env:
15+
SCALA_NEXT_VERSION: '3.6.2'
16+
# TODO: perherps, it would be nice to allow failure on `SCALA_NEXT_VERSION` as a warning
17+
# to avoid too strict dev experiences in the future improvements.
1218

1319
jobs:
1420
test:
@@ -23,7 +29,7 @@ jobs:
2329
distribution: 'temurin'
2430
java-version: ${{ matrix.java }}
2531
- name: Run tests
26-
run: ./mill -i __.publishArtifacts + __.test
32+
run: ./mill -DscalaNextVersion=${{ env.SCALA_NEXT_VERSION }} -i __.publishArtifacts + __.test
2733

2834
check-binary-compatibility:
2935
runs-on: ubuntu-latest
@@ -36,7 +42,7 @@ jobs:
3642
distribution: 'temurin'
3743
java-version: 17
3844
- name: Check Binary Compatibility
39-
run: ./mill -i __.mimaReportBinaryIssues
45+
run: ./mill -DscalaNextVersion=${{ env.SCALA_NEXT_VERSION }} -i __.mimaReportBinaryIssues
4046

4147
publish-sonatype:
4248
if: github.repository == 'com-lihaoyi/requests-scala' && contains(github.ref, 'refs/tags/')

build.mill

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ import $ivy.`com.github.lolgab::mill-mima::0.0.24`
1010
import de.tobiasroeser.mill.vcs.version.VcsVersion
1111
import com.github.lolgab.mill.mima._
1212

13-
val dottyVersion = sys.props.get("dottyVersion")
14-
val scalaVersions = List("2.12.20", "2.13.15", "3.3.4") ++ dottyVersion
13+
val scalaNextVersion = sys.props.get("scalaNextVersion")
14+
val scalaVersions = List("2.12.20", "2.13.15", "3.3.4") ++ scalaNextVersion
1515

1616
trait RequestsJvmModule extends RequestsModule with Mima {
1717
def mimaPreviousArtifacts = Agg(

0 commit comments

Comments
 (0)