Review comments

Author: Flurb

src/editors/protocol104/subnetwork-container.ts

@@ -12,7 +12,7 @@ import '@material/mwc-icon-button';
 import './connectedap-editor.js';
 import { compareNames, newWizardEvent } from '../../foundation.js';
 import { translate } from 'lit-translate';
-import { createConnectedAp104Wizard } from './wizards/connectedap.js';
+import { createConnectedApWizard } from './wizards/connectedap.js';
 
 /** [[`104`]] subeditor for a `SubNetwork` element. */
 @customElement('subnetwork-104-container')
@@ -31,7 +31,7 @@ export class SubNetwork104Container extends LitElement {
   }
 
   private openConnectedAPwizard(): void {
-    this.dispatchEvent(newWizardEvent(createConnectedAp104Wizard(this.element)));
+    this.dispatchEvent(newWizardEvent(createConnectedApWizard(this.element)));
   }
 
   private renderIedContainer(): TemplateResult[] {

src/editors/protocol104/wizards/connectedap.ts

@@ -96,7 +96,7 @@ function existConnectedAp(accesspoint: Element): boolean {
 }
 
 /** @returns single page  [[`Wizard`]] for creating SCL element ConnectedAP. */
-export function createConnectedAp104Wizard(element: Element): Wizard {
+export function createConnectedApWizard(element: Element): Wizard {
   const doc = element.ownerDocument;
 
   const accessPoints = Array.from(doc.querySelectorAll(':root > IED'))

src/editors/protocol104/wizards/foundation.ts

@@ -1,7 +1,7 @@
 import { html, TemplateResult } from "lit-element";
 import { ifDefined } from "lit-html/directives/if-defined";
 import { translate } from "lit-translate";
-import { typeMaxLength, typeNullable } from "../../../wizards/foundation/p-types.js";
+import { typeMaxLength } from "../../../wizards/foundation/p-types.js";
 import { typeDescriptiveNameKeys, typePattern } from "../foundation/p-types.js";
 
 
@@ -15,7 +15,6 @@ export function createCreateTextField(pType: string): TemplateResult {
     required
     label="${pType}"
     pattern="${ifDefined(typePattern[pType])}"
-    ?nullable=${typeNullable[pType]}
     maxLength="${ifDefined(typeMaxLength[pType])}"
     helper="${translate(typeDescriptiveNameKeys[pType])}"
   ></wizard-textfield>`

test/unit/editors/protocol104/wizards/connectedap.test.ts

@@ -4,7 +4,7 @@ import { SinonSpy, spy } from 'sinon';
 import '../../../../mock-wizard.js';
 
 import { Checkbox } from '@material/mwc-checkbox';
-import { createConnectedAp104Wizard, editConnectedApWizard } from '../../../../../src/editors/protocol104/wizards/connectedap.js';
+import { createConnectedApWizard, editConnectedApWizard } from '../../../../../src/editors/protocol104/wizards/connectedap.js';
 import { ComplexAction, Create, Delete, isCreate, isDelete, WizardInputElement } from '../../../../../src/foundation.js';
 import { MockWizard } from '../../../../mock-wizard.js';
 import { WizardTextField } from '../../../../../src/wizard-textfield.js';
@@ -139,7 +139,7 @@ describe('Wizards for SCL element ConnectedAP', () => {
 
   describe('include a create wizard that', () => {
     beforeEach(async () => {
-      const wizard = createConnectedAp104Wizard(doc.querySelector('SubNetwork[type="104"] > ConnectedAP[apName="AP2"]')!);
+      const wizard = createConnectedApWizard(doc.querySelector('SubNetwork[type="104"] > ConnectedAP[apName="AP2"]')!);
       element.workflow.push(() => wizard);
       await element.requestUpdate();