test: fix minor issues to successfully run test in firefox

* test(testfiles): fix invalid *.scd file

* test(editors/communicationsubnetwork): fix invalid xml file

* fix(lnodetype-wizard): fix unstable compare function

* fix(lnodetype-wizard): remove superfluous import statement

Author: JakobVogelsang

__snapshots__/LNodeType wizards.md

@@ -3082,18 +3082,18 @@
         mwc-list-item=""
         role="option"
         tabindex="0"
-        value="Dummy.LLN0.Beh"
+        value="Dummy.LLN0.Health"
       >
-        Dummy.LLN0.Beh
+        Dummy.LLN0.Health
       </mwc-list-item>
       <mwc-list-item
         aria-disabled="false"
         mwc-list-item=""
         role="option"
         tabindex="-1"
-        value="Dummy.LLN0.Health"
+        value="Dummy.LLN0.Beh"
       >
-        Dummy.LLN0.Health
+        Dummy.LLN0.Beh
       </mwc-list-item>
     </mwc-select>
     <mwc-select

src/editors/templates/lnodetype-wizard.ts

@@ -33,7 +33,6 @@ import { ListItem } from '@material/mwc-list/mwc-list-item';
 import { Select } from '@material/mwc-select';
 import { SingleSelectedEvent } from '@material/mwc-list/mwc-list-foundation';
 import { Switch } from '@material/mwc-switch';
-import { Formfield } from '@material/mwc-formfield';
 
 function updateDoAction(element: Element): WizardActor {
   return (inputs: WizardInput[]): EditorAction[] => {
@@ -294,9 +293,19 @@ function createNewLNodeType(parent: Element, element: Element): WizardActor {
   };
 }
 
-function compareDOTypeId(id: string, cdc: string): -1 | 0 | 1 {
-  if (id.includes(cdc)) return 1;
-  return 0;
+function doComparator(name: string) {
+  return (a: Element, b: Element) => {
+    const idA = a.getAttribute('id') ?? '';
+    const idB = b.getAttribute('id') ?? '';
+
+    const aHasName = idA.includes(name);
+    const bHasName = idB.includes(name);
+
+    if (!aHasName && bHasName) return 1;
+    if (aHasName && !bHasName) return -1;
+
+    return idA.localeCompare(idB);
+  };
 }
 
 function createLNodeTypeHelperWizard(
@@ -319,7 +328,7 @@ function createLNodeTypeHelperWizard(
           parent
             .closest('DataTypeTemplates')!
             .querySelectorAll(`DOType[cdc="${DO.getAttribute('type')}"]`)
-        ).sort((a, b) => compareDOTypeId(b.getAttribute('id') ?? '', name));
+        ).sort(doComparator(name));
 
         return html`<mwc-select
           fixedMenuPosition

test/testfiles/updatesubstation-ours.scd

@@ -59,7 +59,7 @@
 			<ConfLNs fixPrefix="true" fixLnInst="true" />
 		</Services>
 		<AccessPoint name="P1">
-			<LN prefix="DC3" lnClass="XSWI" inst="2" lnType="Dummy.XSWI1">
+			<LN prefix="DC3" lnClass="XSWI" inst="2" lnType="Dummy.XSWI1"/>
 			<Server>
 				<Authentication none="true" />
 				<LDevice inst="CircuitBreaker_CB1">
@@ -87,4 +87,4 @@
 		</AccessPoint>
 		<KDC iedName="IED1" apName="P1"/>
 	</IED>
-</SCL>
+</SCL>

test/unit/editors/communication/SubNetwork.test.ts

@@ -90,7 +90,7 @@ describe('SubNetworkEditor', () => {
           element = new DOMParser().parseFromString(
             `<SubNetwork>
               <BitRate unit="b/s" multiplier="M">100</BitRate>
-              </BitRate>`,
+              </SubNetwork>`,
             'application/xml'
           ).documentElement;
         });