Skip to content

Commit 1db5169

Browse files
danyilljuancho0202Dennis LabordusJakob VogelsangJakobVogelsang
authored
feat(editors/cleanup): Support DataTypeTemplates (openscd#701)
* refactor: took sclHistory out of Logging mixin * feat(history-plugin): added sclHistory plugin * chore(Logging): removing unused icon * fix(historyPlugin): refactor with suggestions from @dlabordus * test(sclHistory): improving tests * Fixed settings test. Signed-off-by: Dennis Labordus <[email protected]> * Fixed plugin config. Signed-off-by: Dennis Labordus <[email protected]> * Fixed snapshot. Signed-off-by: Dennis Labordus <[email protected]> * fix(viewSclHistory): removed unused label * fix(translate): proper german labels by @JakobVogelsang * fix(scl-history): noEntries label and snapshot * Initial layout, translations and icons * Implement basic functionality * Simplify logic and make subtypes checkbox more context sensitive * Clean up SDO and BDA[Struct] subtypes * Add tests, improve testfile conformance, add hover for edit button * Update control block snapshot for SCL validation improvements * refactor: typo Co-authored-by: danyill <[email protected]> * fix: remove console.log Co-authored-by: danyill <[email protected]> * Improvements after review * Add recursive checking of datatype references * Fixed filter and search behaviour, following openscd#910 * Change filtering for css consistency with control blocks container * Fix snapshots and tests * Index EnumTypes * Tidy up css to work better with flex * Add test for nested EnumType * Update snapshots Signed-off-by: Dennis Labordus <[email protected]> Co-authored-by: Juan Muñoz <[email protected]> Co-authored-by: Dennis Labordus <[email protected]> Co-authored-by: Jakob Vogelsang <[email protected]> Co-authored-by: Jakob Vogelsang <[email protected]>
1 parent 4d52a9a commit 1db5169

File tree

12 files changed

+1695
-22
lines changed

12 files changed

+1695
-22
lines changed

src/editors/Cleanup.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import { styles } from './templates/foundation.js';
66

77
import './cleanup/datasets-container.js';
88
import './cleanup/control-blocks-container.js';
9+
import './cleanup/datatypes-container.js';
910

1011
/** An editor [[`plugin`]] for cleaning SCL references and definitions. */
1112
export default class Cleanup extends LitElement {
@@ -18,6 +19,7 @@ export default class Cleanup extends LitElement {
1819
<div class="cleanup">
1920
<cleanup-datasets .doc=${this.doc}></cleanup-datasets>
2021
<cleanup-control-blocks .doc=${this.doc}></cleanup-control-blocks>
22+
<cleanup-data-types .doc=${this.doc}></cleanup-data-types>
2123
</div>
2224
`;
2325
}
@@ -29,7 +31,7 @@ export default class Cleanup extends LitElement {
2931
width: 100vw;
3032
}
3133
32-
@media (max-width: 800px) {
34+
@media (max-width: 799px) {
3335
.cleanup {
3436
flex-direction: column;
3537
}
@@ -41,14 +43,11 @@ export default class Cleanup extends LitElement {
4143
}
4244
}
4345
44-
cleanup-datasets, cleanup-control-blocks {
46+
cleanup-datasets, cleanup-control-blocks, cleanup-data-types {
4547
display: flex;
4648
flex: 1;
4749
flex-direction: column;
4850
justify-content: space-between;
49-
/* any more than 700px and distance between check box and item is too great */
50-
max-width: 700px;
51-
5251
}
5352
5453
.cleanup {

0 commit comments

Comments
 (0)