fix(Settings): Allow missmatched nsdoc import (openscd#1690)

Author: clepski

packages/openscd/src/addons/Settings.ts

@@ -253,7 +253,7 @@ export class OscdSettings extends LitElement {
     if (!this.isEqual(nsdVersion, nsdocVersion)) {
       this.dispatchEvent(
         newLogEvent({
-          kind: 'error',
+          kind: 'warning',
           title: get('settings.invalidNsdocVersion', {
             id: id,
             filename: event.detail.filename,
@@ -262,7 +262,6 @@ export class OscdSettings extends LitElement {
           }),
         })
       );
-      return;
     }
 
     this.setSetting(id as keyof Settings, event.detail.nsdoc);

packages/openscd/test/integration/Setting.test.ts

@@ -63,6 +63,25 @@ describe('Oscd-Settings', () => {
     );
   });
 
+  it('upload .nsdoc file with missmatched nsd version using event and log event fired', async () => {
+    settings.settingsUI.show();
+    await settings.settingsUI.updateComplete;
+
+    const nsdocFile = await fetch('/test/testfiles/nsdoc/IEC_61850-7-2-B-5.nsdoc').then(
+      response => response.text()
+    );
+
+    logger.dispatchEvent(newLoadNsdocEvent(nsdocFile, 'IEC_61850-7-2-B-5.nsdoc'));
+
+    await logger.requestUpdate();
+    await logger.updateComplete;
+
+    expect(logger.log.length).to.be.equal(1);
+    expect(logger.log[0].title).to.be.equal(
+      "The version of IEC 61850-7-2 NSD (2007B3) does not correlate with the version of the corresponding NSDoc (IEC_61850-7-2-B-5.nsdoc, 2007B5)"
+    );
+  });
+
   it('upload .nsdoc file with wrong version using event and log event fired', async () => {
     settings.settingsUI.show();
     await settings.settingsUI.updateComplete;

packages/openscd/test/testfiles/nsdoc/IEC_61850-7-2-B-5.nsdoc

@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<NSDoc id="IEC 61850-7-2"
+       version="2007"
+       revision="B"
+       release="5"
+       lang="en">
+</NSDoc>

packages/openscd/test/unit/Setting.test.ts

@@ -6,6 +6,7 @@ import '../../src/addons/Settings.js';
 import { OscdSettings, defaults } from '../../src/addons/Settings.js';
 
 import { Button } from '@material/mwc-button';
+import { LogEvent } from '@openscd/core/foundation/deprecated/history.js';
 
 describe('OSCD-Settings', () => {
   let element: OscdSettings;
@@ -69,6 +70,23 @@ describe('OSCD-Settings', () => {
     await expect(element).shadowDom.to.equalSnapshot();
   });
 
+  it('loads .nsdoc file with missmatched nsd version', async () => {
+    element.settingsUI.show();
+    await element.settingsUI.updateComplete;
+
+    const nsdocFile = await fetch(
+      '/test/testfiles/nsdoc/IEC_61850-7-2-B-5.nsdoc'
+    ).then(response => response.text());
+
+    element.setSetting('IEC 61850-7-2', nsdocFile);
+
+    await element.requestUpdate();
+    await element.updateComplete
+
+    expect(localStorage.getItem('IEC 61850-7-2')).to.eql(nsdocFile);
+    await expect(element).shadowDom.to.equalSnapshot();
+  });
+
   it('saves chosen .nsdoc file and looks like latest snapshot', async () => {
     element.settingsUI.show();
     await element.settingsUI.updateComplete;