fix(substation/lnodewizard): localize LNode changes (#245)

Author: JakobVogelsang

src/editors/substation/lnodewizard.ts

@@ -4,8 +4,10 @@ import { get, translate } from 'lit-translate';
 import {
   createElement,
   EditorAction,
+  getChildElementsByTagName,
   getReference,
   identity,
+  isPublic,
   referencePath,
   selector,
   Wizard,
@@ -131,8 +133,8 @@ export function lNodeWizardAction(parent: Element): WizardActor {
       })
       .filter(item => item !== null);
 
-    const oldLNodes = Array.from(parent.getElementsByTagName('LNode')).filter(
-      item => !item.closest('Private')
+    const oldLNodes = getChildElementsByTagName(parent, 'LNode').filter(
+      isPublic
     );
 
     const deleteActions = oldLNodes

src/foundation.ts

@@ -2493,6 +2493,15 @@ export function getVersion(element: Element): string {
   return header[0].getAttribute('version') ?? '2003';
 }
 
+export function getChildElementsByTagName(
+  element: Element,
+  tag: string
+): Element[] {
+  return Array.from(element.children).filter(
+    element => element.tagName === tag
+  );
+}
+
 declare global {
   interface ElementEventMap {
     ['pending-state']: PendingStateEvent;

test/integration/editors/substation/lnodewizard.test.ts

@@ -125,6 +125,26 @@ describe('lnodewizard', () => {
           )
         ).to.exist;
       });
+      it('only create and remove its own logical node references', async () => {
+        const allLNodesNumber = doc.querySelectorAll(
+          'Bay[name="COUPLING_BAY"] LNode'
+        ).length;
+        (<List>(
+          element.wizardUI.shadowRoot
+            ?.querySelector('mwc-dialog:nth-child(2)')
+            ?.querySelector('filtered-list')
+        )).items[3].click();
+        await element.updateComplete;
+        (<HTMLElement>(
+          element.wizardUI.shadowRoot
+            ?.querySelector('mwc-dialog:nth-child(2)')
+            ?.querySelector('mwc-button[slot="primaryAction"]')
+        )).click();
+        await element.updateComplete;
+        expect(
+          doc.querySelectorAll('Bay[name="COUPLING_BAY"] LNode').length
+        ).to.equal(allLNodesNumber + 1);
+      });
     });
   });
 });

test/unit/foundation.test.ts

@@ -21,6 +21,7 @@ import {
   tags,
   getReference,
   SCLTag,
+  getChildElementsByTagName,
 } from '../../src/foundation.js';
 
 import { MockAction } from './mock-actions.js';
@@ -486,4 +487,21 @@ describe('foundation', () => {
       );
     });
   });
+
+  describe('getChildElementsByTagName', () => {
+    let doc: Document;
+    beforeEach(async () => {
+      doc = await fetch('/base/test/testfiles/lnodewizard.scd')
+        .then(response => response.text())
+        .then(str => new DOMParser().parseFromString(str, 'application/xml'));
+    });
+    it('returns a child Element array with a specific tag', () => {
+      const parent = doc.querySelector('Bay[name="COUPLING_BAY"]');
+      expect(getChildElementsByTagName(parent!, 'LNode').length).to.have.equal(
+        parent?.querySelectorAll(
+          ':root > Substation > VoltageLevel > Bay[name="COUPLING_BAY"] > LNode'
+        ).length
+      );
+    });
+  });
 });