fix(validatetemplates): don't require "Oper" if ctlModel=status-only (#269)

* refactor(validatetemplates, validateschema): unify translations

* fix(validator/velidatetemplate): add warning for missing ctlModel definition

Co-authored-by: Jakob Vogelsang <[email protected]>

Author: ca-d

src/translations/de.ts

@@ -64,12 +64,22 @@ export const de: Translations = {
         '{{ parent }} enthält bereits ein {{ child }} Kind namens "{{ name }}"',
     },
   },
-  validate: {
-    title: 'Projekt validieren',
-    valid: '{{ name }} erfolgreich validiert',
-    invalid: '{{ name }} Validierung fehlgeschlagen',
-    fatal: 'Fataler Validierungsfehler',
-    loadError: 'Konnte Schema {{ name }} nicht laden',
+  validator: {
+    schema: {
+      title: 'Projekt validieren',
+      valid: '{{ name }} erfolgreich validiert',
+      invalid: '{{ name }} Validierung fehlgeschlagen',
+      fatal: 'Fataler Validierungsfehler',
+      loadError: 'Konnte Schema {{ name }} nicht laden',
+    },
+    templates: {
+      title: 'Templates validieren',
+      mandatoryChild:
+        '{{ tag }} {{ id }} fehlt ein obligatorisches {{ childTag }}-Kind {{ childId }}',
+      missingCoDO: 'Control-Dienst Datenattribut vom Typ {{ type }} fehlt',
+      missingCtlModelDef:
+        'CtlModel Definition fehlt. Kann {{ childTag }} {{ childId }} in {{ tag }} {{ id }} nicht validieren.',
+    },
   },
   textfield: {
     required: 'Pflichtfeld',

src/translations/en.ts

@@ -95,12 +95,22 @@ export const en = {
       srcHelper: 'The vendor supplied extension URL',
     },
   },
-  validate: {
-    title: 'Validate project',
-    valid: '{{ name }} validation successful',
-    invalid: '{{ name }} validation failed',
-    fatal: 'Fatal validation error',
-    loadError: 'Could not load schema {{ name }}',
+  validator: {
+    schema: {
+      title: 'Validate project',
+      valid: '{{ name }} validation successful',
+      invalid: '{{ name }} validation failed',
+      fatal: 'Fatal validation error',
+      loadError: 'Could not load schema {{ name }}',
+    },
+    templates: {
+      title: 'Validate templates',
+      mandatoryChild:
+        '{{ tag }} {{ id }} is missing mandatory child {{ childTag }} {{ childId }}',
+      missingCoDO: 'Control service related DA of type {{ type }} is missing',
+      missingCtlModelDef:
+        'Missing ctlModel definition. Cannot validate {{ childTag }} {{ childId }} within {{ tag }} {{ id }}',
+    },
   },
   substation: {
     name: 'Substation',

src/validators/ValidateSchema.ts

@@ -23,7 +23,7 @@ export default class ValidateSchema extends LitElement {
   docName!: string;
 
   private async getValidator(xsd: string, xsdName: string): Promise<Validator> {
-    if (!window.Worker) throw new Error(get('validate.fatal'));
+    if (!window.Worker) throw new Error(get('validator.schema.fatal'));
     if (validators[xsdName]) return validators[xsdName]!;
 
     const worker: Worker = new Worker('public/js/worker.js');
@@ -45,7 +45,7 @@ export default class ValidateSchema extends LitElement {
       worker.addEventListener('message', (e: MessageEvent<WorkerMessage>) => {
         if (isLoadSchemaResult(e.data)) {
           if (e.data.loaded) resolve(validate);
-          else reject(get('validate.loadEror', { name: e.data.file }));
+          else reject(get('validator.schema.loadEror', { name: e.data.file }));
         } else if (isValidationError(e.data)) {
           const parts = e.data.message.split(': ', 2);
           const description = parts[1] ? parts[1] : parts[0];
@@ -68,7 +68,7 @@ export default class ValidateSchema extends LitElement {
         } else if (!isValidationResult(e.data)) {
           document.querySelector('open-scd')!.dispatchEvent(
             newLogEvent({
-              title: get('validate.fatal'),
+              title: get('validator.schema.fatal'),
               kind: 'error',
               message: e.data,
             })
@@ -102,16 +102,16 @@ export default class ValidateSchema extends LitElement {
       document.querySelector('open-scd')!.dispatchEvent(
         newLogEvent({
           kind: 'warning',
-          title: get('validate.invalid', { name: result.file }),
+          title: get('validator.schema.invalid', { name: result.file }),
         })
       );
-      throw new Error(get('validate.invalid', { name: result.file }));
+      throw new Error(get('validator.schema.invalid', { name: result.file }));
     }
 
     document.querySelector('open-scd')!.dispatchEvent(
       newLogEvent({
         kind: 'info',
-        title: get('validate.valid', { name: result.file }),
+        title: get('validator.schema.valid', { name: result.file }),
       })
     );
   }