Skip to content

Commit 436a88f

Browse files
author
Dennis Labordus
committed
Changed camelcase of Line number.
Signed-off-by: Dennis Labordus <[email protected]>
1 parent 90fde9c commit 436a88f

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

src/validators/CompasValidateSchema.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,16 +86,16 @@ export default class CompasValidateSchema extends LitElement {
8686
const ruleName = validationError
8787
.getElementsByTagNameNS(SVS_NAMESPACE, 'RuleName')!
8888
.item(0)?.textContent;
89-
const linenumber = validationError
90-
.getElementsByTagNameNS(SVS_NAMESPACE, 'Linenumber')!
89+
const lineNumber = validationError
90+
.getElementsByTagNameNS(SVS_NAMESPACE, 'LineNumber')!
9191
.item(0)?.textContent;
9292
const columnNumber = validationError
9393
.getElementsByTagNameNS(SVS_NAMESPACE, 'ColumnNumber')!
9494
.item(0)?.textContent;
9595

9696
const messageParts: string[] = [];
9797
if (ruleName) messageParts.push(`Rule: ${ruleName}`);
98-
if (linenumber) messageParts.push(`Line: ${linenumber}`);
98+
if (lineNumber) messageParts.push(`Line: ${lineNumber}`);
9999
if (columnNumber) messageParts.push(`Column: ${columnNumber}`);
100100

101101
if (messageParts.length == 0) {

test/unit/validators/CompasValidateSchema.test.ts

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,13 @@ describe('CompasValidateSchema', () => {
2727
<svs:ValidationErrors>
2828
<svs:Message>Message 1</svs:Message>
2929
<svs:RuleName>Rule 1</svs:RuleName>
30-
<svs:Linenumber>1</svs:Linenumber>
30+
<svs:LineNumber>1</svs:LineNumber>
3131
<svs:ColumnNumber>1</svs:ColumnNumber>
3232
</svs:ValidationErrors>
3333
<svs:ValidationErrors>
3434
<svs:Message>Message 2</svs:Message>
3535
<svs:RuleName>Rule 2</svs:RuleName>
36-
<svs:Linenumber>2</svs:Linenumber>
36+
<svs:LineNumber>2</svs:LineNumber>
3737
<svs:ColumnNumber>2</svs:ColumnNumber>
3838
</svs:ValidationErrors>
3939
</svs:SclValidateResponse>
@@ -71,18 +71,18 @@ describe('CompasValidateSchema', () => {
7171
<svs:ValidationErrors>
7272
<svs:Message>Message 1</svs:Message>
7373
<svs:RuleName>Rule 1</svs:RuleName>
74-
<svs:Linenumber>1</svs:Linenumber>
74+
<svs:LineNumber>1</svs:LineNumber>
7575
<svs:ColumnNumber>2</svs:ColumnNumber>
7676
</svs:ValidationErrors>
7777
<svs:ValidationErrors>
7878
<svs:Message></svs:Message>
7979
<svs:RuleName>Rule 2</svs:RuleName>
80-
<svs:Linenumber>1</svs:Linenumber>
80+
<svs:LineNumber>1</svs:LineNumber>
8181
<svs:ColumnNumber>2</svs:ColumnNumber>
8282
</svs:ValidationErrors>
8383
<svs:ValidationErrors>
8484
<svs:RuleName>Rule 3</svs:RuleName>
85-
<svs:Linenumber>1</svs:Linenumber>
85+
<svs:LineNumber>1</svs:LineNumber>
8686
<svs:ColumnNumber>2</svs:ColumnNumber>
8787
</svs:ValidationErrors>
8888
</svs:SclValidateResponse>
@@ -131,31 +131,31 @@ describe('CompasValidateSchema', () => {
131131
<svs:ValidationErrors>
132132
<svs:Message>Message 1</svs:Message>
133133
<svs:RuleName></svs:RuleName>
134-
<svs:Linenumber></svs:Linenumber>
134+
<svs:LineNumber></svs:LineNumber>
135135
<svs:ColumnNumber></svs:ColumnNumber>
136136
</svs:ValidationErrors>
137137
<svs:ValidationErrors>
138138
<svs:Message>Message 2</svs:Message>
139139
<svs:RuleName>Rule 2</svs:RuleName>
140-
<svs:Linenumber></svs:Linenumber>
140+
<svs:LineNumber></svs:LineNumber>
141141
<svs:ColumnNumber></svs:ColumnNumber>
142142
</svs:ValidationErrors>
143143
<svs:ValidationErrors>
144144
<svs:Message>Message 3</svs:Message>
145145
<svs:RuleName></svs:RuleName>
146-
<svs:Linenumber>3</svs:Linenumber>
146+
<svs:LineNumber>3</svs:LineNumber>
147147
<svs:ColumnNumber></svs:ColumnNumber>
148148
</svs:ValidationErrors>
149149
<svs:ValidationErrors>
150150
<svs:Message>Message 4</svs:Message>
151151
<svs:RuleName></svs:RuleName>
152-
<svs:Linenumber></svs:Linenumber>
152+
<svs:LineNumber></svs:LineNumber>
153153
<svs:ColumnNumber>4</svs:ColumnNumber>
154154
</svs:ValidationErrors>
155155
<svs:ValidationErrors>
156156
<svs:Message>Message 5</svs:Message>
157157
<svs:RuleName>Rule 5</svs:RuleName>
158-
<svs:Linenumber>5</svs:Linenumber>
158+
<svs:LineNumber>5</svs:LineNumber>
159159
<svs:ColumnNumber>55</svs:ColumnNumber>
160160
</svs:ValidationErrors>
161161
<svs:ValidationErrors>
@@ -179,7 +179,7 @@ describe('CompasValidateSchema', () => {
179179
)[0];
180180
}
181181

182-
it('when both rule name, linenumber and column number are missing then undefined returned', () => {
182+
it('when both rule name, line number and column number are missing then undefined returned', () => {
183183
const validationError = getValidationError('Message 1');
184184

185185
const result = element['createMessage'](validationError);
@@ -193,7 +193,7 @@ describe('CompasValidateSchema', () => {
193193
expect(result).to.be.equal('Rule: Rule 2');
194194
});
195195

196-
it('when only linenumber is filled then Linenumber string returned', () => {
196+
it('when only line number is filled then Line number string returned', () => {
197197
const validationError = getValidationError('Message 3');
198198

199199
const result = element['createMessage'](validationError);
@@ -207,7 +207,7 @@ describe('CompasValidateSchema', () => {
207207
expect(result).to.be.equal('Column: 4');
208208
});
209209

210-
it('when rule name, linenumber and column number are filled then full message returned', () => {
210+
it('when rule name, line number and column number are filled then full message returned', () => {
211211
const validationError = getValidationError('Message 5');
212212

213213
const result = element['createMessage'](validationError);

0 commit comments

Comments
 (0)