Subscriber Later Binding (GOOSE): Connect FCDA to ExtRef (openscd#1004)

* fix: extRefLists title not rendering correctly

* test: connect FCDA to extRef and verify  correct available/subscribed lists length

* test: missing snapshot test update

Author: juancho0202

src/editors/subscription/later-binding/ext-ref-later-binding-list.ts

@@ -244,14 +244,11 @@ export class ExtRefLaterBindingList extends LitElement {
       : undefined;
 
     return html`<h1>
-      ${translate(
-        'subscription.laterBinding.extRefList.SampledValueControl.title',
-        {
-          controlTag: this.controlTag,
-          controlElementName: controlElementName ?? '-',
-          fcdaName: fcdaName ?? '-',
-        }
-      )}
+      ${translate('subscription.laterBinding.extRefList.title', {
+        controlTag: this.controlTag,
+        controlElementName: controlElementName ?? '-',
+        fcdaName: fcdaName ?? '-',
+      })}
     </h1>`;
   }
 

test/integration/editors/GooseSubscriberLaterBinding.test.ts

@@ -29,6 +29,39 @@ describe('GOOSE Subscribe Later Binding Plugin', () => {
     );
   });
 
+  it('when subscribing an available ExtRef then the lists are changed', async () => {
+    const svcListElement = getFCDALaterBindingList(element);
+    const extRefListElement = getExtrefLaterBindingList(element);
+
+    (<HTMLElement>(
+      svcListElement.shadowRoot!.querySelector(
+        'mwc-list-item[value="GOOSE_Publisher>>QB2_Disconnector>GOOSE1 GOOSE_Publisher>>QB2_Disconnector>GOOSE1sDataSet>QB1_Disconnector/ CSWI 1.Pos q (ST)"]'
+      )
+    )).click();
+    await element.requestUpdate();
+
+    expect(
+      extRefListElement['getSubscribedExtRefElements']().length
+    ).to.be.equal(0);
+    expect(
+      extRefListElement['getAvailableExtRefElements']().length
+    ).to.be.equal(2);
+
+    (<HTMLElement>(
+      extRefListElement.shadowRoot!.querySelector(
+        'mwc-list-item[value="GOOSE_Subscriber>>Earth_Switch> CILO 1>Pos;CSWI1/Pos/stVal[0]"]'
+      )
+    )).click();
+    await element.requestUpdate();
+
+    expect(
+      extRefListElement['getSubscribedExtRefElements']().length
+    ).to.be.equal(1);
+    expect(
+      extRefListElement['getAvailableExtRefElements']().length
+    ).to.be.equal(1);
+  });
+
   it('when unsubscribing a subscribed ExtRef then the lists are changed', async () => {
     const gooseListElement = getFCDALaterBindingList(element);
     const extRefListElement = getExtrefLaterBindingList(element);

test/unit/editors/subscription/later-binding/__snapshots__/ext-ref-laterbinding-list.test.snap.js

@@ -22,7 +22,7 @@ snapshots["smv-list with document loaded looks like the latest snapshot, but no
 snapshots["smv-list with document loaded when SVC has no subscriptions looks like the latest snapshot, when SVC has no subscriptions"] = 
 `<section tabindex="0">
   <h1>
-    [subscription.laterBinding.extRefList.SampledValueControl.title]
+    [subscription.laterBinding.extRefList.title]
   </h1>
   <filtered-list>
     <mwc-list-item
@@ -224,7 +224,7 @@ snapshots["smv-list with document loaded when SVC has no subscriptions looks lik
 snapshots["smv-list with document loaded when SVC has a single subscriptions looks like the latest snapshot, "] = 
 `<section tabindex="0">
   <h1>
-    [subscription.laterBinding.extRefList.SampledValueControl.title]
+    [subscription.laterBinding.extRefList.title]
   </h1>
   <filtered-list>
     <mwc-list-item
@@ -437,7 +437,7 @@ snapshots["smv-list with document loaded when SVC has a single subscriptions loo
 snapshots["smv-list when SVC has a multiple subscriptions looks like the latest snapshot, "] = 
 `<section tabindex="0">
   <h1>
-    [subscription.laterBinding.extRefList.SampledValueControl.title]
+    [subscription.laterBinding.extRefList.title]
   </h1>
   <filtered-list>
     <mwc-list-item
@@ -688,10 +688,10 @@ snapshots["gse-list with gse document loaded looks like the latest snapshot, but
 `;
 /* end snapshot gse-list with gse document loaded looks like the latest snapshot, but no event fired */
 
-snapshots["gse-list with gse document loaded when GSEControl has no subscriptions looks like the latest snapshot, when SVC has no subscriptions"] = 
+snapshots["gse-list with gse document loaded when GSEControl has no subscriptions looks like the latest snapshot, when GSEControl has no subscriptions"] = 
 `<section tabindex="0">
   <h1>
-    [subscription.laterBinding.extRefList.SampledValueControl.title]
+    [subscription.laterBinding.extRefList.title]
   </h1>
   <filtered-list>
     <mwc-list-item
@@ -774,12 +774,12 @@ snapshots["gse-list with gse document loaded when GSEControl has no subscription
   </filtered-list>
 </section>
 `;
-/* end snapshot gse-list with gse document loaded when GSEControl has no subscriptions looks like the latest snapshot, when SVC has no subscriptions */
+/* end snapshot gse-list with gse document loaded when GSEControl has no subscriptions looks like the latest snapshot, when GSEControl has no subscriptions */
 
 snapshots["gse-list with gse document loaded when GSEControl has a single subscription looks like the latest snapshot, "] = 
 `<section tabindex="0">
   <h1>
-    [subscription.laterBinding.extRefList.SampledValueControl.title]
+    [subscription.laterBinding.extRefList.title]
   </h1>
   <filtered-list>
     <mwc-list-item
@@ -878,7 +878,7 @@ snapshots["gse-list with gse document loaded when GSEControl has a single subscr
 snapshots["gse-list when GSEControl has a multiple subscriptions looks like the latest snapshot, "] = 
 `<section tabindex="0">
   <h1>
-    [subscription.laterBinding.extRefList.SampledValueControl.title]
+    [subscription.laterBinding.extRefList.title]
   </h1>
   <filtered-list>
     <mwc-list-item
@@ -990,91 +990,3 @@ snapshots["gse-list when GSEControl has a multiple subscriptions looks like the
 `;
 /* end snapshot gse-list when GSEControl has a multiple subscriptions looks like the latest snapshot,  */
 
-snapshots["gse-list with gse document loaded when GSEControl has no subscriptions looks like the latest snapshot, when GSEControl has no subscriptions"] = 
-`<section tabindex="0">
-  <h1>
-    [subscription.laterBinding.extRefList.SampledValueControl.title]
-  </h1>
-  <filtered-list>
-    <mwc-list-item
-      aria-disabled="false"
-      noninteractive=""
-      tabindex="-1"
-      value=""
-    >
-      <span>
-        [subscription.subscriber.subscribed]
-      </span>
-    </mwc-list-item>
-    <li
-      divider=""
-      role="separator"
-    >
-    </li>
-    <mwc-list-item
-      aria-disabled="false"
-      graphic="large"
-      noninteractive=""
-      tabindex="-1"
-    >
-      [subscription.laterBinding.extRefList.noSubscribedExtRefs]
-    </mwc-list-item>
-    <mwc-list-item
-      aria-disabled="false"
-      noninteractive=""
-      tabindex="-1"
-      value="Interlocking.Input GOOSE_Subscriber>>Earth_Switch> CILO 1>Pos;CSWI1/Pos/stVal[0] Restricted To Pos GOOSE_Subscriber>>Earth_Switch> CSWI 1>someRestrictedExtRef[0]"
-    >
-      <span>
-        [subscription.subscriber.availableToSubscribe]
-      </span>
-    </mwc-list-item>
-    <li
-      divider=""
-      role="separator"
-    >
-    </li>
-    <mwc-list-item
-      aria-disabled="false"
-      graphic="large"
-      mwc-list-item=""
-      tabindex="-1"
-      twoline=""
-      value="GOOSE_Subscriber>>Earth_Switch> CILO 1>Pos;CSWI1/Pos/stVal[0]"
-    >
-      <span>
-        Pos;CSWI1/Pos/stVal
-                 (Interlocking.Input)
-      </span>
-      <span slot="secondary">
-        GOOSE_Subscriber>>Earth_Switch> CILO 1>Pos;CSWI1/Pos/stVal[0]
-      </span>
-      <mwc-icon slot="graphic">
-        arrow_back
-      </mwc-icon>
-    </mwc-list-item>
-    <mwc-list-item
-      aria-disabled="true"
-      disabled=""
-      graphic="large"
-      mwc-list-item=""
-      tabindex="-1"
-      twoline=""
-      value="GOOSE_Subscriber>>Earth_Switch> CSWI 1>someRestrictedExtRef[0]"
-    >
-      <span>
-        someRestrictedExtRef
-                 (Restricted To Pos)
-      </span>
-      <span slot="secondary">
-        GOOSE_Subscriber>>Earth_Switch> CSWI 1>someRestrictedExtRef[0]
-      </span>
-      <mwc-icon slot="graphic">
-        arrow_back
-      </mwc-icon>
-    </mwc-list-item>
-  </filtered-list>
-</section>
-`;
-/* end snapshot gse-list with gse document loaded when GSEControl has no subscriptions looks like the latest snapshot, when GSEControl has no subscriptions */
-