chore: update @compas-oscd/core to version 0.1.23 and adjust plugin configurations

Author: noraeb

package-lock.json

@@ -18,7 +18,7 @@
   "module": "open-scd.js",
   "type": "module",
   "dependencies": {
-    "@compas-oscd/core": "^0.1.21",
+    "@compas-oscd/core": "^0.1.23",
     "@compas-oscd/xml": "^0.0.1",
     "@material/mwc-dialog": "0.22.1",
     "@material/mwc-drawer": "0.22.1",
@@ -74,7 +74,7 @@
     "build": "npm run doc && npm run build:only && cp .nojekyll build/",
     "build:only": "npx rimraf node_modules/.cache/snowpack/build/[email protected] && snowpack build && workbox generateSW workbox-config.cjs",
     "__comment:start": "snowpack dev fails if the lit package is cached. I don't know why, but we have to delete it before starting",
-    "start": "npx rimraf node_modules/.cache/snowpack/build/[email protected] && NODE_OPTIONS=--no-experimental-require-module snowpack dev"
+    "start": "npx rimraf node_modules/.cache/snowpack/build/[email protected] && snowpack dev"
   },
   "devDependencies": {
     "@commitlint/cli": "^13.1.0",

packages/compas-open-scd/package.json

@@ -30,7 +30,7 @@ import { ActionDetail } from '@material/mwc-list';
 
 import { officialPlugins as builtinPlugins } from '../public/js/plugins.js';
 import type { PluginSet, Plugin as CorePlugin } from '@compas-oscd/core';
-import { OscdApi } from '@compas-oscd/core';
+import { OscdApi, XMLEditor } from '@compas-oscd/core';
 import { classMap } from 'lit-html/directives/class-map.js';
 import {
   newConfigurePluginEvent,
@@ -45,6 +45,18 @@ import { languages, loader } from './translations/loader.js';
 
 const LNODE_LIB_DOC_ID = 'fc55c46d-c109-4ccd-bf66-9f1d0e135689';
 
+interface MenuPluginConfig
+  extends Omit<Plugin, 'position' | 'kind' | 'active'> {
+  position?: MenuPosition | number;
+  active?: boolean;
+}
+
+interface EditorPluginConfig
+  extends Omit<Plugin, 'position' | 'kind' | 'active'> {
+  position?: undefined;
+  active?: boolean;
+}
+
 /** The `<open-scd>` custom element is the main entry point of the
  * Open Substation Configuration Designer. */
 @customElement('open-scd')
@@ -302,22 +314,26 @@ export class OpenSCD extends LitElement {
   @property({ type: Object }) plugins: PluginSet = { menu: [], editor: [] };
 
   get parsedPlugins(): Plugin[] {
-    const menuPlugins: Plugin[] = this.plugins.menu.map(plugin => {
-      let newPosition: MenuPosition | undefined =
-        plugin.position as MenuPosition;
-      if (typeof plugin.position === 'number') {
-        newPosition = undefined;
+    const menuPlugins: Plugin[] = (this.plugins.menu as MenuPluginConfig[]).map(
+      (plugin: MenuPluginConfig): Plugin => {
+        let newPosition: MenuPosition | undefined =
+          plugin.position as MenuPosition;
+        if (typeof plugin.position === 'number') {
+          newPosition = undefined;
+        }
+
+        return {
+          ...plugin,
+          position: newPosition,
+          kind: 'menu' as PluginKind,
+          active: plugin.active ?? false,
+        };
       }
+    );
 
-      return {
-        ...plugin,
-        position: newPosition,
-        kind: 'menu' as PluginKind,
-        active: plugin.active ?? false,
-      };
-    });
-
-    const editorPlugins: Plugin[] = this.plugins.editor.map(plugin => {
+    const editorPlugins: Plugin[] = (
+      this.plugins.editor as EditorPluginConfig[]
+    ).map((plugin: EditorPluginConfig): Plugin => {
       const editorPlugin: Plugin = {
         ...plugin,
         position: undefined,