Skip to content

Commit a1f2f6a

Browse files
author
Dennis Labordus
committed
Sorted list of labels.
Signed-off-by: Dennis Labordus <[email protected]>
1 parent e8f4d5a commit a1f2f6a

File tree

3 files changed

+12
-8
lines changed

3 files changed

+12
-8
lines changed

src/compas/CompasSclList.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,8 @@ export class CompasSclList extends LitElement {
9898
new Set(
9999
Array.from(xmlResponse.querySelectorAll('Label') ?? [])
100100
.map(element => element.textContent)
101-
.filter(value => !!value)
101+
.filter(label => !!label)
102+
.sort((label1, label2) => label1!.localeCompare(label2!))
102103
)
103104
) as string[];
104105
this.selectedLabels = this.labels;

test/unit/compas/CompasSclList.test.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,10 @@ describe('compas-scl-list', () => {
151151
.flatMap(label => label)
152152
.filter(label => !!label)
153153
.map(label => label!.textContent)
154-
.filter(labelValue => !!labelValue) as string[]
154+
.filter(labelValue => !!labelValue)
155+
.sort((label1, label2) =>
156+
label1!.localeCompare(label2!)
157+
) as string[]
155158
)
156159
);
157160
if (labels) {

test/unit/compas/__snapshots__/CompasSclList.test.snap.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -74,29 +74,29 @@ snapshots[
7474
mwc-list-item=""
7575
selected=""
7676
tabindex="0"
77-
value="Netherlands"
77+
value="Amsterdam"
7878
>
79-
Netherlands
79+
Amsterdam
8080
</mwc-check-list-item>
8181
<mwc-check-list-item
8282
aria-disabled="false"
8383
graphic="control"
8484
mwc-list-item=""
8585
selected=""
8686
tabindex="-1"
87-
value="Utrecht"
87+
value="Netherlands"
8888
>
89-
Utrecht
89+
Netherlands
9090
</mwc-check-list-item>
9191
<mwc-check-list-item
9292
aria-disabled="false"
9393
graphic="control"
9494
mwc-list-item=""
9595
selected=""
9696
tabindex="-1"
97-
value="Amsterdam"
97+
value="Utrecht"
9898
>
99-
Amsterdam
99+
Utrecht
100100
</mwc-check-list-item>
101101
</oscd-filter-button>
102102
</div>

0 commit comments

Comments
 (0)