Skip to content

Commit a489729

Browse files
author
Dennis Labordus
authored
Merge pull request #191 from com-pas/add-ids
Add ID to Dialogs
2 parents 0fb54ca + 93d88b8 commit a489729

File tree

4 files changed

+24
-6
lines changed

4 files changed

+24
-6
lines changed

src/menu/CompasSave.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,10 @@ export default class CompasSaveMenuPlugin extends LitElement {
3535
}
3636

3737
render(): TemplateResult {
38-
return html`<mwc-dialog heading="${translate('compas.save.title')}">
38+
return html`<mwc-dialog
39+
id="compas-save-dlg"
40+
heading="${translate('compas.save.title')}"
41+
>
3942
${!this.doc || !this.docName
4043
? html`<compas-loading></compas-loading>`
4144
: html`

src/menu/CompasSaveAs.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,10 @@ export default class CompasSaveAsMenuPlugin extends LitElement {
3232
}
3333

3434
render(): TemplateResult {
35-
return html`<mwc-dialog heading="${translate('compas.save.title')}">
35+
return html`<mwc-dialog
36+
id="compas-save-as-dlg"
37+
heading="${translate('compas.save.title')}"
38+
>
3639
${!this.doc || !this.docName
3740
? html`<compas-loading></compas-loading>`
3841
: html`

test/unit/menu/__snapshots__/CompasSave.test.snap.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,21 @@
22
export const snapshots = {};
33

44
snapshots["compas-save-menu with no document loaded looks like the latest snapshot"] =
5-
`<mwc-dialog heading="[compas.save.title]">
5+
`<mwc-dialog
6+
heading="[compas.save.title]"
7+
id="compas-save-dlg"
8+
>
69
<compas-loading>
710
</compas-loading>
811
</mwc-dialog>
912
`;
1013
/* end snapshot compas-save-menu with no document loaded looks like the latest snapshot */
1114

1215
snapshots["compas-save-menu with document loaded looks like the latest snapshot"] =
13-
`<mwc-dialog heading="[compas.save.title]">
16+
`<mwc-dialog
17+
heading="[compas.save.title]"
18+
id="compas-save-dlg"
19+
>
1420
<compas-save>
1521
</compas-save>
1622
<mwc-button

test/unit/menu/__snapshots__/CompasSaveAs.test.snap.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,21 @@
22
export const snapshots = {};
33

44
snapshots["compas-save-menu with no document loaded looks like the latest snapshot"] =
5-
`<mwc-dialog heading="[compas.save.title]">
5+
`<mwc-dialog
6+
heading="[compas.save.title]"
7+
id="compas-save-as-dlg"
8+
>
69
<compas-loading>
710
</compas-loading>
811
</mwc-dialog>
912
`;
1013
/* end snapshot compas-save-menu with no document loaded looks like the latest snapshot */
1114

1215
snapshots["compas-save-menu with document loaded looks like the latest snapshot"] =
13-
`<mwc-dialog heading="[compas.save.title]">
16+
`<mwc-dialog
17+
heading="[compas.save.title]"
18+
id="compas-save-as-dlg"
19+
>
1420
<compas-save>
1521
</compas-save>
1622
<mwc-button

0 commit comments

Comments
 (0)