Skip to content

Commit b5e2621

Browse files
authored
fix(translation): improve capitalization add missing menu.new (#307)
* Improve capitalization in some cases, correct typos in English, add translation for menu.new, closes #306 * Update snapshots
1 parent 58bebc9 commit b5e2621

File tree

6 files changed

+97
-27
lines changed

6 files changed

+97
-27
lines changed

__snapshots__/BDA wizarding editing integration.md

Lines changed: 43 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,21 @@
22

33
## `defines a editBDaWizard to edit an existing BDA`
44

5-
#### `looks like the latest snapshot`
5+
#### `looks like the latest snapshot`
66

77
```html
8-
<mwc-dialog defaultaction="close" heading="Edit BDA" open="">
8+
<mwc-dialog
9+
defaultaction="close"
10+
heading="Edit BDA"
11+
open=""
12+
>
913
<div id="wizard-content">
10-
<mwc-button fullwidth="" icon="delete" label="Remove" trailingicon="">
14+
<mwc-button
15+
fullwidth=""
16+
icon="delete"
17+
label="Remove"
18+
trailingicon=""
19+
>
1120
</mwc-button>
1221
<wizard-textfield
1322
dialoginitialfocus=""
@@ -352,7 +361,11 @@
352361
EntryID
353362
</mwc-list-item>
354363
</wizard-select>
355-
<wizard-select fixedmenuposition="" helper="Type" label="type">
364+
<wizard-select
365+
fixedmenuposition=""
366+
helper="Type"
367+
label="type"
368+
>
356369
<mwc-list-item
357370
aria-disabled="true"
358371
class="Struct"
@@ -537,7 +550,12 @@
537550
false
538551
</mwc-list-item>
539552
</wizard-select>
540-
<wizard-select disabled="" helper="Default value" label="Val" nullable="">
553+
<wizard-select
554+
disabled=""
555+
helper="Default value"
556+
label="Val"
557+
nullable=""
558+
>
541559
<mwc-list-item
542560
aria-disabled="false"
543561
aria-selected="false"
@@ -614,14 +632,19 @@
614632
>
615633
</mwc-button>
616634
</mwc-dialog>
635+
617636
```
618637

619638
## `defines a createBDaWizard to create a new BDA element`
620639

621-
#### `looks like the latest snapshot`
640+
#### `looks like the latest snapshot`
622641

623642
```html
624-
<mwc-dialog defaultaction="close" heading="Edit BDA" open="">
643+
<mwc-dialog
644+
defaultaction="close"
645+
heading="Edit BDA"
646+
open=""
647+
>
625648
<div id="wizard-content">
626649
<wizard-textfield
627650
dialoginitialfocus=""
@@ -963,7 +986,11 @@
963986
EntryID
964987
</mwc-list-item>
965988
</wizard-select>
966-
<wizard-select fixedmenuposition="" helper="Type" label="type">
989+
<wizard-select
990+
fixedmenuposition=""
991+
helper="Type"
992+
label="type"
993+
>
967994
<mwc-list-item
968995
aria-disabled="false"
969996
class="Struct"
@@ -1135,7 +1162,12 @@
11351162
false
11361163
</mwc-list-item>
11371164
</wizard-select>
1138-
<wizard-select disabled="" helper="Default value" label="Val" nullable="">
1165+
<wizard-select
1166+
disabled=""
1167+
helper="Default value"
1168+
label="Val"
1169+
nullable=""
1170+
>
11391171
</wizard-select>
11401172
<wizard-textfield
11411173
disabled=""
@@ -1161,4 +1193,6 @@
11611193
>
11621194
</mwc-button>
11631195
</mwc-dialog>
1196+
11641197
```
1198+

__snapshots__/DA wizarding editing integration.md

Lines changed: 45 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,21 @@
22

33
## `defines a editDaWizard to edit an existing DA`
44

5-
#### `looks like the latest snapshot`
5+
#### `looks like the latest snapshot`
66

77
```html
8-
<mwc-dialog defaultaction="close" heading="Edit DA" open="">
8+
<mwc-dialog
9+
defaultaction="close"
10+
heading="Edit DA"
11+
open=""
12+
>
913
<div id="wizard-content">
10-
<mwc-button fullwidth="" icon="delete" label="Remove" trailingicon="">
14+
<mwc-button
15+
fullwidth=""
16+
icon="delete"
17+
label="Remove"
18+
trailingicon=""
19+
>
1120
</mwc-button>
1221
<wizard-textfield
1322
dialoginitialfocus=""
@@ -352,7 +361,11 @@
352361
EntryID
353362
</mwc-list-item>
354363
</wizard-select>
355-
<wizard-select fixedmenuposition="" helper="Type" label="type">
364+
<wizard-select
365+
fixedmenuposition=""
366+
helper="Type"
367+
label="type"
368+
>
356369
<mwc-list-item
357370
aria-disabled="true"
358371
class="Struct"
@@ -581,7 +594,12 @@
581594
false
582595
</mwc-list-item>
583596
</wizard-select>
584-
<wizard-select disabled="" helper="Default value" label="Val" nullable="">
597+
<wizard-select
598+
disabled=""
599+
helper="Default value"
600+
label="Val"
601+
nullable=""
602+
>
585603
<mwc-list-item
586604
aria-disabled="false"
587605
aria-selected="false"
@@ -643,7 +661,7 @@
643661
</wizard-textfield>
644662
<wizard-select
645663
fixedmenuposition=""
646-
helper="Function contraint"
664+
helper="Function constraint"
647665
label="fc"
648666
required=""
649667
>
@@ -866,14 +884,19 @@
866884
>
867885
</mwc-button>
868886
</mwc-dialog>
887+
869888
```
870889

871890
## `defines a createDaWizard to create a new DA element`
872891

873-
#### `looks like the latest snapshot`
892+
#### `looks like the latest snapshot`
874893

875894
```html
876-
<mwc-dialog defaultaction="close" heading="Edit DA" open="">
895+
<mwc-dialog
896+
defaultaction="close"
897+
heading="Edit DA"
898+
open=""
899+
>
877900
<div id="wizard-content">
878901
<wizard-textfield
879902
dialoginitialfocus=""
@@ -1215,7 +1238,11 @@
12151238
EntryID
12161239
</mwc-list-item>
12171240
</wizard-select>
1218-
<wizard-select fixedmenuposition="" helper="Type" label="type">
1241+
<wizard-select
1242+
fixedmenuposition=""
1243+
helper="Type"
1244+
label="type"
1245+
>
12191246
<mwc-list-item
12201247
aria-disabled="false"
12211248
class="Struct"
@@ -1427,7 +1454,12 @@
14271454
false
14281455
</mwc-list-item>
14291456
</wizard-select>
1430-
<wizard-select disabled="" helper="Default value" label="Val" nullable="">
1457+
<wizard-select
1458+
disabled=""
1459+
helper="Default value"
1460+
label="Val"
1461+
nullable=""
1462+
>
14311463
</wizard-select>
14321464
<wizard-textfield
14331465
disabled=""
@@ -1438,7 +1470,7 @@
14381470
</wizard-textfield>
14391471
<wizard-select
14401472
fixedmenuposition=""
1441-
helper="Function contraint"
1473+
helper="Function constraint"
14421474
label="fc"
14431475
required=""
14441476
>
@@ -1658,4 +1690,6 @@
16581690
>
16591691
</mwc-button>
16601692
</mwc-dialog>
1693+
16611694
```
1695+

src/translations/de.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ export const de: Translations = {
4444
showieds: 'Zeige IEDs im Substation-Editor',
4545
},
4646
menu: {
47+
new: 'Neues projekt',
4748
title: 'Menü',
4849
viewLog: 'Protokoll anzeigen',
4950
viewDiag: 'Daignose anzeigen',

src/translations/en.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@ export const en = {
1919
sAddr: 'Short address',
2020
valKind: 'Value kind',
2121
valImport: 'Import value',
22-
fc: 'Function contraint',
22+
fc: 'Function constraint',
2323
LNodeType: 'Logical Node Type',
24-
lnClass: 'Logical node class',
24+
lnClass: 'Logical Node Class',
2525
accessControl: 'Access control',
2626
transient: 'Transient data',
2727
Val: 'Default value',
28-
dchg: 'Triggre on data change',
28+
dchg: 'Trigger on data change',
2929
qchg: 'Trigger on quality change',
3030
dupd: 'Trigger on data update',
3131
fixedOffs: 'Fixed offset',
@@ -42,6 +42,7 @@ export const en = {
4242
showieds: 'Show IEDs in substation editor',
4343
},
4444
menu: {
45+
new: 'New project',
4546
title: 'Menu',
4647
viewLog: 'View log',
4748
viewDiag: 'View diagnostics',
@@ -283,7 +284,7 @@ export const en = {
283284
wizard: {
284285
primary: 'Guess content',
285286
title: 'Select control model (ctlModel)',
286-
description: `IEDs often contain more controlable logical nodes than switch gear in the field. \n You can select the control model(s) used specific for switch gear.`,
287+
description: `IEDs often contain more controllable logical nodes than switchgear in the field. \n You can select the control model(s) used specific for switchgear.`,
287288
},
288289
},
289290
merge: {

src/wizards/controlwithiedname.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ export function selectExtRefsWizard(
173173
title: cbId + ' - ' + iedName,
174174
primary: {
175175
icon: 'delete',
176-
label: get('disconnect'), // FIXME: translate
176+
label: get('disconnect'),
177177
action: disconnect(sinkExtRefs),
178178
},
179179
secondary: {

test/integration/editors/templates/lnodetype-wizard.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ describe('LNodeType wizards', () => {
315315
)
316316
).to.not.exist;
317317
});
318-
it('adds new lnodetype with corrrect id and lnClass', async () => {
318+
it('adds new LNodeType with correct id and lnClass', async () => {
319319
beh.value = ensId;
320320
enaOpn.value = spsId;
321321
enaCls.value = spsId;
@@ -331,7 +331,7 @@ describe('LNodeType wizards', () => {
331331
)
332332
).to.exist;
333333
});
334-
it('adds selected DOs to new lnodetype', async () => {
334+
it('adds selected DOs to new LNodeType', async () => {
335335
beh.value = ensId;
336336
enaOpn.value = spsId;
337337
enaCls.value = spsId;

0 commit comments

Comments
 (0)