Skip to content

Commit c850088

Browse files
noraebnoraeb
authored
feat: remove communication from the substation editor and use oscd-publisher plugin (openscd#1650)
* feat: use openenergytools publisher plugin * feat: add scoped custom elements polyfill * feat: add oscd-publisher as submodule * fix: remove space * feat: use openscd publisher * feat: enable submodule checkout in GitHub workflows * feat: remove communication buttons and update tests * feat: update docs * fix: unit test * feat: remove publisher plugin
1 parent ffeb42b commit c850088

File tree

49 files changed

+72
-4808
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

49 files changed

+72
-4808
lines changed

‎.github/workflows/build-and-deploy.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ jobs:
1212
steps:
1313
- name: Checkout
1414
uses: actions/[email protected]
15+
with:
16+
submodules: "true"
1517

1618
- name: Use Node.js 18.x
1719
uses: actions/setup-node@v1

‎.github/workflows/pr-preview.yml‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ jobs:
2121
steps:
2222
- name: Checkout
2323
uses: actions/checkout@v3
24-
24+
with:
25+
submodules: "true"
2526
- name: Install and Build OpenSCD
2627
if: github.event.action != 'closed' # You might want to skip the build if the PR has been closed
2728
run: |

‎.github/workflows/release-please.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ jobs:
2020
token: ${{ secrets.GITHUB_TOKEN }}
2121
# The logic below handles the npm publication:
2222
- uses: actions/checkout@v4
23+
with:
24+
submodules: "true"
2325
if: ${{ steps.release.outputs.release_created }}
2426
- uses: actions/setup-node@v4
2527
with:

‎.github/workflows/test-and-build.yml‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ jobs:
77
steps:
88
- name: Checkout
99
uses: actions/[email protected]
10-
10+
with:
11+
submodules: "true"
1112
- name: Use Node.js 18.x
1213
uses: actions/setup-node@v1
1314
with:

‎.gitmodules‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
[submodule "packages/external-plugins/oscd-publisher"]
2+
path = packages/external-plugins/oscd-publisher
3+
url = https://github.com/openscd/oscd-publisher
4+
branch = deploy

‎docs/plug-ins.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,10 +119,10 @@ implemented in these plugins.
119119
120120
### Publisher
121121
122-
> <kbd>✅ Official</kbd> | <kbd>Editor</kbd> | by [OpenSCD](https://github.com/openscd) | [Repository](https://github.com/openscd/open-scd/)
123-
>
122+
> <kbd>✅ Official</kbd> | <kbd>Editor</kbd> | by [OpenSCD](https://github.com/openscd) | [Repository](https://github.com/openscd/oscd-publisher/)
123+
>
124124
> ```
125-
> https://openscd.github.io/plugins/src/editors/Publisher.js
125+
> https://openscd.github.io/external-plugins/oscd-publisher/oscd-publisher.js
126126
> ```
127127
128128
### Cleanup

‎packages/distribution/index.html‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@
4242
<body>
4343
<open-scd></open-scd>
4444

45+
<script src="./src/polyfill/scoped-custom-elements-polyfill.js"></script>
46+
4547
<script>
4648
const _customElementsDefine = window.customElements.define;
4749
window.customElements.define = (name, cl, conf) => {

‎packages/distribution/snowpack.config.mjs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ export default {
2727
'./': '/',
2828
'../plugins/': '/plugins/',
2929
'../openscd/': '/openscd/',
30+
'../external-plugins/': '/external-plugins/',
3031
},
3132
alias: {
3233
'@openscd/open-scd': '../openscd/',

‎packages/distribution/src/polyfill/scoped-custom-elements-polyfill.js‎

Lines changed: 42 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/external-plugins/oscd-publisher‎

Submodule oscd-publisher added at afb25a6

0 commit comments

Comments
 (0)